Laylem reports: [Crafting Recipe] Why can you ... #3239

Closed
opened 2022-12-15 05:04:46 +00:00 by yourland-report · 3 comments

Laylem reports a bug:

[Crafting Recipe] Why can you craft moretrees palmtree leaves into... itself?? Is that intended to give a ethereal palmtree leaf?

Player position:

{
	z = -1992.4410400391,
	x = -948.19903564453,
	y = -9.4989995956421
}

Player look:

{
	z = 0.6506912112236,
	x = 0.68856817483902,
	y = -0.32011696696281
}

Player information:

{
	patch = 1,
	lang_code = "",
	state = "Active",
	formspec_version = 6,
	max_rtt = 2.2579998970032,
	version_string = "5.6.1",
	protocol_version = 41,
	ip_version = 6,
	major = 5,
	minor = 6,
	min_rtt = 0.1630000025034,
	avg_rtt = 0.17200000584126,
	min_jitter = 0,
	max_jitter = 2.0810000896454,
	avg_jitter = 0,
	connection_uptime = 2526,
	serialization_version = 29
}

Player meta:

{
	fields = {
		["ocean_build.ocean_built"] = "11",
		crafted = "48836",
		["stamina:level"] = "17",
		yl_church = "return {[\"last_death_portal\"] = 1670664823, [\"last_death\"] = {[\"z\"] = -2000, [\"x\"] = -961, [\"y\"] = -26}, [\"last_heal\"] = 1662278340}",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "110",
		repellant = "0",
		yl_commons_player_created = "1659420654",
		yl_commons_player_joined = "1671078189",
		jointime = "1659420654",
		xp = "285720",
		hud_state = "on",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_commons_thankyou = "46",
		placed_nodes = "69887",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 16120\", \"3d_armor:chestplate_crystal 1 16120\", \"3d_armor:leggings_crystal 1 16120\", \"3d_armor:boots_crystal 1 16120\", \"shields:shield_rainbow 1 6448\", \"\"}",
		inflicted_damage = "443246",
		arenalib_infobox_arenaID = "0",
		punch_count = "21464",
		partychat = "main",
		bitten = "0",
		["signslib:pos"] = "(-946,-7,-2015)",
		played_time = "1399009",
		digged_nodes = "277910",
		["ocean_build.last_warning"] = "1.66072e+09",
		died = "32"
	}
}

Log identifier


[MOD] yl_report log identifier = gVF6mnXtfy5pmp1FkZdST4mKjHZ36hS8

Profiler save:

profile-20221215T050446.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 5d 1h 35min 43s | max lag: 1.86s | clients (16/42): AliasAlreadyTaken, Bailiff, daydream, Ernesto, Friend-1, jayhizzy, Laylem, mrminer, MulticraftGames, NotWater, Parrish, Service, sherkhan30452, Sokomine, Xonon, YmmaSyed

Teleport command:

/teleport xyz -948 -9 -1992

Compass command:

/give_compass Construction gVF6mnXtfy5pmp1FkZdST4mKjHZ36hS8 D2691E -948 -9 -1992
Laylem reports a bug: > [Crafting Recipe] Why can you craft moretrees palmtree leaves into... itself?? Is that intended to give a ethereal palmtree leaf? Player position: ``` { z = -1992.4410400391, x = -948.19903564453, y = -9.4989995956421 } ``` Player look: ``` { z = 0.6506912112236, x = 0.68856817483902, y = -0.32011696696281 } ``` Player information: ``` { patch = 1, lang_code = "", state = "Active", formspec_version = 6, max_rtt = 2.2579998970032, version_string = "5.6.1", protocol_version = 41, ip_version = 6, major = 5, minor = 6, min_rtt = 0.1630000025034, avg_rtt = 0.17200000584126, min_jitter = 0, max_jitter = 2.0810000896454, avg_jitter = 0, connection_uptime = 2526, serialization_version = 29 } ``` Player meta: ``` { fields = { ["ocean_build.ocean_built"] = "11", crafted = "48836", ["stamina:level"] = "17", yl_church = "return {[\"last_death_portal\"] = 1670664823, [\"last_death\"] = {[\"z\"] = -2000, [\"x\"] = -961, [\"y\"] = -26}, [\"last_heal\"] = 1662278340}", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "110", repellant = "0", yl_commons_player_created = "1659420654", yl_commons_player_joined = "1671078189", jointime = "1659420654", xp = "285720", hud_state = "on", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_commons_thankyou = "46", placed_nodes = "69887", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 16120\", \"3d_armor:chestplate_crystal 1 16120\", \"3d_armor:leggings_crystal 1 16120\", \"3d_armor:boots_crystal 1 16120\", \"shields:shield_rainbow 1 6448\", \"\"}", inflicted_damage = "443246", arenalib_infobox_arenaID = "0", punch_count = "21464", partychat = "main", bitten = "0", ["signslib:pos"] = "(-946,-7,-2015)", played_time = "1399009", digged_nodes = "277910", ["ocean_build.last_warning"] = "1.66072e+09", died = "32" } } ``` Log identifier ``` [MOD] yl_report log identifier = gVF6mnXtfy5pmp1FkZdST4mKjHZ36hS8 ``` Profiler save: ``` profile-20221215T050446.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 5d 1h 35min 43s | max lag: 1.86s | clients (16/42): AliasAlreadyTaken, Bailiff, daydream, Ernesto, Friend-1, jayhizzy, Laylem, mrminer, MulticraftGames, NotWater, Parrish, Service, sherkhan30452, Sokomine, Xonon, YmmaSyed ``` Teleport command: ``` /teleport xyz -948 -9 -1992 ``` Compass command: ``` /give_compass Construction gVF6mnXtfy5pmp1FkZdST4mKjHZ36hS8 D2691E -948 -9 -1992 ```
AliasAlreadyTaken was assigned by yourland-report 2022-12-15 05:04:46 +00:00
flux added the
1. kind/balancing
label 2022-12-15 16:25:01 +00:00
Member

it's apparently an intentional feature of plantlife_modpack, the goal being to allow leaves to be crafted into twigs, but that doesn't "make sense" for palm leaves:

a2cbc18351/trunks/crafting.lua (L9-L18)

for whatever reason, that doesn't apply to date palms? the code is over 9 years old, maybe date palms didn't exist that far back.

i'm in favor of removing this recipe to normalize things.

it's apparently an intentional feature of `plantlife_modpack`, the goal being to allow leaves to be crafted into twigs, but that doesn't "make sense" for palm leaves: https://github.com/mt-mods/plantlife_modpack/blob/a2cbc18351e743c606ac8ad8f11faa33c10aa289/trunks/crafting.lua#L9-L18 for whatever reason, that doesn't apply to date palms? the code is over 9 years old, maybe date palms didn't exist that far back. i'm in favor of removing this recipe to normalize things.
flux added the
4. step/want approval
label 2022-12-15 16:28:03 +00:00

That's not a group, no magic, no nothing. It's simply a "craft into itself" thingy??

minetest.register_craft({ -- except moretrees:palm_leaves
	output = "moretrees:palm_leaves",
	recipe = {{"moretrees:palm_leaves"}}
})
end

Can be savely removed IMO

That's not a group, no magic, no nothing. It's simply a "craft into itself" thingy?? ``` minetest.register_craft({ -- except moretrees:palm_leaves output = "moretrees:palm_leaves", recipe = {{"moretrees:palm_leaves"}} }) end ``` Can be savely removed IMO
AliasAlreadyTaken added the
4. step/approved
label 2022-12-25 22:45:25 +00:00
flux removed the
4. step/want approval
label 2023-01-07 19:22:37 +00:00
flux added this to the flux's TODO list project 2023-01-07 19:23:01 +00:00
flux added the
2. prio/good first issue
label 2023-01-07 19:23:08 +00:00
Member

this was fixed in e8d81528ae and is live

this was fixed in https://gitea.your-land.de/your-land/yl_commons/commit/e8d81528ae02aa701c85f8a0117b417ab2269e79 and is live
flux closed this issue 2023-05-02 21:54:08 +00:00
flux added
5. result/fixed
and removed
4. step/approved
labels 2023-05-02 21:54:23 +00:00
flux removed this from the flux's TODO list project 2023-05-02 21:54:28 +00:00
AliasAlreadyTaken was unassigned by flux 2023-05-02 21:54:33 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3239
No description provided.