flux reports: add the new balrog sounds to a ... #3230
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#3230
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
flux reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
i think they should only trigger when you're deep underground or in the nether, but that's up for discussion
so apparently the random mob sounds are triggered as
ambience_music
? but the files aren't in the ambience mod itself? @AliasAlreadyTaken are those stored in a repo somewhere?I didn't change anything on the ambience mod, as far as I know it takes the sounds already present in other mods.
There is no separate repo for ambience sounds, but there is a texturepack repo. We could add non-texture media files there.
https://gitea.your-land.de/your-land/yl_texturepack
Without looking at the code, if I had to guess, I'd bet they are hardcoded. mobs and ambience are both by TenPlus1
i've looked at the code several times, i couldn't find any obvious source of the monster noises, in ambience, in mobs_redo, anywhere. what i do know, is that they aren't played as a server-wide sound - there's individual calls for every connected player. i'm not 100% certain the
ambience_music
soundspec is actually the culprit, it's just the only thing that showed up in my log.so, per #6299, i've discovered that the "ambient mob sounds" are not actually coming from ambience, but a bug in the engine triggered most often by mobs_redo (for unknown reasons).
that might be fixed with the 5.8.0 update though.
do we instead want to add mob sounds to ambience ourselves?