flux reports: add the new balrog sounds to a ... #3230

New Issue

yourland-report · 2022-12-13T05:18:23+01:00

yourland-report commented

2022-12-13 05:18:23 +01:00

flux reports a bug:

add the new balrog sounds to ambiance

Player position:

{
	z = 580.19903564453,
	x = 1297.8000488281,
	y = 60.5
}

Player look:

{
	z = 0.014463059604168,
	x = 0.99834579229355,
	y = -0.055647242814302
}

Player information:

{
	lang_code = "",
	ip_version = 6,
	min_rtt = 0.1630000025034,
	avg_rtt = 0.17299999296665,
	min_jitter = 0,
	max_jitter = 9.0349998474121,
	avg_jitter = 0,
	connection_uptime = 37387,
	serialization_version = 29,
	patch = 1,
	major = 5,
	minor = 6,
	version_string = "5.6.1",
	state = "Active",
	protocol_version = 41,
	formspec_version = 6,
	max_rtt = 9.9230003356934
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 1136\", \"3d_armor:leggings_rainbow 1 1136\", \"3d_armor:boots_crystal 1 520\", \"shields:shield_rainbow 1 1096\", \"3d_armor:chestplate_rainbow 1 1136\", \"\"}",
		crafted = "47977",
		["stamina:level"] = "3",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["stamina:poisoned"] = "no",
		["petz:lycanthropy"] = "1",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		repellant = "0",
		yl_commons_player_created = "1615351173",
		yl_commons_player_joined = "1670867744",
		yl_commons_thankyou = "185",
		xp = "1375388",
		["petz:werewolf_vignette_id"] = "20",
		punch_count = "126650",
		["petz:werewolf_clan_idx"] = "1",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 1582, [\"x\"] = 1833, [\"y\"] = -27684}, [\"last_death_portal\"] = 1670728451, [\"last_heal\"] = 1615504208}",
		["stamina:exhaustion"] = "44",
		jointime = "1615351173",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf"] = "0",
		inflicted_damage = "2257574",
		bitten = "0",
		["signslib:pos"] = "(1975,19,1178)",
		played_time = "28107234",
		digged_nodes = "1148671",
		placed_nodes = "365190",
		died = "74"
	}
}

Log identifier


[MOD] yl_report log identifier = 37yuk1kK9OJKHvf1L5wVMLdFfphj6eOp

Profiler save:

profile-20221213T041823.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 57min 51s | max lag: 2.25s | clients (16/42): 9T9, AliasAlreadyTaken, Bailiff, DanteLives, daydream, Domough, Ernesto, flux, Frostian, icser, NodeBreaker, Parrish, Service, shanish2, Sokomine, Squawk

Teleport command:

/teleport xyz 1298 61 580

Compass command:

/give_compass Construction 37yuk1kK9OJKHvf1L5wVMLdFfphj6eOp D2691E 1298 61 580

flux reports a bug: > add the new balrog sounds to ambiance Player position: ``` { z = 580.19903564453, x = 1297.8000488281, y = 60.5 } ``` Player look: ``` { z = 0.014463059604168, x = 0.99834579229355, y = -0.055647242814302 } ``` Player information: ``` { lang_code = "", ip_version = 6, min_rtt = 0.1630000025034, avg_rtt = 0.17299999296665, min_jitter = 0, max_jitter = 9.0349998474121, avg_jitter = 0, connection_uptime = 37387, serialization_version = 29, patch = 1, major = 5, minor = 6, version_string = "5.6.1", state = "Active", protocol_version = 41, formspec_version = 6, max_rtt = 9.9230003356934 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 1136\", \"3d_armor:leggings_rainbow 1 1136\", \"3d_armor:boots_crystal 1 520\", \"shields:shield_rainbow 1 1096\", \"3d_armor:chestplate_rainbow 1 1136\", \"\"}", crafted = "47977", ["stamina:level"] = "3", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["stamina:poisoned"] = "no", ["petz:lycanthropy"] = "1", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", repellant = "0", yl_commons_player_created = "1615351173", yl_commons_player_joined = "1670867744", yl_commons_thankyou = "185", xp = "1375388", ["petz:werewolf_vignette_id"] = "20", punch_count = "126650", ["petz:werewolf_clan_idx"] = "1", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"z\"] = 1582, [\"x\"] = 1833, [\"y\"] = -27684}, [\"last_death_portal\"] = 1670728451, [\"last_heal\"] = 1615504208}", ["stamina:exhaustion"] = "44", jointime = "1615351173", hud_state = "on", arenalib_infobox_arenaID = "0", ["petz:werewolf"] = "0", inflicted_damage = "2257574", bitten = "0", ["signslib:pos"] = "(1975,19,1178)", played_time = "28107234", digged_nodes = "1148671", placed_nodes = "365190", died = "74" } } ``` Log identifier ``` [MOD] yl_report log identifier = 37yuk1kK9OJKHvf1L5wVMLdFfphj6eOp ``` Profiler save: ``` profile-20221213T041823.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 57min 51s | max lag: 2.25s | clients (16/42): 9T9, AliasAlreadyTaken, Bailiff, DanteLives, daydream, Domough, Ernesto, flux, Frostian, icser, NodeBreaker, Parrish, Service, shanish2, Sokomine, Squawk ``` Teleport command: ``` /teleport xyz 1298 61 580 ``` Compass command: ``` /give_compass Construction 37yuk1kK9OJKHvf1L5wVMLdFfphj6eOp D2691E 1298 61 580 ```

AliasAlreadyTaken was assigned by yourland-report

2022-12-13 05:18:23 +01:00

flux added the

1. kind/enhancement

label 2022-12-13 06:27:49 +01:00

flux commented

2022-12-13 06:28:33 +01:00

i think they should only trigger when you're deep underground or in the nether, but that's up for discussion

flux commented

2023-04-03 02:13:30 +02:00

so apparently the random mob sounds are triggered as ambience_music? but the files aren't in the ambience mod itself? @AliasAlreadyTaken are those stored in a repo somewhere?

so apparently the random mob sounds are triggered as `ambience_music`? but the files *aren't* in the ambience mod itself? @AliasAlreadyTaken are those stored in a repo somewhere?

flux added the

4. step/question

label 2023-04-03 02:13:43 +02:00

AliasAlreadyTaken commented

2023-04-03 12:00:17 +02:00

I didn't change anything on the ambience mod, as far as I know it takes the sounds already present in other mods.

There is no separate repo for ambience sounds, but there is a texturepack repo. We could add non-texture media files there.

https://gitea.your-land.de/your-land/yl_texturepack

Without looking at the code, if I had to guess, I'd bet they are hardcoded. mobs and ambience are both by TenPlus1

I didn't change anything on the ambience mod, as far as I know it takes the sounds already present in other mods. There is no separate repo for ambience sounds, but there is a texturepack repo. We could add non-texture media files there. https://gitea.your-land.de/your-land/yl_texturepack Without looking at the code, if I had to guess, I'd bet they are hardcoded. mobs and ambience are both by TenPlus1

flux commented

2023-04-04 03:04:00 +02:00

Without looking at the code, if I had to guess, I'd bet they are hardcoded. mobs and ambience are both by TenPlus1

i've looked at the code several times, i couldn't find any obvious source of the monster noises, in ambience, in mobs_redo, anywhere. what i do know, is that they aren't played as a server-wide sound - there's individual calls for every connected player. i'm not 100% certain the ambience_music soundspec is actually the culprit, it's just the only thing that showed up in my log.

> Without looking at the code, if I had to guess, I'd bet they are hardcoded. mobs and ambience are both by TenPlus1 i've looked at the code several times, i couldn't find any obvious source of the monster noises, in ambience, in mobs_redo, anywhere. what i *do* know, is that they aren't played as a server-wide sound - there's individual calls for every connected player. i'm not 100% certain the `ambience_music` soundspec is actually the culprit, it's just the only thing that showed up in my log.

flux commented

2024-03-31 01:12:04 +01:00

so, per #6299, i've discovered that the "ambient mob sounds" are not actually coming from ambience, but a bug in the engine triggered most often by mobs_redo (for unknown reasons).

that might be fixed with the 5.8.0 update though.

do we instead want to add mob sounds to ambience ourselves?

so, per #6299, i've discovered that the "ambient mob sounds" are not actually coming from ambience, but a bug in the engine triggered most often by mobs_redo (for unknown reasons). that might be fixed with the 5.8.0 update though. do we instead want to *add* mob sounds to ambience ourselves?

flux added this to the minetest 5.8.0 milestone 2024-03-31 01:13:20 +01:00

AliasAlreadyTaken commented

2025-03-08 18:38:48 +01:00

Now that we are way beyond 5.8.0, I think this is no longer blocked by 5.8.0 and should be treated as a normal issue. That's why I remove it from 5.8.0 milestone

AliasAlreadyTaken removed this from the minetest 5.8.0 milestone 2025-03-08 18:38:58 +01:00

AliasAlreadyTaken commented

2025-03-08 18:39:49 +01:00

Regarding the question: No, the sounds are not in the repo as far as I can tell. They are taken from elsewhere, from the originating mods.

AliasAlreadyTaken removed the

4. step/question

label 2025-03-08 18:39:55 +01:00

whosit commented

2025-03-09 09:19:58 +01:00

It was pretty funny when whole server would hear some scary mob sound and freak out...

But I think the mob sounds are an important gameplay clue: you heard a scary mob? - Run away. etc.
Or, imagine you want to tame a kitty. You arrive in the dense Kitty Jungle and start searching for it. You hear a kitty, you run towards the sound - there's nothing. You hear another - nothing again.

People should hear mob sounds only when there are actual mobs around. Using sounds of things that are not in the game, but are expected in the environment is fine - we don't have cricket mobs, but we can have cricket sounds, etc.

The correct way to provide "environment mob sounds" is to spawn actual mobs in correct environments and let them make sounds.

It was pretty funny when whole server would hear some scary mob sound and freak out... But I think the mob sounds are an important gameplay clue: you heard a scary mob? - Run away. etc. Or, imagine you want to tame a kitty. You arrive in the dense Kitty Jungle and start searching for it. You hear a kitty, you run towards the sound - there's nothing. You hear another - nothing again. People should hear mob sounds only when there are actual mobs around. Using sounds of things that are _not_ in the game, but are expected in the environment is fine - we don't have cricket mobs, but we can have cricket sounds, etc. The correct way to provide "environment mob sounds" is to spawn actual mobs in correct environments and let them make sounds.

👍 1

Sign in to join this conversation.