your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

AliasAlreadyTaken reports: If a jailed person logs out, t ... #3048

New Issue
Closed
opened 2022-11-15 19:55:39 +00:00 by yourland-report · 12 comments
yourland-report commented 2022-11-15 19:55:39 +00:00
Member
Copy Link

AliasAlreadyTaken reports a bug:

If a jailed person logs out, they are not moved into the jail chat after they log in again

Player position:

{
	y = 54.5,
	z = -3032.0080566406,
	x = -1020.2080078125
}

Player look:

{
	y = -0.48923021554947,
	z = -0.60977935791016,
	x = -0.62355661392212
}

Player information:

{
	formspec_version = 6,
	lang_code = "",
	min_rtt = 0.017000000923872,
	avg_rtt = 0.018999999389052,
	protocol_version = 41,
	max_jitter = 3.3940000534058,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 58581,
	serialization_version = 29,
	patch = 0,
	max_rtt = 3.4179999828339,
	major = 5,
	minor = 7,
	state = "Active",
	version_string = "5.7.0-dev-1a045da0d",
	min_jitter = 0,
	ip_version = 6
}

Player meta:

{
	fields = {
		hud_state = "on",
		repellant = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["signslib:pos"] = "(2041,17,1149)",
		["arena_lib_editor.players_number"] = "0",
		["arena_lib_editor.spawner_ID"] = "0",
		partychat = "party",
		xp_redo_hud_color = "0xFFFF00",
		arenalib_infobox_arenaID = "0",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		lagometer = "1",
		punch_count = "62049",
		["ocean_build.last_warning"] = "1.659e+09",
		inflicted_damage = "2533854",
		["ocean_build.ocean_built"] = "10",
		yl_commons_player_joined = "1668483566",
		team = "STAFF",
		yl_commons_thankyou = "633",
		["arena_lib_editor.team_ID"] = "0",
		died = "1582",
		crafted = "4409",
		xp = "0",
		["stamina:level"] = "0",
		placed_nodes = "177293",
		["stamina:poisoned"] = "no",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = -16080, [\"y\"] = -9915, [\"z\"] = -15812}, [\"last_death_portal\"] = 1663123370, [\"last_heal\"] = 1622459682}",
		["stamina:exhaustion"] = "94.5",
		played_time = "65884048",
		bitten = "0",
		digged_nodes = "135835",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		yl_audio_state = "off",
		["ethereal:fly_timer"] = "-99",
		szutil_watch = "return {}"
	}
}

Log identifier


[MOD] yl_report log identifier = iqTdZdOXbG5BTGGPQPmgW24rTuoc7zpf

Profiler save:

profile-20221115T195539.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 18h 52min 3s | max lag: 3.21s | clients (29/42): AliasAlreadyTaken, Antrica, Apocralypse, Bailiff, BibaBoba, Boot, Crystal1976, ecki, Elise_, ffelder, flux, Frisded, gogo77, jackofthebean000, JeCel, leon1, mad-dog86, Miri, Murmel, Parrish, Queenfire234312, rabenkind, Service, shanish, sherkhan30452, Tim_32, TobiasGaming, Tute, Unelias

Teleport command:

/teleport xyz -1020 55 -3032

Compass command:

/give_compass Construction iqTdZdOXbG5BTGGPQPmgW24rTuoc7zpf D2691E -1020 55 -3032
AliasAlreadyTaken reports a bug: > If a jailed person logs out, they are not moved into the jail chat after they log in again Player position: ``` { y = 54.5, z = -3032.0080566406, x = -1020.2080078125 } ``` Player look: ``` { y = -0.48923021554947, z = -0.60977935791016, x = -0.62355661392212 } ``` Player information: ``` { formspec_version = 6, lang_code = "", min_rtt = 0.017000000923872, avg_rtt = 0.018999999389052, protocol_version = 41, max_jitter = 3.3940000534058, avg_jitter = 0.0010000001639128, connection_uptime = 58581, serialization_version = 29, patch = 0, max_rtt = 3.4179999828339, major = 5, minor = 7, state = "Active", version_string = "5.7.0-dev-1a045da0d", min_jitter = 0, ip_version = 6 } ``` Player meta: ``` { fields = { hud_state = "on", repellant = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["signslib:pos"] = "(2041,17,1149)", ["arena_lib_editor.players_number"] = "0", ["arena_lib_editor.spawner_ID"] = "0", partychat = "party", xp_redo_hud_color = "0xFFFF00", arenalib_infobox_arenaID = "0", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", lagometer = "1", punch_count = "62049", ["ocean_build.last_warning"] = "1.659e+09", inflicted_damage = "2533854", ["ocean_build.ocean_built"] = "10", yl_commons_player_joined = "1668483566", team = "STAFF", yl_commons_thankyou = "633", ["arena_lib_editor.team_ID"] = "0", died = "1582", crafted = "4409", xp = "0", ["stamina:level"] = "0", placed_nodes = "177293", ["stamina:poisoned"] = "no", yl_church = "return {[\"last_death\"] = {[\"x\"] = -16080, [\"y\"] = -9915, [\"z\"] = -15812}, [\"last_death_portal\"] = 1663123370, [\"last_heal\"] = 1622459682}", ["stamina:exhaustion"] = "94.5", played_time = "65884048", bitten = "0", digged_nodes = "135835", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", yl_audio_state = "off", ["ethereal:fly_timer"] = "-99", szutil_watch = "return {}" } } ``` Log identifier ``` [MOD] yl_report log identifier = iqTdZdOXbG5BTGGPQPmgW24rTuoc7zpf ``` Profiler save: ``` profile-20221115T195539.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 18h 52min 3s | max lag: 3.21s | clients (29/42): AliasAlreadyTaken, Antrica, Apocralypse, Bailiff, BibaBoba, Boot, Crystal1976, ecki, Elise_, ffelder, flux, Frisded, gogo77, jackofthebean000, JeCel, leon1, mad-dog86, Miri, Murmel, Parrish, Queenfire234312, rabenkind, Service, shanish, sherkhan30452, Tim_32, TobiasGaming, Tute, Unelias ``` Teleport command: ``` /teleport xyz -1020 55 -3032 ``` Compass command: ``` /give_compass Construction iqTdZdOXbG5BTGGPQPmgW24rTuoc7zpf D2691E -1020 55 -3032 ```
AliasAlreadyTaken was assigned by yourland-report 2022-11-15 19:55:39 +00:00
AliasAlreadyTaken added the
1. kind/bug
 label 2022-11-15 20:32:57 +00:00
flux added the
4. step/ready to QA test
 label 2022-11-15 20:51:24 +00:00
flux commented 2022-11-15 20:51:35 +00:00
Member
Copy Link

fixed in 1ed10bc9dc

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/1ed10bc9dcb444d69fa56cc9fdbd888898d63c03
AliasAlreadyTaken added this to the 1.1.117 milestone 2022-11-16 03:43:39 +00:00
AliasAlreadyTaken commented 2023-01-18 10:03:56 +00:00
Owner
Copy Link

Upon login:

2023-01-18 10:03:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_joinplayer(): ...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:49: bad argument #1 to 'get_player_privs' (string expected, got userdata)
2023-01-18 10:03:25: ERROR[Main]: stack traceback:
2023-01-18 10:03:25: ERROR[Main]: 	[C]: in function 'get_player_privs'
2023-01-18 10:03:25: ERROR[Main]: 	...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:49: in function 'jail'
2023-01-18 10:03:25: ERROR[Main]: 	...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:173: in function 'func'
2023-01-18 10:03:25: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100>
2023-01-18 10:03:25: ERROR[Main]: 	.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:431:
Upon login: ``` 2023-01-18 10:03:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_joinplayer(): ...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:49: bad argument #1 to 'get_player_privs' (string expected, got userdata) 2023-01-18 10:03:25: ERROR[Main]: stack traceback: 2023-01-18 10:03:25: ERROR[Main]: [C]: in function 'get_player_privs' 2023-01-18 10:03:25: ERROR[Main]: ...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:49: in function 'jail' 2023-01-18 10:03:25: ERROR[Main]: ...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:173: in function 'func' 2023-01-18 10:03:25: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100> 2023-01-18 10:03:25: ERROR[Main]: .../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:431: ```
AliasAlreadyTaken commented 2023-01-18 10:11:15 +00:00
Owner
Copy Link

playername instead of playerobject problem ;)

Fixed in 839945c653

playername instead of playerobject problem ;) Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/839945c6535cb5e9231c3bb407727b66ee479fb0
AliasAlreadyTaken added the
ugh/QA OK
 label 2023-01-18 10:11:31 +00:00
AliasAlreadyTaken added
ugh/QA NOK
 and removed
ugh/QA OK
 labels 2023-01-18 13:22:26 +00:00
AliasAlreadyTaken commented 2023-01-18 13:23:24 +00:00
Owner
Copy Link

Still not fully fixed. Now if a jailed person logs out and then logs in again, they are sent into the jail channel: OK

But now when they are unjailed, they do not get their privs back. They stay invincible and jailed

Still not fully fixed. Now if a jailed person logs out and then logs in again, they are sent into the jail channel: OK But now when they are unjailed, they do not get their privs back. They stay invincible and jailed
flux commented 2023-01-19 01:09:30 +00:00
Member
Copy Link

Still not fully fixed. Now if a jailed person logs out and then logs in again, they are sent into the jail channel: OK

But now when they are unjailed, they do not get their privs back. They stay invincible and jailed

there were a couple checks that were missing. i've reworked it a bit and tested that privs are kept.

i do think "jailed" shouldn't be a "privilege", it's basically the opposite of one :) but that's another topic.

> Still not fully fixed. Now if a jailed person logs out and then logs in again, they are sent into the jail channel: OK > > But now when they are unjailed, they do not get their privs back. They stay invincible and jailed there were a couple checks that were missing. i've reworked it a bit and tested that privs are kept. i do think "jailed" shouldn't be a "privilege", it's basically the opposite of one :) but that's another topic.
AliasAlreadyTaken commented 2023-01-19 04:33:48 +00:00
Owner
Copy Link

i do think "jailed" shouldn't be a "privilege"

Unfortunately true. /grantme all -> boom, jailed.

From a datastructure point of view, where should such a metadatum reside? Clearly with playermeta.

Unfortunately playermeta cannot be accessed from the outside or when a player is not logged in.

What CAN be accessed while a player is not logged in? mod storage or some file of our own.

We must not store any playernames in modstorage, the way it is layed out makes it pretty heavy and unsuitable to access a player-metadatum in there. Worst example. party mod, it stores ALL playernames in modstorage.

We cannot outsource a lot of metadata as privs, this will soon get pretty cluttered, especially when we want to store more than a boolean decision (is jailed/ is not jailed)

That leaves us with some file of our own, read yl_settings. Until then, we'll need to abuse the privs.

The "correct" solution to this problem would be to make the core devs allow access to playermeta from the outside, like privs are. yl_settings is only a means to go around the shortcomings of the engine at this point.

> i do think "jailed" shouldn't be a "privilege" Unfortunately true. /grantme all -> boom, jailed. From a datastructure point of view, where should such a metadatum reside? Clearly with playermeta. Unfortunately playermeta cannot be accessed from the outside or when a player is not logged in. What CAN be accessed while a player is not logged in? mod storage or some file of our own. We must not store any playernames in modstorage, the way it is layed out makes it pretty heavy and unsuitable to access a player-metadatum in there. Worst example. party mod, it stores ALL playernames in modstorage. We cannot outsource a lot of metadata as privs, this will soon get pretty cluttered, especially when we want to store more than a boolean decision (is jailed/ is not jailed) That leaves us with some file of our own, read yl_settings. Until then, we'll need to abuse the privs. The "correct" solution to this problem would be to make the core devs allow access to playermeta from the outside, like privs are. yl_settings is only a means to go around the shortcomings of the engine at this point.
flux commented 2023-01-19 04:40:56 +00:00
Member
Copy Link

Unfortunately true. /grantme all -> boom, jailed.

i tried to write some code that prevented staff from granting themselves the "jailed" priv, but it resulted in a stack overflow no matter what i did, and i'm not sure why, but making it not a "privilege" is probably the better solution.

The "correct" solution to this problem would be to make the core devs allow access to playermeta from the outside, like privs are. yl_settings is only a means to go around the shortcomings of the engine at this point.

yeah, minetest.get_player_meta(player_or_name) should be a thing. is there an issue about that?

> Unfortunately true. /grantme all -> boom, jailed. i tried to write some code that prevented staff from granting themselves the "jailed" priv, but it resulted in a stack overflow no matter what i did, and i'm not sure why, but making it not a "privilege" is probably the better solution. > The "correct" solution to this problem would be to make the core devs allow access to playermeta from the outside, like privs are. yl_settings is only a means to go around the shortcomings of the engine at this point. yeah, `minetest.get_player_meta(player_or_name)` should be a thing. is there an issue about that?
AliasAlreadyTaken commented 2023-01-19 06:04:53 +00:00
Owner
Copy Link

https://github.com/minetest/minetest/pull/9164

and

https://github.com/minetest/minetest/pull/9177

and

https://github.com/minetest/minetest/pull/4155

https://github.com/minetest/minetest/pull/9164 and https://github.com/minetest/minetest/pull/9177 and https://github.com/minetest/minetest/pull/4155
AliasAlreadyTaken commented 2023-01-19 06:26:51 +00:00
Owner
Copy Link

When a jailed player leaves the server:

2023-01-19 06:24:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_joinplayer(): .../5.6.1/Minetest_test/bin/../mods/smart_chat/cmd_move.lua:39: bad argument #1 to 'get_player_by_name' (string expected, got userdata)
2023-01-19 06:24:25: ERROR[Main]: stack traceback:
2023-01-19 06:24:25: ERROR[Main]: 	[C]: in function 'get_player_by_name'
2023-01-19 06:24:25: ERROR[Main]: 	.../5.6.1/Minetest_test/bin/../mods/smart_chat/cmd_move.lua:39: in function <.../5.6.1/Minetest_test/bin/../mods/smart_chat/cmd_move.lua:18>
2023-01-19 06:24:25: ERROR[Main]: 	/home/mt/5.6.1/Minetest_test/bin/../mods/smart_chat/lib.lua:33: in function 'check'
2023-01-19 06:24:25: ERROR[Main]: 	...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:185: in function 'func'
2023-01-19 06:24:25: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100>
2023-01-19 06:24:25: ERROR[Main]: 	.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:417>

Btw, should we post followup issues like this in a new issue?

When a jailed player leaves the server: ``` 2023-01-19 06:24:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_joinplayer(): .../5.6.1/Minetest_test/bin/../mods/smart_chat/cmd_move.lua:39: bad argument #1 to 'get_player_by_name' (string expected, got userdata) 2023-01-19 06:24:25: ERROR[Main]: stack traceback: 2023-01-19 06:24:25: ERROR[Main]: [C]: in function 'get_player_by_name' 2023-01-19 06:24:25: ERROR[Main]: .../5.6.1/Minetest_test/bin/../mods/smart_chat/cmd_move.lua:39: in function <.../5.6.1/Minetest_test/bin/../mods/smart_chat/cmd_move.lua:18> 2023-01-19 06:24:25: ERROR[Main]: /home/mt/5.6.1/Minetest_test/bin/../mods/smart_chat/lib.lua:33: in function 'check' 2023-01-19 06:24:25: ERROR[Main]: ...netest_test/bin/../mods/yl_commons/chatcommands/jail.lua:185: in function 'func' 2023-01-19 06:24:25: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100> 2023-01-19 06:24:25: ERROR[Main]: .../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:417> ``` Btw, should we post followup issues like this in a new issue?
flux commented 2023-01-19 17:22:27 +00:00
Member
Copy Link

Btw, should we post followup issues like this in a new issue?

this is due to a botched fix, so it should stay here. i never encountered this because there's no "Service" account on my test server w/ the right privilege, so smart_chat gave up earlier.

fixed it again: 2421c3a8c0

> Btw, should we post followup issues like this in a new issue? this is due to a botched fix, so it should stay here. i never encountered this because there's no "Service" account on my test server w/ the right privilege, so smart_chat gave up earlier. fixed it again: https://gitea.your-land.de/your-land/yl_commons/commit/2421c3a8c0ba03bea5ab6da31c07d935f8c094e2
AliasAlreadyTaken commented 2023-01-19 22:47:31 +00:00
Owner
Copy Link

This works as expected now :)

Cooool!

This works as expected now :) Cooool!
AliasAlreadyTaken added
ugh/QA OK
 and removed
ugh/QA NOK
 labels 2023-01-19 22:47:42 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-01-25 18:58:08 +00:00
AliasAlreadyTaken was unassigned by flux 2023-01-25 18:58:10 +00:00
flux commented 2023-01-25 18:58:19 +00:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-01-25 18:58:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.117
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3048
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?