AliasAlreadyTaken reports: No log message when a player d ... #2995

New Issue

yourland-report · 2022-11-10T10:42:30Z

yourland-report commented

2022-11-10 10:42:30 +00:00

AliasAlreadyTaken reports a bug:

No log message when a player digs bones as a whole. Expected: Log message on every transaction

Player position:

{
	x = 2142,
	y = 15,
	z = 1301
}

Player look:

{
	x = 0.98597639799118,
	y = -0.16194827854633,
	z = 0.040290467441082
}

Player information:

{
	protocol_version = 41,
	major = 5,
	minor = 7,
	version_string = "5.7.0-dev-88b04eadc",
	state = "Active",
	lang_code = "",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.017000000923872,
	max_rtt = 0.34200000762939,
	avg_rtt = 0.01799999922514,
	min_jitter = 0,
	max_jitter = 0.32100000977516,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 2172,
	serialization_version = 29,
	patch = 0
}

Player meta:

{
	fields = {
		repellant = "0",
		["ocean_build.last_warning"] = "1.659e+09",
		["signslib:pos"] = "(2041,17,1149)",
		played_time = "65462319",
		digged_nodes = "135751",
		placed_nodes = "177138",
		died = "1582",
		inflicted_damage = "2533364",
		arenalib_infobox_arenaID = "0",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		yl_audio_state = "off",
		["ethereal:fly_timer"] = "-99",
		szutil_watch = "return {}",
		yl_commons_thankyou = "613",
		partychat = "party",
		["arena_lib_editor.players_number"] = "0",
		["arena_lib_editor.spawner_ID"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		xp = "0",
		team = "STAFF",
		lagometer = "1",
		punch_count = "62020",
		crafted = "4408",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = -16080, [\"y\"] = -9915, [\"z\"] = -15812}, [\"last_death_portal\"] = 1663123370, [\"last_heal\"] = 1622459682}",
		hud_state = "on",
		xp_redo_hud_color = "0xFFFF00",
		bitten = "0",
		yl_commons_player_joined = "1668074785",
		["stamina:level"] = "0",
		["arena_lib_editor.team_ID"] = "0",
		["stamina:poisoned"] = "no",
		["ocean_build.ocean_built"] = "10",
		["stamina:exhaustion"] = "78"
	}
}

Log identifier


[MOD] yl_report log identifier = iWs97BGYUymBNYR1KwMUkozvaWURHpvc

Profiler save:

profile-20221110T104230.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 10h 20min 23s | max lag: 1.77s | clients: JeCel, Road, ricky, Aliza, ecki, Violetta, Boris, AliasAlreadyTaken, Service, Laylem, 9T9, sherkhan30452, NodeBreaker, daydream, Bailiff

Teleport command:

/teleport xyz 2142 15 1301

Compass command:

/give_compass Construction iWs97BGYUymBNYR1KwMUkozvaWURHpvc D2691E 2142 15 1301

AliasAlreadyTaken reports a bug: > No log message when a player digs bones as a whole. Expected: Log message on every transaction Player position: ``` { x = 2142, y = 15, z = 1301 } ``` Player look: ``` { x = 0.98597639799118, y = -0.16194827854633, z = 0.040290467441082 } ``` Player information: ``` { protocol_version = 41, major = 5, minor = 7, version_string = "5.7.0-dev-88b04eadc", state = "Active", lang_code = "", formspec_version = 6, ip_version = 6, min_rtt = 0.017000000923872, max_rtt = 0.34200000762939, avg_rtt = 0.01799999922514, min_jitter = 0, max_jitter = 0.32100000977516, avg_jitter = 0.0010000001639128, connection_uptime = 2172, serialization_version = 29, patch = 0 } ``` Player meta: ``` { fields = { repellant = "0", ["ocean_build.last_warning"] = "1.659e+09", ["signslib:pos"] = "(2041,17,1149)", played_time = "65462319", digged_nodes = "135751", placed_nodes = "177138", died = "1582", inflicted_damage = "2533364", arenalib_infobox_arenaID = "0", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", yl_audio_state = "off", ["ethereal:fly_timer"] = "-99", szutil_watch = "return {}", yl_commons_thankyou = "613", partychat = "party", ["arena_lib_editor.players_number"] = "0", ["arena_lib_editor.spawner_ID"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", xp = "0", team = "STAFF", lagometer = "1", punch_count = "62020", crafted = "4408", yl_church = "return {[\"last_death\"] = {[\"x\"] = -16080, [\"y\"] = -9915, [\"z\"] = -15812}, [\"last_death_portal\"] = 1663123370, [\"last_heal\"] = 1622459682}", hud_state = "on", xp_redo_hud_color = "0xFFFF00", bitten = "0", yl_commons_player_joined = "1668074785", ["stamina:level"] = "0", ["arena_lib_editor.team_ID"] = "0", ["stamina:poisoned"] = "no", ["ocean_build.ocean_built"] = "10", ["stamina:exhaustion"] = "78" } } ``` Log identifier ``` [MOD] yl_report log identifier = iWs97BGYUymBNYR1KwMUkozvaWURHpvc ``` Profiler save: ``` profile-20221110T104230.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 10d 10h 20min 23s | max lag: 1.77s | clients: JeCel, Road, ricky, Aliza, ecki, Violetta, Boris, AliasAlreadyTaken, Service, Laylem, 9T9, sherkhan30452, NodeBreaker, daydream, Bailiff ``` Teleport command: ``` /teleport xyz 2142 15 1301 ``` Compass command: ``` /give_compass Construction iWs97BGYUymBNYR1KwMUkozvaWURHpvc D2691E 2142 15 1301 ```

AliasAlreadyTaken was assigned by yourland-report

2022-11-10 10:42:30 +00:00

flux added the

1. kind/enhancement

2. prio/elevated

labels 2022-11-10 15:24:06 +00:00

flux added this to the flux's TODO list project 2022-11-10 15:24:08 +00:00

flux self-assigned this 2022-11-10 15:24:15 +00:00

flux commented

2022-11-10 15:57:34 +00:00

this should be logged:

750761c11f/node.lua (L88-L92)

i'll do some testing locally.

this should be logged: https://gitea.your-land.de/your-land/bones/src/commit/750761c11f77bd72618b0e12fdb85ca2518ab94c/node.lua#L88-L92 i'll do some testing locally.

flux commented

2022-11-10 16:07:38 +00:00

i'll do some testing locally.

well, that code isn't doing what it's supposed to do. now to fix it...

> i'll do some testing locally. well, that code isn't doing what it's supposed to do. now to fix it...

flux commented

2022-11-10 18:17:43 +00:00

fixed in 7eef936a0f, and added more detail to log messages in general.

also fixed a crash that i'm unsure how we've avoided.

fixed in https://github.com/fluxionary/minetest-bones_redo/commit/7eef936a0ff0e8fd42469f106e2b261a26c981c3, and added more detail to log messages in general. also fixed a crash that i'm unsure how we've avoided.

👍 1

flux added the

4. step/ready to QA test

label 2022-11-10 18:17:59 +00:00

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-11 00:12:54 +00:00

flux commented

2022-11-16 18:04:31 +00:00

@AliasAlreadyTaken i can't verify this, please check and close this at your convenience :)

AliasAlreadyTaken commented

2022-11-23 10:46:08 +00:00

For some reason it's not, I can see neither the dig action nor the inventory action in the log.

AliasAlreadyTaken removed this from the 1.1.116 milestone 2022-11-23 10:46:16 +00:00

flux commented

2022-11-24 03:38:59 +00:00

For some reason it's not, I can see neither the dig action nor the inventory action in the log.

probably the bones mod needs updated

> For some reason it's not, I can see neither the dig action nor the inventory action in the log. probably the bones mod needs updated

AliasAlreadyTaken commented

2022-11-24 16:11:25 +00:00

We're on 750761c11f77bd72618b0e12fdb85ca2518ab94c : don't crash

This commit is from Date: Sun Jul 17 08:26:05 2022 -0700

https://gitea.your-land.de/your-land/bones.git

Since it was fixed way after that date, I assume the source is wrong, the branch is wrong or - most likely - the fix didn't get pushed :D

We're on 750761c11f77bd72618b0e12fdb85ca2518ab94c : don't crash This commit is from Date: Sun Jul 17 08:26:05 2022 -0700 https://gitea.your-land.de/your-land/bones.git Since it was fixed way after that date, I assume the source is wrong, the branch is wrong or - most likely - the fix didn't get pushed :D

flux commented

2022-11-24 16:17:07 +00:00

ah, i can resync w/ the "upstream"