rheo reports: /msg should send email to play ... #2968

New Issue

yourland-report · 2022-11-06T04:28:31Z

yourland-report commented

2022-11-06 04:28:31 +00:00

rheo reports a bug:

/msg should send email to players who've timed out; if the player disconnects before 60 seconds after the message was sent, they should get an email

Player position:

{
	x = 1964.8570556641,
	y = 29517.5,
	z = 1579.0319824219
}

Player look:

{
	x = 0.69587421417236,
	y = -0.2768115401268,
	z = 0.66267216205597
}

Player information:

{
	protocol_version = 41,
	major = 5,
	minor = 6,
	version_string = "5.6.1",
	state = "Active",
	lang_code = "",
	ip_version = 6,
	min_rtt = 0.15700000524521,
	max_rtt = 4.6500000953674,
	avg_rtt = 0.27000001072884,
	min_jitter = 0,
	max_jitter = 4.4790000915527,
	avg_jitter = 0.10200001299381,
	connection_uptime = 982,
	serialization_version = 29,
	patch = 1,
	formspec_version = 6
}

Player meta:

{
	fields = {
		repellant = "0",
		["ocean_build.last_warning"] = "1.6588e+09",
		["signslib:pos"] = "(6050,-4,680)",
		played_time = "2399141",
		xp = "0",
		punch_count = "932",
		died = "2",
		crafted = "572",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}",
		placed_nodes = "14574",
		yl_commons_thankyou = "27",
		["ethereal:fly_timer"] = "-99",
		bitten = "0",
		["stamina:exhaustion"] = "41",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		hud_state = "off",
		["ocean_build.ocean_built"] = "2",
		jointime = "1644205752",
		yl_commons_player_created = "1644205752",
		yl_commons_player_joined = "1667707980",
		["stamina:level"] = "0",
		digged_nodes = "8762",
		["stamina:poisoned"] = "no",
		inflicted_damage = "148098",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 55200\", \"\", \"\", \"\", \"\", \"\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = kfNHbakMJvCe6ok3WkaOiJca5bYaObFQ

Profiler save:

profile-20221106T042831.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 6d 4h 24min 25s | max lag: 2.09s | clients: Hamster64, the_chosen_one, dragon014, rheo, hava, flux, Laylem, nitekin, icser, set, shanish3, jackofthebean000, Service, Bailiff, Parrish, AliasAlreadyTaken, shanish, daydream

Teleport command:

/teleport xyz 1965 29518 1579

Compass command:

/give_compass Construction kfNHbakMJvCe6ok3WkaOiJca5bYaObFQ D2691E 1965 29518 1579

rheo reports a bug: > /msg should send email to players who've timed out; if the player disconnects before 60 seconds after the message was sent, they should get an email Player position: ``` { x = 1964.8570556641, y = 29517.5, z = 1579.0319824219 } ``` Player look: ``` { x = 0.69587421417236, y = -0.2768115401268, z = 0.66267216205597 } ``` Player information: ``` { protocol_version = 41, major = 5, minor = 6, version_string = "5.6.1", state = "Active", lang_code = "", ip_version = 6, min_rtt = 0.15700000524521, max_rtt = 4.6500000953674, avg_rtt = 0.27000001072884, min_jitter = 0, max_jitter = 4.4790000915527, avg_jitter = 0.10200001299381, connection_uptime = 982, serialization_version = 29, patch = 1, formspec_version = 6 } ``` Player meta: ``` { fields = { repellant = "0", ["ocean_build.last_warning"] = "1.6588e+09", ["signslib:pos"] = "(6050,-4,680)", played_time = "2399141", xp = "0", punch_count = "932", died = "2", crafted = "572", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}", placed_nodes = "14574", yl_commons_thankyou = "27", ["ethereal:fly_timer"] = "-99", bitten = "0", ["stamina:exhaustion"] = "41", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", hud_state = "off", ["ocean_build.ocean_built"] = "2", jointime = "1644205752", yl_commons_player_created = "1644205752", yl_commons_player_joined = "1667707980", ["stamina:level"] = "0", digged_nodes = "8762", ["stamina:poisoned"] = "no", inflicted_damage = "148098", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 55200\", \"\", \"\", \"\", \"\", \"\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = kfNHbakMJvCe6ok3WkaOiJca5bYaObFQ ``` Profiler save: ``` profile-20221106T042831.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 6d 4h 24min 25s | max lag: 2.09s | clients: Hamster64, the_chosen_one, dragon014, rheo, hava, flux, Laylem, nitekin, icser, set, shanish3, jackofthebean000, Service, Bailiff, Parrish, AliasAlreadyTaken, shanish, daydream ``` Teleport command: ``` /teleport xyz 1965 29518 1579 ``` Compass command: ``` /give_compass Construction kfNHbakMJvCe6ok3WkaOiJca5bYaObFQ D2691E 1965 29518 1579 ```

AliasAlreadyTaken was assigned by yourland-report

2022-11-06 04:28:31 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-11-06 12:55:12 +00:00

flux commented

2022-11-06 15:21:58 +00:00

how this would work:

log 61 seconds (timeout length seems hard-coded) of DMs for each player. register an on_leaveplayer callback. if a player leaves due to timeout, send them an email composed of all the messages in the queue.

how this would work: log 61 seconds (timeout length seems hard-coded) of DMs for each player. register an [on_leaveplayer](https://github.com/minetest/minetest/blob/322c8cf270a6fe2cd6ac152af0f3f5d2963fa0b3/doc/lua_api.txt#L5220-L5222) callback. if a player leaves due to timeout, send them an email composed of all the messages in the queue.

AliasAlreadyTaken added the

2. prio/low

label 2022-11-11 15:54:37 +00:00

AliasAlreadyTaken commented

2022-11-11 15:55:13 +00:00

If there's an easy solution, why not.

flux commented

2022-11-12 04:52:10 +00:00

this was simple until i started to consider how things like how it would interact w/ logic like the /ignore command. it can be done, but it might require a complete re-evaluation of how chat works.

this was simple until i started to consider how things like how it would interact w/ logic like the `/ignore` command. it can be done, but it might require a complete re-evaluation of how chat works.

flux added the

4. step/ready to QA test

label 2022-11-12 20:46:36 +00:00

flux commented

2022-11-12 20:47:54 +00:00

implemented in 53a4b9dcec

currently, this bypasses /ignore, but it's a weird edge case. that can be revisted when "better chat" is implemented and all the chat stuff can go into one place.

implemented in https://gitea.your-land.de/your-land/yl_chat/commit/53a4b9dceca32b7459d01d2b3fd8ce5066a63454 currently, this bypasses `/ignore`, but it's a weird edge case. that can be revisted when "better chat" is implemented and all the chat stuff can go into one place.

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-12 21:00:37 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2022-11-16 17:10:16 +00:00

AliasAlreadyTaken was unassigned by flux

2022-11-16 17:10:21 +00:00

flux commented

2022-11-16 17:10:29 +00:00

this is live

flux closed this issue