daydream reports: I was repairing my sword becau ... #2931

New Issue

yourland-report · 2022-10-29T20:44:44Z

yourland-report commented

2022-10-29 20:44:44 +00:00

daydream reports a bug:

I was repairing my sword because it was under 50% and it just disappeared into thin air from the anvil

Player position:

{
	y = 28970.390625,
	z = 21489.3984375,
	x = 349.86599731445
}

Player look:

{
	y = -0.32061299681664,
	z = 0.63171619176865,
	x = -0.70579165220261
}

Player information:

{
	lang_code = "",
	state = "Active",
	version_string = "5.6.1",
	avg_rtt = 0.17800000309944,
	ip_version = 6,
	min_rtt = 0.16400000452995,
	max_rtt = 1.8339999914169,
	major = 5,
	minor = 6,
	max_jitter = 1.6610000133514,
	avg_jitter = 0,
	connection_uptime = 24861,
	serialization_version = 29,
	patch = 1,
	formspec_version = 6,
	min_jitter = 0,
	protocol_version = 41
}

Player meta:

{
	fields = {
		died = "115",
		placed_nodes = "149407",
		["petz:werewolf"] = "0",
		played_time = "7941726",
		partychat = "party",
		yl_church = "return {[\"last_death_portal\"] = 1667075191, [\"last_death\"] = {[\"y\"] = 28970, [\"z\"] = 21463, [\"x\"] = 275}}",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		jointime = "1650064821",
		bitten = "0",
		["petz:werewolf_vignette_id"] = "5",
		xp = "911626",
		["petz:lycanthropy"] = "0",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1667051451",
		xp_redo_hud_color = "0xFFC001",
		arenalib_infobox_arenaID = "0",
		punch_count = "36674",
		["stamina:level"] = "17",
		inflicted_damage = "722384",
		["stamina:poisoned"] = "no",
		crafted = "1671",
		repellant = "0",
		digged_nodes = "1044374",
		["stamina:exhaustion"] = "53.5",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		hud_state = "on",
		["petz:werewolf_clan_idx"] = "2",
		["ocean_build.last_warning"] = "1.65235e+09",
		["signslib:pos"] = "(2114,5,1577)",
		["ocean_build.ocean_built"] = "8",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 11500\", \"shields:shield_rainbow 1 4600\", \"3d_armor:chestplate_crystal 1 11500\", \"3d_armor:leggings_crystal 1 11500\", \"3d_armor:boots_crystal 1 11500\", \"\"}",
		yl_commons_thankyou = "113"
	}
}

Log identifier


[MOD] yl_report log identifier = 6CR6TtJnguyxhQhGxo5FpYjVZ46LGfAw

Profiler save:

profile-20221029T204444.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1d 15h 32min 58s | max lag: 3.17s | clients: ruruki, darealbang, waldkauz, Mikimix, Qichta29, Adrian530, alexandre2005, Elise_, FailFactory, MsUnix, Lucien_II, hmm, Parrish, AspireMint, flux, Bailiff, rabenkind, LeetPeet, HorusDamocles, PinkNebulosa, AliasAlreadyTaken, Miloy, daydream

Teleport command:

/teleport xyz 350 28970 21489

Compass command:

/give_compass Construction 6CR6TtJnguyxhQhGxo5FpYjVZ46LGfAw D2691E 350 28970 21489

daydream reports a bug: > I was repairing my sword because it was under 50% and it just disappeared into thin air from the anvil Player position: ``` { y = 28970.390625, z = 21489.3984375, x = 349.86599731445 } ``` Player look: ``` { y = -0.32061299681664, z = 0.63171619176865, x = -0.70579165220261 } ``` Player information: ``` { lang_code = "", state = "Active", version_string = "5.6.1", avg_rtt = 0.17800000309944, ip_version = 6, min_rtt = 0.16400000452995, max_rtt = 1.8339999914169, major = 5, minor = 6, max_jitter = 1.6610000133514, avg_jitter = 0, connection_uptime = 24861, serialization_version = 29, patch = 1, formspec_version = 6, min_jitter = 0, protocol_version = 41 } ``` Player meta: ``` { fields = { died = "115", placed_nodes = "149407", ["petz:werewolf"] = "0", played_time = "7941726", partychat = "party", yl_church = "return {[\"last_death_portal\"] = 1667075191, [\"last_death\"] = {[\"y\"] = 28970, [\"z\"] = 21463, [\"x\"] = 275}}", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", jointime = "1650064821", bitten = "0", ["petz:werewolf_vignette_id"] = "5", xp = "911626", ["petz:lycanthropy"] = "0", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1667051451", xp_redo_hud_color = "0xFFC001", arenalib_infobox_arenaID = "0", punch_count = "36674", ["stamina:level"] = "17", inflicted_damage = "722384", ["stamina:poisoned"] = "no", crafted = "1671", repellant = "0", digged_nodes = "1044374", ["stamina:exhaustion"] = "53.5", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", hud_state = "on", ["petz:werewolf_clan_idx"] = "2", ["ocean_build.last_warning"] = "1.65235e+09", ["signslib:pos"] = "(2114,5,1577)", ["ocean_build.ocean_built"] = "8", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 11500\", \"shields:shield_rainbow 1 4600\", \"3d_armor:chestplate_crystal 1 11500\", \"3d_armor:leggings_crystal 1 11500\", \"3d_armor:boots_crystal 1 11500\", \"\"}", yl_commons_thankyou = "113" } } ``` Log identifier ``` [MOD] yl_report log identifier = 6CR6TtJnguyxhQhGxo5FpYjVZ46LGfAw ``` Profiler save: ``` profile-20221029T204444.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1d 15h 32min 58s | max lag: 3.17s | clients: ruruki, darealbang, waldkauz, Mikimix, Qichta29, Adrian530, alexandre2005, Elise_, FailFactory, MsUnix, Lucien_II, hmm, Parrish, AspireMint, flux, Bailiff, rabenkind, LeetPeet, HorusDamocles, PinkNebulosa, AliasAlreadyTaken, Miloy, daydream ``` Teleport command: ``` /teleport xyz 350 28970 21489 ``` Compass command: ``` /give_compass Construction 6CR6TtJnguyxhQhGxo5FpYjVZ46LGfAw D2691E 350 28970 21489 ```

AliasAlreadyTaken was assigned by yourland-report

2022-10-29 20:44:44 +00:00

flux referenced this issue

2022-10-29 20:59:03 +00:00

daydream reports: my sword was on the anvil next ... #2932

flux commented

2022-10-29 20:59:20 +00:00

from #2932:

my sword was on the anvil next time I returned to sharpen 2nd sword... huh?

from #2932: ``` my sword was on the anvil next time I returned to sharpen 2nd sword... huh? ```

flux commented

2022-10-29 20:59:44 +00:00

anvil items are probably not explosion proof, though that's probably not what happened...

daydream commented

2022-10-29 23:40:02 +00:00

It just disappeared while I was repairing it. I looked everywhere and AspireMind also looked. Then we gave up and went back out (we were in base in lava in nether - so probably that matters) anyway a bit later I came back maybe half an hour - and my sword was just sitting there like nothing happened. Very odd but ended well at least.

flux commented

2022-10-30 00:37:57 +00:00

the image of the sword on the anvil is not related to what the anvil thinks is actually there. it's an entity, like the text on signs, petz, and other such things. when you leave an area and come back, there's a bit of code to check to see whether the entity is still there, and re-creates it if it's not.

so what probably happened is the entity disappeared for some reason, you left, came back, and the entity re-spawned.

the real question, is why did it disappear in the first place. i've recently been fixing an issue where explosions destroy node-bound entities (like the anvil entity, signs, smartshop, itemshelves, etc.), but i'm pretty sure you would have noticed an explosion next to the anvil.

wait, looking @ the coords, you were in the nether at the time? hmmmm.

the image of the sword on the anvil is not related to what the anvil thinks is actually there. it's an entity, like the text on signs, petz, and other such things. when you leave an area and come back, there's a bit of code to check to see whether the entity is still there, and re-creates it if it's not. so what probably happened is the entity disappeared for some reason, you left, came back, and the entity re-spawned. the real question, is why did it disappear in the first place. i've recently been fixing an issue where explosions destroy node-bound entities (like the anvil entity, signs, smartshop, itemshelves, etc.), but i'm pretty sure you would have noticed an explosion next to the anvil. wait, looking @ the coords, you were in the nether at the time? hmmmm.

flux added the

1. kind/bug

3. source/unknown

4. step/question

labels 2022-10-30 01:15:11 +00:00

flux commented

2022-10-30 16:04:08 +00:00

@AliasAlreadyTaken any chance you could grep the logs for lines containing both anvil:item and damage and see if anything shows up?

@AliasAlreadyTaken any chance you could grep the logs for lines containing both `anvil:item` and `damage` and see if anything shows up?

AliasAlreadyTaken commented

2022-11-02 10:39:33 +00:00

Yes, there is! And by mere chance, a certain daydream also punched an anvil in the nether:

2022-10-29 20:43:36: ACTION[Server]: player daydream (id=21784, hp=19) punched LuaEntitySAO "anvil:item" at (350,28971,21488) (id=43427, hp=0), damage=1

There are 30 similar logentries. Only in rare cases players "punched" the entity. In most cases, the entity punched the entity?? Doesn't necessarily need to be the same one though:

2022-10-31 12:28:51: ACTION[Server]: LuaEntitySAO "anvil:item" at (2003,29138,1386) (id=27668, hp=0) punched LuaEntitySAO "anvil:item" at (2003,29138,1386) (id=27668, hp=0), damage=1

Yes, there is! And by mere chance, a certain daydream also punched an anvil in the nether: ``` 2022-10-29 20:43:36: ACTION[Server]: player daydream (id=21784, hp=19) punched LuaEntitySAO "anvil:item" at (350,28971,21488) (id=43427, hp=0), damage=1 ``` There are 30 similar logentries. Only in rare cases players "punched" the entity. In most cases, the entity punched the entity?? Doesn't necessarily need to be the same one though: ``` 2022-10-31 12:28:51: ACTION[Server]: LuaEntitySAO "anvil:item" at (2003,29138,1386) (id=27668, hp=0) punched LuaEntitySAO "anvil:item" at (2003,29138,1386) (id=27668, hp=0), damage=1 ```

flux commented

2022-11-02 16:06:19 +00:00

In most cases, the entity punched the entity??

that's what gets logged when the entity is destroyed by an explosion.

Doesn't necessarily need to be the same one though

the example you provided shows the same entity id for both the "puncher" and "punched" entity (27668). i'm slightly curious if there's actually cases where one item shows as punching another, but it's probably not due to anything actually interesting or relevant.

Only in rare cases players "punched" the entity.

this part is really odd to me. the entity isn't "physical", the player shouldn't be able to interact w/ it directly, but that does appear to be what happened to the entity in this case.

in any event, the solution is easy enough.

> In most cases, the entity punched the entity?? that's what gets logged when the entity is destroyed by an explosion. > Doesn't necessarily need to be the same one though the example you provided shows the same entity id for both the "puncher" and "punched" entity (27668). i'm slightly curious if there's actually cases where one item shows as punching another, but it's probably not due to anything actually interesting or relevant. > Only in rare cases players "punched" the entity. this part is really odd to me. the entity isn't "physical", the player shouldn't be able to interact w/ it directly, but that does appear to be what happened to the entity in this case. in any event, the solution is easy enough.

flux removed the

4. step/question

label 2022-11-02 16:06:37 +00:00

flux commented

2022-11-02 17:57:47 +00:00

prevent damage in 40d84183a4

prevent damage in https://gitea.your-land.de/your-land/anvil/commit/40d84183a4ddd0c920b206dd888bfd9937bff82a

flux added the

4. step/ready to QA test

label 2022-11-02 17:58:00 +00:00

flux added this to the flux's TODO list project 2022-11-02 17:58:14 +00:00

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-02 21:34:34 +00:00

flux removed this from the flux's TODO list project 2022-11-16 16:43:36 +00:00

AliasAlreadyTaken was unassigned by flux

2022-11-16 16:43:39 +00:00

flux removed the

1. kind/bug

3. source/unknown

4. step/ready to QA test

labels 2022-11-16 16:43:43 +00:00

flux commented

2022-11-16 16:43:51 +00:00

this is live

flux closed this issue

2022-11-16 16:43:52 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2022-11-23 11:04:10 +00:00

AliasAlreadyTaken commented

2022-11-23 11:05:02 +00:00

Why were all labels removed? This was certainly a bug and it is now fixed, right?

I assume others might be interested as well, the anvil is one of the more famous mods.

Why were all labels removed? This was certainly a bug and it is now fixed, right? I assume others might be interested as well, the anvil is one of the more famous mods.

AliasAlreadyTaken added the

5. result/fixed

label 2022-11-23 11:05:11 +00:00

AliasAlreadyTaken added the

3. source/mod upstream

label 2022-11-23 11:06:11 +00:00

flux commented

2022-11-24 03:57:13 +00:00

Why were all labels removed? This was certainly a bug and it is now fixed, right?

I assume others might be interested as well, the anvil is one of the more famous mods.

in this case, i don't know why i removed the "kind/bug" label, nor why i didn't apply "resultfixed". i think those must have been an accident. the "upstream" fix is part of my cottages update, and not the stand-alone anvils mod, which is why i didn't include "upstream" here.

> Why were all labels removed? This was certainly a bug and it is now fixed, right? > > I assume others might be interested as well, the anvil is one of the more famous mods. in this case, i don't know why i removed the "kind/bug" label, nor why i didn't apply "resultfixed". i think those must have been an accident. the "upstream" fix is part of my cottages update, and not the stand-alone anvils mod, which is why i didn't include "upstream" here.

👍 1

AliasAlreadyTaken commented

2022-11-24 15:55:54 +00:00

We're using https://gitea.your-land.de/mt-mirror/anvil

flux commented

2022-11-24 16:16:01 +00:00

our anvil mod and the upstream (https://github.com/minetest-mods/anvil) have diverged quite a bit.

AliasAlreadyTaken commented

2022-11-24 16:29:05 +00:00

If our fixes are of public interest and not YL specific, is there a way to get them back together?

flux commented

2022-11-24 21:07:34 +00:00

If our fixes are of public interest and not YL specific, is there a way to get them back together?

yes, but i'm not super interested in doing that at the moment. maybe some day.

> If our fixes are of public interest and not YL specific, is there a way to get them back together? yes, but i'm not super interested in doing that at the moment. maybe some day.

Sign in to join this conversation.