update arena_lib after they accept my PR #2644
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#2644
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
i'm surprised non-numeric groups don't crash other things, but craftsystem got confused by this.
https://gitlab.com/zughy-friends-minetest/arena_lib/-/merge_requests/30/diffs
do we even use arena_lib? i spawned one of the items on the test server, and tried to use it, and it crashed the test server :\
arena_lib is used by the wormball arena. Unfortunately wormball is very sensitive towards lags, so hardly anyone played it lately. Plus, I intend to port over all the minigames to arena_lib eventually.
wormball actually works? i thought it was non-functional.
upstream PR got accepted a month ago, it is not yet live.
this did not make it onto the main server w/ 1.1.117, bumping the release to next
Which one is legitimate upstream?
This is the one flux PRed to:
https://gitlab.com/zughy-friends-minetest/arena_lib
This is the one we used as upstream until now:
https://gitlab.com/arcadeemulationserver/arena_lib
I'm guessing it's the first one, but why? Shouldn't the second one be active on the reference server AES?
content db also points to the first.
oh dang, i didn't realize we weren't using the original (zughy) fork. it looks like the 2 forks diverged on 2021-03-12, w/ MisterE doing some further work on the fork we use, while zughy did a ton more work on the original. i doubt we can switch forks w/out checking that it doesn't break things anywhere. then again, it appears we only use arena_lib for quikbild and wormball, neither of which are actually functional anyway? perhaps it doesn't matter so much?
With the lag we have, noone plays wormball. Maybe we should think of disabling them for the time being, until it is clear which arena_lib is legitimate upstream. My hope is that both of them merge into each other.
unless MisterE comes back, i feel like the best bet is for me to analyze and try to integrate his commits into Zughy's continued work. do you think that's worth the effort?
Just for clarity, Zughy's should be the upstream. Ive been working with Zughy on A.E.S. and I have helped with Arena_lib a little, though Zughy is very picky about code quality, so mostly he does stuff. The most stable version is his; the bugs that my version fixed i'm pretty sure are fixed in his.
@MisterE123 what's the address of your arena_lib repo?
Mine (outdated): https://gitlab.com/arcadeemulationserver/arena_lib ... Don't use it.
Don't bother scavenging code from it.
Zughy's (official, constant updates, feature requests considered) ... https://gitlab.com/zughy-friends-minetest/arena_lib/ ... Use it
alright, so i should PR zughy, putting it on the todo list
re-reading: @AliasAlreadyTaken i already PR'ed zughy and the change got accepted, we need to switch to that. however, we certainly need to test and make sure our games don't cause crashes.
Switched out arena_lib
39ac9e0d4f
QA
I tested at least singleplayer wormball and it still worked, so I'd give it a yay.
this is live