update arena_lib after they accept my PR #2644

Closed
opened 2022-09-10 23:58:50 +00:00 by flux · 17 comments
Member

i'm surprised non-numeric groups don't crash other things, but craftsystem got confused by this.

https://gitlab.com/zughy-friends-minetest/arena_lib/-/merge_requests/30/diffs

i'm surprised non-numeric groups don't crash other things, but craftsystem got confused by this. https://gitlab.com/zughy-friends-minetest/arena_lib/-/merge_requests/30/diffs
flux added the
1. kind/enhancement
3. source/mod upstream
labels 2022-09-10 23:58:50 +00:00
AliasAlreadyTaken was assigned by flux 2022-09-10 23:58:50 +00:00
Author
Member

do we even use arena_lib? i spawned one of the items on the test server, and tried to use it, and it crashed the test server :\

do we even use arena_lib? i spawned one of the items on the test server, and tried to use it, and it crashed the test server :\

arena_lib is used by the wormball arena. Unfortunately wormball is very sensitive towards lags, so hardly anyone played it lately. Plus, I intend to port over all the minigames to arena_lib eventually.

arena_lib is used by the wormball arena. Unfortunately wormball is very sensitive towards lags, so hardly anyone played it lately. Plus, I intend to port over all the minigames to arena_lib eventually.
Author
Member

wormball actually works? i thought it was non-functional.

wormball actually works? i thought it was non-functional.
flux added the
4. step/ready to QA test
label 2022-10-17 18:09:07 +00:00
Author
Member

upstream PR got accepted a month ago, it is not yet live.

upstream PR got accepted a month ago, it is not yet live.
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-10-20 18:45:22 +00:00
flux modified the milestone from 1.1.116 to 1.1.117 2022-11-18 00:38:46 +00:00
AliasAlreadyTaken added the
ugh/QA main
label 2023-01-18 12:12:18 +00:00
flux modified the milestone from 1.1.117 to 1.1.117.1 2023-01-25 22:17:51 +00:00
Author
Member

this did not make it onto the main server w/ 1.1.117, bumping the release to next

this did *not* make it onto the main server w/ 1.1.117, bumping the release to next
AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118 2023-02-23 11:55:00 +00:00

Which one is legitimate upstream?

This is the one flux PRed to:

https://gitlab.com/zughy-friends-minetest/arena_lib

This is the one we used as upstream until now:

https://gitlab.com/arcadeemulationserver/arena_lib

I'm guessing it's the first one, but why? Shouldn't the second one be active on the reference server AES?

content db also points to the first.

Which one is legitimate upstream? This is the one flux PRed to: https://gitlab.com/zughy-friends-minetest/arena_lib This is the one we used as upstream until now: https://gitlab.com/arcadeemulationserver/arena_lib I'm guessing it's the first one, but why? Shouldn't the second one be active on the reference server AES? content db also points to the first.
Author
Member

Which one is legitimate upstream?

oh dang, i didn't realize we weren't using the original (zughy) fork. it looks like the 2 forks diverged on 2021-03-12, w/ MisterE doing some further work on the fork we use, while zughy did a ton more work on the original. i doubt we can switch forks w/out checking that it doesn't break things anywhere. then again, it appears we only use arena_lib for quikbild and wormball, neither of which are actually functional anyway? perhaps it doesn't matter so much?

> Which one is legitimate upstream? oh dang, i didn't realize we weren't using the original (zughy) fork. it looks like the 2 forks diverged on 2021-03-12, w/ MisterE doing some further work on the fork we use, while zughy did a *ton* more work on the original. i doubt we can switch forks w/out checking that it doesn't break things anywhere. then again, it appears we only use arena_lib for quikbild and wormball, neither of which are actually functional anyway? perhaps it doesn't matter so much?

With the lag we have, noone plays wormball. Maybe we should think of disabling them for the time being, until it is clear which arena_lib is legitimate upstream. My hope is that both of them merge into each other.

With the lag we have, noone plays wormball. Maybe we should think of disabling them for the time being, until it is clear which arena_lib is legitimate upstream. My hope is that both of them merge into each other.
Author
Member

With the lag we have, noone plays wormball. Maybe we should think of disabling them for the time being, until it is clear which arena_lib is legitimate upstream. My hope is that both of them merge into each other.

unless MisterE comes back, i feel like the best bet is for me to analyze and try to integrate his commits into Zughy's continued work. do you think that's worth the effort?

> With the lag we have, noone plays wormball. Maybe we should think of disabling them for the time being, until it is clear which arena_lib is legitimate upstream. My hope is that both of them merge into each other. unless MisterE comes back, i feel like the best bet is for me to analyze and try to integrate his commits into Zughy's continued work. do you think that's worth the effort?
AliasAlreadyTaken added
4. step/discussion
1. kind/breaking
and removed
ugh/QA main
labels 2023-02-25 04:36:50 +00:00
Member

Just for clarity, Zughy's should be the upstream. Ive been working with Zughy on A.E.S. and I have helped with Arena_lib a little, though Zughy is very picky about code quality, so mostly he does stuff. The most stable version is his; the bugs that my version fixed i'm pretty sure are fixed in his.

Just for clarity, Zughy's should be the upstream. Ive been working with Zughy on A.E.S. and I have helped with Arena_lib a little, though Zughy is very picky about code quality, so mostly he does stuff. The most stable version is his; the bugs that my version fixed i'm pretty sure are fixed in his.
Author
Member

@MisterE123 what's the address of your arena_lib repo?

@MisterE123 what's the address of your arena_lib repo?
Member

Mine (outdated): https://gitlab.com/arcadeemulationserver/arena_lib ... Don't use it.
Don't bother scavenging code from it.

Zughy's (official, constant updates, feature requests considered) ... https://gitlab.com/zughy-friends-minetest/arena_lib/ ... Use it

Mine (outdated): https://gitlab.com/arcadeemulationserver/arena_lib ... Don't use it. Don't bother scavenging code from it. Zughy's (official, constant updates, feature requests considered) ... https://gitlab.com/zughy-friends-minetest/arena_lib/ ... Use it
Author
Member

alright, so i should PR zughy, putting it on the todo list

alright, so i should PR zughy, putting it on the todo list
flux added
4. step/at work
2. prio/elevated
and removed
4. step/ready to QA test
4. step/discussion
labels 2023-03-15 02:48:17 +00:00
Author
Member

re-reading: @AliasAlreadyTaken i already PR'ed zughy and the change got accepted, we need to switch to that. however, we certainly need to test and make sure our games don't cause crashes.

re-reading: @AliasAlreadyTaken i already PR'ed zughy and the change got accepted, we need to switch to that. however, we certainly need to test and make sure our games don't cause crashes.
flux added
4. step/ready to QA test
and removed
4. step/at work
labels 2023-03-15 02:51:16 +00:00

Switched out arena_lib 39ac9e0d4f

Switched out arena_lib https://gitea.your-land.de/your-land/yourland-mods/commit/39ac9e0d4f2b77e8ebcbc434ab24f2d4d0f9f054

QA

I tested at least singleplayer wormball and it still worked, so I'd give it a yay.

QA I tested at least singleplayer wormball and it still worked, so I'd give it a yay.
AliasAlreadyTaken added the
ugh/QA OK
label 2023-04-14 06:27:27 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-04-25 18:52:44 +00:00
AliasAlreadyTaken was unassigned by flux 2023-04-25 18:52:46 +00:00
Author
Member

this is live

this is live
flux closed this issue 2023-04-25 18:52:53 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2644
No description provided.