re-enable petz.throw? #2592

New Issue

flux · 2022-08-31T20:42:35Z

flux commented

2022-08-31 20:42:35 +00:00

it's disabled here:

https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/bugfixes/petz.lua

i'm not sure why it was disabled. did it used to crash? we're running a much newer version of petz. should we test re-enabling it?

it's disabled here: * https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/bugfixes/petz.lua i'm not sure why it was disabled. did it used to crash? we're running a much newer version of petz. should we test re-enabling it?

flux added the

1. kind/enhancement

4. step/question

labels 2022-08-31 20:42:35 +00:00

AliasAlreadyTaken was assigned by flux

2022-08-31 20:42:35 +00:00

flux self-assigned this 2022-08-31 20:42:35 +00:00

flux commented

2022-08-31 20:47:35 +00:00

seems like it was disabled here:

b3f24f31c2

seems like it was disabled here: https://gitea.your-land.de/your-land/yl_commons/commit/b3f24f31c2a2904fb6496f3855da36449296c097

AliasAlreadyTaken commented

2022-09-01 12:14:08 +00:00

Now if I only knew why I did that. I guesss it had to do with an error caused by the petz throw, but in a different position. If we re-enable we need to test all around petz other throw parts, where all of those functions play a role.

flux commented

2022-09-01 16:22:45 +00:00

noting that this is more-orless a dupe of #2265

the commit says "bugfix grenade", i've just remembered that petz has a "jack-o-lantern grenade". i'm not sure what problems those cause, but possibly it was because they explode, and explosions are now "fixed".

i'll re-enable it locally and do some testing and see if anything interesting occurs.

noting that this is more-orless a dupe of #2265 the commit says "bugfix grenade", i've just remembered that petz has a "jack-o-lantern grenade". i'm not sure what problems those cause, but possibly it was because they explode, and explosions are now "fixed". i'll re-enable it locally and do some testing and see if anything interesting occurs.

flux added this to the flux's TODO list project 2022-09-01 16:22:49 +00:00

flux added the

4. step/at work

label 2022-09-01 16:23:30 +00:00

AliasAlreadyTaken commented

2022-09-01 16:27:58 +00:00

MAybe it was an emergency hotfix because the grenade didn't respect protections?

flux commented

2022-09-01 16:56:24 +00:00

after testing, i found one major issue, but that can be disabled w/out disabling the throw mechanic entirely.

the issue is that jack-o-lantern grenades don't respect PvP, and the throw mechanic doesn't record who threw the grenade, so there's no easy way to integrate that. however, it's trivial to disable jack-o-lantern grenade damage in petz's user.conf.

i disabled the damage in 5ac142ac41, and re-enabled petz throw in e1031d6222. we can play w/ this more on the test server.

after testing, i found one major issue, but that can be disabled w/out disabling the throw mechanic entirely. the issue is that jack-o-lantern grenades don't respect PvP, and the throw mechanic doesn't record who threw the grenade, so there's no easy way to integrate that. however, it's trivial to disable jack-o-lantern grenade damage in petz's `user.conf`. i disabled the damage in https://gitea.your-land.de/your-land/petz/commit/5ac142ac41aeb012bae376350eb0d426ca6a3e0d, and re-enabled petz throw in https://gitea.your-land.de/your-land/yl_commons/commit/e1031d6222319360dd327c29eb573e6047f16d65. we can play w/ this more on the test server.

flux removed the

4. step/question

4. step/at work

labels 2022-09-01 16:56:40 +00:00

flux referenced this issue

2022-09-01 16:57:08 +00:00

AspireMint reports: [Square ball] When you try to ... #2265

flux added the

4. step/ready to QA test

label 2022-09-20 20:24:00 +00:00

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-02 13:10:20 +00:00

flux added