JeCel reports: The mail notification for rece ... #2505

New Issue

yourland-report · 2022-08-21T23:41:01Z

yourland-report commented

2022-08-21 23:41:01 +00:00

JeCel reports a bug:

The mail notification for receiving mail in a mailbox seems to be buggy. It happened multiple times now, that I received notifications more than an hour later after something was put in my mailbox. I got also multiple notifications for the same thing. E.g. today I received three notifications for one thing, the third telling me I received 17 books, even though it was just one.

Player position:

{
	z = 10343.6328125,
	x = 6531.9448242188,
	y = -26.498998641968
}

Player look:

{
	z = -0.36334580183029,
	x = 0.92477250099182,
	y = -0.11302979290485
}

Player information:

{
	state = "Active",
	ip_version = 6,
	lang_code = "",
	max_rtt = 0.78299999237061,
	avg_rtt = 0.061000000685453,
	min_jitter = 0,
	max_jitter = 0.74099999666214,
	avg_jitter = 0.032999999821186,
	connection_uptime = 16550,
	serialization_version = 28,
	patch = 1,
	major = 5,
	minor = 4,
	version_string = "5.4.1",
	protocol_version = 39,
	formspec_version = 4,
	min_rtt = 0.026000000536442
}

Player meta:

{
	fields = {
		["stamina:level"] = "17",
		["stamina:poisoned"] = "no",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 7300\", \"3d_armor:chestplate_crystal 1 7300\", \"3d_armor:leggings_crystal 1 7300\", \"3d_armor:boots_crystal 1 7300\", \"shields:shield_rainbow 1 12824\", \"\"}",
		["ocean_build.ocean_built"] = "6",
		punch_count = "26584",
		xp_redo_hud_color = "0x99ffff",
		["signslib:pos"] = "(6627,-46,10414)",
		xp = "1272874",
		inflicted_damage = "537434",
		hud_state = "on",
		repellant = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		crafted = "314557",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 10339, [\"x\"] = 6540, [\"y\"] = -5}, [\"last_death_portal\"] = 1659295219}",
		played_time = "2231951",
		digged_nodes = "907427",
		placed_nodes = "178506",
		died = "22",
		partychat = "main",
		arenalib_infobox_arenaID = "0",
		["ocean_build.last_warning"] = "1.65313e+09",
		yl_commons_thankyou = "47",
		jointime = "1621787993",
		["stamina:exhaustion"] = "79.5",
		yl_commons_player_created = "1621787993",
		yl_commons_player_joined = "1661108766",
		bitten = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = 2rOqUlwMWiMOOJkZyCfkgWocgpoEA4hY

Profiler save:

profile-20220821T234101.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 1d 8h 39min 10s | max lag: 2.36s | clients: Wushkin, Dankcat, Zizis, Bailiff, AliasAlreadyTaken, Service, dasmoermel, Ivanhoe, TechnoDot, Oakenshield, mrminer, jackofthebean000, dragonhex, Cody, Laylem, JeCel, hbreturns, Bla, daydream, LeetPeet, pitman, flux, Lupercus

Teleport command:

/teleport xyz 6532 -26 10344

Compass command:

/give_compass Construction 2rOqUlwMWiMOOJkZyCfkgWocgpoEA4hY D2691E 6532 -26 10344

JeCel reports a bug: > The mail notification for receiving mail in a mailbox seems to be buggy. It happened multiple times now, that I received notifications more than an hour later after something was put in my mailbox. I got also multiple notifications for the same thing. E.g. today I received three notifications for one thing, the third telling me I received 17 books, even though it was just one. Player position: ``` { z = 10343.6328125, x = 6531.9448242188, y = -26.498998641968 } ``` Player look: ``` { z = -0.36334580183029, x = 0.92477250099182, y = -0.11302979290485 } ``` Player information: ``` { state = "Active", ip_version = 6, lang_code = "", max_rtt = 0.78299999237061, avg_rtt = 0.061000000685453, min_jitter = 0, max_jitter = 0.74099999666214, avg_jitter = 0.032999999821186, connection_uptime = 16550, serialization_version = 28, patch = 1, major = 5, minor = 4, version_string = "5.4.1", protocol_version = 39, formspec_version = 4, min_rtt = 0.026000000536442 } ``` Player meta: ``` { fields = { ["stamina:level"] = "17", ["stamina:poisoned"] = "no", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 7300\", \"3d_armor:chestplate_crystal 1 7300\", \"3d_armor:leggings_crystal 1 7300\", \"3d_armor:boots_crystal 1 7300\", \"shields:shield_rainbow 1 12824\", \"\"}", ["ocean_build.ocean_built"] = "6", punch_count = "26584", xp_redo_hud_color = "0x99ffff", ["signslib:pos"] = "(6627,-46,10414)", xp = "1272874", inflicted_damage = "537434", hud_state = "on", repellant = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", crafted = "314557", yl_church = "return {[\"last_death\"] = {[\"z\"] = 10339, [\"x\"] = 6540, [\"y\"] = -5}, [\"last_death_portal\"] = 1659295219}", played_time = "2231951", digged_nodes = "907427", placed_nodes = "178506", died = "22", partychat = "main", arenalib_infobox_arenaID = "0", ["ocean_build.last_warning"] = "1.65313e+09", yl_commons_thankyou = "47", jointime = "1621787993", ["stamina:exhaustion"] = "79.5", yl_commons_player_created = "1621787993", yl_commons_player_joined = "1661108766", bitten = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2rOqUlwMWiMOOJkZyCfkgWocgpoEA4hY ``` Profiler save: ``` profile-20220821T234101.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 1d 8h 39min 10s | max lag: 2.36s | clients: Wushkin, Dankcat, Zizis, Bailiff, AliasAlreadyTaken, Service, dasmoermel, Ivanhoe, TechnoDot, Oakenshield, mrminer, jackofthebean000, dragonhex, Cody, Laylem, JeCel, hbreturns, Bla, daydream, LeetPeet, pitman, flux, Lupercus ``` Teleport command: ``` /teleport xyz 6532 -26 10344 ``` Compass command: ``` /give_compass Construction 2rOqUlwMWiMOOJkZyCfkgWocgpoEA4hY D2691E 6532 -26 10344 ```

AliasAlreadyTaken was assigned by yourland-report

2022-08-21 23:41:01 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2022-08-22 00:05:46 +00:00

flux commented

2022-08-22 01:05:09 +00:00

i remember there was an attempt to limit the spamminess of the "you have mail in a mailbox!" alerts, but it never seemed to work quite right.

AliasAlreadyTaken commented

2022-08-22 03:46:41 +00:00

I made it that only the first tossed item creates an email immediately, but all the items tossed after the first during the next hour are collected in one.

Reasoning is that when someone gets tossed one item, the mailbox doesn't know whether more may come. So we send out a mail right after the first, to inform the person at once. Come more items, the player still gets informed when not online or not paying attention. If he does and rushes towards the mailbox, he finds the other items anyways, mail or not.

Sure, we could make it that even after the first item, a timer waits for a second item. If that doesn't happen before the timer runs out, we send a mail. Every new item in the mail extends the timer and the mail is only sent, after the timer ran out.

I made it that only the first tossed item creates an email immediately, but all the items tossed after the first during the next hour are collected in one. Reasoning is that when someone gets tossed one item, the mailbox doesn't know whether more may come. So we send out a mail right after the first, to inform the person at once. Come more items, the player still gets informed when not online or not paying attention. If he does and rushes towards the mailbox, he finds the other items anyways, mail or not. Sure, we could make it that even after the first item, a timer waits for a second item. If that doesn't happen before the timer runs out, we send a mail. Every new item in the mail extends the timer and the mail is only sent, after the timer ran out.

flux added the

2. prio/low

label 2022-11-03 23:33:43 +00:00

flux commented

2022-11-03 23:36:08 +00:00

one alternate is that it could wait a while (5 minutes?) to see if anything else is put in the mailbox, before sending the first email.

as it stands, at least the current system cuts down on the spam.

one alternate is that it could wait a while (5 minutes?) to see if anything else is put in the mailbox, before sending the first email. as it stands, at least the current system cuts down on the spam.

flux added the

4. step/ready to QA test

label 2023-01-03 21:54:59 +00:00

flux commented

2023-01-03 21:55:09 +00:00

fixed in 7820314597

fixed in https://gitea.your-land.de/your-land/mailbox/commit/78203145979a67482a4a2ee654a4e001bc02d833

AliasAlreadyTaken added this to the 1.1.117 milestone 2023-01-05 13:18:53 +00:00

AliasAlreadyTaken commented

2023-01-18 13:13:24 +00:00

Somehow I don't get mails at all now?

AliasAlreadyTaken added the

4. step/question

label 2023-01-18 13:13:31 +00:00

flux commented

2023-01-18 22:45:37 +00:00

Somehow I don't get mails at all now?

how long did you wait? it takes 15 minutes, which ought to be a config option.

> Somehow I don't get mails at all now? how long did you wait? it takes 15 minutes, which *ought* to be a config option.

flux commented

2023-01-18 23:20:43 +00:00

tested that it comes after 15 minutes on the test server:

added options to allow easy configuration:

7c1cc8ac50

tested that it comes after 15 minutes on the test server: ![image](/attachments/769fbcce-fdfd-4c85-9f51-f876e1005e6d) added options to allow easy configuration: https://gitea.your-land.de/your-land/mailbox/commit/7c1cc8ac50aefb7e97a7f14b0283698630a0abca

image.png

56 KiB

AliasAlreadyTaken added the

ugh/QA OK

label 2023-01-19 08:14:20 +00:00

AliasAlreadyTaken commented

2023-01-19 08:15:09 +00:00

Nice. This time I received the mail after the default 15 seconds :)

flux added

5. result/fixed

and removed

4. step/ready to QA test