Ravise reports: petz should set their "for sal ... #2411

Closed
opened 2022-08-05 18:31:57 +00:00 by yourland-report · 9 comments

Ravise reports a bug:

petz should set their "for sale" checkbox to false on buying it [rationale: I bought it and I'd like to keep it]

Player position:

{
	y = 21.5,
	z = 14433.833984375,
	x = 10137.352539063
}

Player look:

{
	y = 0.26033601164818,
	z = -0.86875921487808,
	x = -0.42128679156303
}

Player information:

{
	formspec_version = 6,
	lang_code = "cs",
	major = 5,
	minor = 6,
	version_string = "5.6.0-dev-2351c9561-dirty",
	ip_version = 6,
	min_rtt = 0.016000000759959,
	max_rtt = 2.4210000038147,
	avg_rtt = 0.10300000011921,
	min_jitter = 0,
	max_jitter = 2.3989999294281,
	avg_jitter = 0.083999998867512,
	connection_uptime = 10164,
	serialization_version = 29,
	patch = 0,
	protocol_version = 40,
	state = "Active"
}

Player meta:

{
	fields = {
		["ocean_build.last_warning"] = "1.65212e+09",
		["stamina:level"] = "9",
		["ocean_build.ocean_built"] = "11",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "141.5",
		punch_count = "23923",
		jointime = "1612098151",
		inflicted_damage = "383772",
		arenalib_infobox_arenaID = "0",
		partychat = "party",
		repellant = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["signslib:pos"] = "(10060,19,14465)",
		xp = "384775",
		yl_commons_thankyou = "39",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"z\"] = 8219, [\"x\"] = 4074}, [\"last_death_portal\"] = 1659543468}",
		bitten = "0",
		played_time = "3632851",
		digged_nodes = "910741",
		partynoinvite = "true",
		died = "56",
		crafted = "8373",
		yl_commons_player_joined = "1659714219",
		placed_nodes = "127836",
		hud_state = "off",
		yl_commons_player_created = "1612098151",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 1040\", \"3d_armor:chestplate_crystal 1 1040\", \"3d_armor:leggings_crystal 1 1040\", \"3d_armor:boots_crystal 1 1040\", \"shields:shield_crystal 1 1040\", \"\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = RSb8cWIeIlOOWwXr27WdhQZwxmV7MpAI

Profiler save:

profile-20220805T183156.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 5d 14h 27min 50s | max lag: 2.73s | clients: RedAppleYum, Cody, paneg, jackofthebean000, upie, Lupercus, ninjago800, acen2006, bubbafrog, shanish, Ceppi, FailFactory, uehduwjwi, XeLNaGa, Bishiro, pitman, flux, Ravise, daydream, Boot, Kiyoko, GrimPixel, AliasAlreadyTaken, Service, Kodin, Bailiff

Teleport command:

/teleport xyz 10137 22 14434

Compass command:

/give_compass Construction RSb8cWIeIlOOWwXr27WdhQZwxmV7MpAI D2691E 10137 22 14434
Ravise reports a bug: > petz should set their "for sale" checkbox to false on buying it [rationale: I bought it and I'd like to keep it] Player position: ``` { y = 21.5, z = 14433.833984375, x = 10137.352539063 } ``` Player look: ``` { y = 0.26033601164818, z = -0.86875921487808, x = -0.42128679156303 } ``` Player information: ``` { formspec_version = 6, lang_code = "cs", major = 5, minor = 6, version_string = "5.6.0-dev-2351c9561-dirty", ip_version = 6, min_rtt = 0.016000000759959, max_rtt = 2.4210000038147, avg_rtt = 0.10300000011921, min_jitter = 0, max_jitter = 2.3989999294281, avg_jitter = 0.083999998867512, connection_uptime = 10164, serialization_version = 29, patch = 0, protocol_version = 40, state = "Active" } ``` Player meta: ``` { fields = { ["ocean_build.last_warning"] = "1.65212e+09", ["stamina:level"] = "9", ["ocean_build.ocean_built"] = "11", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "141.5", punch_count = "23923", jointime = "1612098151", inflicted_damage = "383772", arenalib_infobox_arenaID = "0", partychat = "party", repellant = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["signslib:pos"] = "(10060,19,14465)", xp = "384775", yl_commons_thankyou = "39", yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"z\"] = 8219, [\"x\"] = 4074}, [\"last_death_portal\"] = 1659543468}", bitten = "0", played_time = "3632851", digged_nodes = "910741", partynoinvite = "true", died = "56", crafted = "8373", yl_commons_player_joined = "1659714219", placed_nodes = "127836", hud_state = "off", yl_commons_player_created = "1612098151", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 1040\", \"3d_armor:chestplate_crystal 1 1040\", \"3d_armor:leggings_crystal 1 1040\", \"3d_armor:boots_crystal 1 1040\", \"shields:shield_crystal 1 1040\", \"\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = RSb8cWIeIlOOWwXr27WdhQZwxmV7MpAI ``` Profiler save: ``` profile-20220805T183156.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 5d 14h 27min 50s | max lag: 2.73s | clients: RedAppleYum, Cody, paneg, jackofthebean000, upie, Lupercus, ninjago800, acen2006, bubbafrog, shanish, Ceppi, FailFactory, uehduwjwi, XeLNaGa, Bishiro, pitman, flux, Ravise, daydream, Boot, Kiyoko, GrimPixel, AliasAlreadyTaken, Service, Kodin, Bailiff ``` Teleport command: ``` /teleport xyz 10137 22 14434 ``` Compass command: ``` /give_compass Construction RSb8cWIeIlOOWwXr27WdhQZwxmV7MpAI D2691E 10137 22 14434 ```
AliasAlreadyTaken was assigned by yourland-report 2022-08-05 18:31:57 +00:00
flux added the
1. kind/bug
3. source/mod upstream
ugh/petz
labels 2022-08-06 01:36:48 +00:00
Member

first, check to make sure this is something that hasn't already been fixed. we haven't updated petz in months.

first, check to make sure this is something that hasn't already been fixed. we haven't updated petz in months.
flux added this to the flux's TODO list project 2022-08-06 01:42:04 +00:00
flux self-assigned this 2022-08-06 01:42:09 +00:00
Member

can't replicate this on a local server. used creative inv to get a monkey, set the sale price to 2 gold. another account bought it. the "for sale" feature has been disabled.

can't replicate this on a local server. used creative inv to get a monkey, set the sale price to 2 gold. another account bought it. the "for sale" feature has been disabled.
Member

can't replicate on the live server either. sent an email to ravise:

when i test selling a chimp through the animal's GUI, it seems to properly mark it as not "for-sale" anymore. are you sure this is happening? and for which animal?

note: resetting "for_sale" data is not something i addressed in #2387, i should do that.

can't replicate on the live server either. sent an email to ravise: ``` when i test selling a chimp through the animal's GUI, it seems to properly mark it as not "for-sale" anymore. are you sure this is happening? and for which animal? ``` note: resetting "for_sale" data is *not* something i addressed in #2387, i should do that.
Member

note: resetting "for_sale" data is not something i addressed in #2387, i should do that.

fixed that here: a16d56427c

> note: resetting "for_sale" data is *not* something i addressed in #2387, i should do that. fixed that here: https://github.com/fluxionary/minetest-smartshop/commit/a16d56427c0795ae6ec02db7030d78deff219df7
AliasAlreadyTaken added this to the 1.1.115 milestone 2022-08-13 16:19:29 +00:00
flux added the
5. result/fixed
label 2022-08-15 20:18:55 +00:00
flux closed this issue 2022-08-15 20:19:00 +00:00
flux added
5. result/cannot reproduce
and removed
5. result/fixed
labels 2022-08-15 20:19:09 +00:00
Member

re-opening; ravise showed me that the issue is when you pick the animal (wolf) up w/ a lasso and then place it again.

re-opening; ravise showed me that the issue is when you pick the animal (wolf) up w/ a lasso and then place it again.
flux reopened this issue 2022-08-17 19:30:53 +00:00
flux removed the
5. result/cannot reproduce
label 2022-08-17 19:31:05 +00:00
Member

need to check if this is still an issue w/ upstream petz

need to check if this is still an issue w/ upstream petz
Member
upstream issue: * https://github.com/runsy/petz/issues/111
Member

upstream fixed

upstream fixed
flux added the
4. step/ready to QA test
label 2022-08-19 18:28:15 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2022-08-31 01:47:40 +00:00
flux removed this from the flux's TODO list project 2022-08-31 01:47:43 +00:00
AliasAlreadyTaken was unassigned by flux 2022-08-31 01:47:46 +00:00
flux removed their assignment 2022-08-31 01:47:46 +00:00
Member

live

live
flux closed this issue 2022-08-31 01:48:10 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2411
No description provided.