JeCel reports: We have white street signs tha ... #2406

New Issue

yourland-report · 2022-08-04T13:40:05Z

yourland-report commented

2022-08-04 13:40:05 +00:00

JeCel reports a bug:

We have white street signs that are one node wide and the large banner that is three nodes wide. Would it be possible to get a banner that is two node wide, which gets crafted from two or threee white street signs?

Player position:

{
	y = -21.499000549316,
	z = 10419.075195313,
	x = 6520
}

Player look:

{
	y = 0.060874331742525,
	z = -0.22504350543022,
	x = -0.9724452495575
}

Player information:

{
	patch = 1,
	formspec_version = 4,
	lang_code = "",
	major = 5,
	minor = 4,
	version_string = "5.4.1",
	state = "Active",
	min_rtt = 0.025000000372529,
	ip_version = 6,
	protocol_version = 39,
	max_rtt = 1.6299999952316,
	avg_rtt = 0.030999999493361,
	min_jitter = 0,
	max_jitter = 1.5989999771118,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 5433,
	serialization_version = 28
}

Player meta:

{
	fields = {
		xp_redo_hud_color = "0x99ffff",
		["ocean_build.last_warning"] = "1.65313e+09",
		["stamina:level"] = "19",
		["ocean_build.ocean_built"] = "6",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "0",
		punch_count = "23216",
		jointime = "1621787993",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 31440\", \"3d_armor:chestplate_crystal 1 31440\", \"3d_armor:leggings_crystal 1 31440\", \"3d_armor:boots_crystal 1 32620\", \"shields:shield_rainbow 1 1024\", \"\"}",
		repellant = "0",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["signslib:pos"] = "(6552,-23,10404)",
		xp = "1187296",
		yl_commons_thankyou = "33",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 25, [\"z\"] = 2847, [\"x\"] = 7088}, [\"last_death_portal\"] = 1659295219}",
		partychat = "main",
		played_time = "1831216",
		digged_nodes = "857634",
		placed_nodes = "161310",
		died = "21",
		yl_commons_player_created = "1621787993",
		yl_commons_player_joined = "1659615003",
		crafted = "289225",
		hud_state = "on",
		inflicted_damage = "464028",
		bitten = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = C8x493x9OauuS2gaJlbm7h652t8jpRaL

Profiler save:

profile-20220804T134005.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 4d 9h 16s | max lag: 2.04s | clients: nignog, Chache, rabenkind, Hulda, Kirb, pacifist, Moji, Bla, Nibsokube, Artruc, Greater_Dog, Mielle, evil123, JeCel, Segmentation_Fault, Aero, icecreamkek, Dragoni_is_bored, BTS-, daydream, Bailiff, flux

Teleport command:

/teleport xyz 6520 -21 10419

Compass command:

/give_compass Construction C8x493x9OauuS2gaJlbm7h652t8jpRaL D2691E 6520 -21 10419

JeCel reports a bug: > We have white street signs that are one node wide and the large banner that is three nodes wide. Would it be possible to get a banner that is two node wide, which gets crafted from two or threee white street signs? Player position: ``` { y = -21.499000549316, z = 10419.075195313, x = 6520 } ``` Player look: ``` { y = 0.060874331742525, z = -0.22504350543022, x = -0.9724452495575 } ``` Player information: ``` { patch = 1, formspec_version = 4, lang_code = "", major = 5, minor = 4, version_string = "5.4.1", state = "Active", min_rtt = 0.025000000372529, ip_version = 6, protocol_version = 39, max_rtt = 1.6299999952316, avg_rtt = 0.030999999493361, min_jitter = 0, max_jitter = 1.5989999771118, avg_jitter = 0.0010000001639128, connection_uptime = 5433, serialization_version = 28 } ``` Player meta: ``` { fields = { xp_redo_hud_color = "0x99ffff", ["ocean_build.last_warning"] = "1.65313e+09", ["stamina:level"] = "19", ["ocean_build.ocean_built"] = "6", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "0", punch_count = "23216", jointime = "1621787993", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 31440\", \"3d_armor:chestplate_crystal 1 31440\", \"3d_armor:leggings_crystal 1 31440\", \"3d_armor:boots_crystal 1 32620\", \"shields:shield_rainbow 1 1024\", \"\"}", repellant = "0", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["signslib:pos"] = "(6552,-23,10404)", xp = "1187296", yl_commons_thankyou = "33", yl_church = "return {[\"last_death\"] = {[\"y\"] = 25, [\"z\"] = 2847, [\"x\"] = 7088}, [\"last_death_portal\"] = 1659295219}", partychat = "main", played_time = "1831216", digged_nodes = "857634", placed_nodes = "161310", died = "21", yl_commons_player_created = "1621787993", yl_commons_player_joined = "1659615003", crafted = "289225", hud_state = "on", inflicted_damage = "464028", bitten = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = C8x493x9OauuS2gaJlbm7h652t8jpRaL ``` Profiler save: ``` profile-20220804T134005.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 4d 9h 16s | max lag: 2.04s | clients: nignog, Chache, rabenkind, Hulda, Kirb, pacifist, Moji, Bla, Nibsokube, Artruc, Greater_Dog, Mielle, evil123, JeCel, Segmentation_Fault, Aero, icecreamkek, Dragoni_is_bored, BTS-, daydream, Bailiff, flux ``` Teleport command: ``` /teleport xyz 6520 -21 10419 ``` Compass command: ``` /give_compass Construction C8x493x9OauuS2gaJlbm7h652t8jpRaL D2691E 6520 -21 10419 ```

AliasAlreadyTaken was assigned by yourland-report

2022-08-04 13:40:05 +00:00

flux added the

1. kind/enhancement

label 2022-08-04 14:20:58 +00:00

Kodin commented

2022-08-09 08:41:11 +00:00

I want to see if I can attempt this.

Do we have the sign_api from the display modpack on the server?

I want to see if I can attempt this. Do we have the sign_api from the display modpack on the server?

AliasAlreadyTaken commented

2022-08-09 12:54:37 +00:00

Yes, we're using this https://gitea.your-land.de/mt-mirror/basic_signs and that https://github.com/mt-mods/signs_lib

And we're using this fork of Display modpack: https://github.com/pyrollo/display_modpack

Yes, we're using this https://gitea.your-land.de/mt-mirror/basic_signs and that https://github.com/mt-mods/signs_lib And we're using this fork of Display modpack: https://github.com/pyrollo/display_modpack

👍 1

flux commented

2022-08-09 15:49:46 +00:00

Yes, we're using this https://gitea.your-land.de/mt-mirror/basic_signs and that https://github.com/mt-mods/signs_lib

mt-mirror isn't visible to the public (i can't even see it).
these links might be more useful:

> Yes, we're using this https://gitea.your-land.de/mt-mirror/basic_signs and that https://github.com/mt-mods/signs_lib mt-mirror isn't visible to the public (i can't even see it). these links might be more useful: * https://gitea.your-land.de/your-land/basic_signs/src/branch/yl_stable * https://gitea.your-land.de/your-land/signs_lib/src/branch/yl_stable

👍 2

Kodin commented

2022-08-10 12:47:27 +00:00

Uh I can't view those links either..

Kodin commented

2022-08-10 14:43:08 +00:00

Well I've gotten a two wide banner working, but it centers itself like this which does look rather strange. I'm still experimenting so there might be a way to prevent this (that's unlikely because afaik this is also a problem with the large banner; but I'll still try!).

I'm wondering though, is this good enough to be merged in?

Well I've gotten a two wide banner working, but it centers itself like this which does look rather strange. I'm still experimenting so there might be a way to prevent this (that's unlikely because afaik this is also a problem with the large banner; but I'll still try!). I'm wondering though, is this good enough to be merged in? ![](https://gitea.your-land.de/attachments/edf7d0ce-a091-4f60-aef5-fdff04833494)

screenshot_20220810_193355.png

308 KiB

Kodin commented

2022-08-10 15:26:05 +00:00

It's a bit of a hack but it seems to be working pretty well!
Should I open a pull request on yl_common or should this be merged into another repo?

It's a bit of a hack but it seems to be working pretty well! Should I open a pull request on yl_common or should this be merged into another repo? ![](https://gitea.your-land.de/attachments/f721be74-2ca9-4bfc-98b3-bffdf8040939)

screenshot_20220810_202152.png

109 KiB

flux commented

2022-08-10 16:18:05 +00:00

Should I open a pull request on yl_common or should this be merged into another repo?

yl_commons should be fine for now, unless alias has other ideas.

> Should I open a pull request on yl_common or should this be merged into another repo? yl_commons should be fine for now, unless alias has other ideas.

👍 1

AliasAlreadyTaken commented

2022-08-10 16:30:06 +00:00

Nope, yl_commons is fine :)

flux added the

4. step/ready to QA test

label 2022-08-13 15:39:08 +00:00

flux commented

2022-08-13 15:39:25 +00:00

fixed in your-land/yl_commons#18

fixed in https://gitea.your-land.de/your-land/yl_commons/pulls/18

👍 1