compass UI should have a reset button #2367

New Issue

yourland-report · 2022-07-30T22:13:29Z

yourland-report commented

2022-07-30 22:13:29 +00:00

flux reports a bug:

~~compasses should be re-programable by anyone~~
compass UI should have a reset button

Player position:

{
	y = 47.700000762939,
	z = 624,
	x = 1289
}

Player look:

{
	y = -0.060177478939295,
	z = -0.99817401170731,
	x = -0.0052266237325966
}

Player information:

{
	max_rtt = 7.3550000190735,
	avg_rtt = 0.17000000178814,
	min_jitter = 0,
	max_jitter = 2.9860000610352,
	connection_uptime = 14081,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	lang_code = "",
	formspec_version = 5,
	avg_jitter = 0.0010000020265579,
	min_rtt = 0.16099999845028,
	major = 5,
	minor = 6,
	version_string = "5.6.0-dev-0db22e793-dirty",
	ip_version = 6,
	protocol_version = 40
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "1",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "5",
		digged_nodes = "1084126",
		placed_nodes = "353105",
		died = "66",
		xp = "1277653",
		["petz:werewolf_clan_idx"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}",
		repellant = "0",
		crafted = "39483",
		inflicted_damage = "1391638",
		["signslib:pos"] = "(1273,69,540)",
		["stamina:exhaustion"] = "4.5",
		played_time = "20680976",
		hud_state = "on",
		["stamina:level"] = "17",
		yl_commons_player_created = "1615351173",
		["stamina:poisoned"] = "no",
		yl_commons_player_joined = "1659205144",
		yl_commons_thankyou = "132",
		punch_count = "84899",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		jointime = "1615351173",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_shield 1 3220\", \"3d_armor:chestplate_nether 1 6440\", \"nether_mobs:dragon_boots 1 3220\", \"3d_armor:leggings_nether 1 6440\", \"3d_armor:helmet_nether 1 3220\", \"\"}",
		bitten = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = Rc5xWMdE9TK5QQNQkk2hJavCDLqcXEL9

Profiler save:

profile-20220730T221328.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 2d 17h 11min 14s | max lag: 1.8s | clients: E663568, NIGGAGAMING69, rabenkind, Therottenpotato, Papi, the_chosen_one, Lupercus, Lucien_II, alexandre2005, XeLNaGa, flux, SilentAvenger, daydream, Bla, Viofile, Service, pitman, AliasAlreadyTaken, Mielle, Bailiff

Teleport command:

/teleport xyz 1289 48 624

Compass command:

/give_compass Construction Rc5xWMdE9TK5QQNQkk2hJavCDLqcXEL9 D2691E 1289 48 624

flux reports a bug: > ~~compasses should be re-programable by anyone~~ > compass UI should have a reset button Player position: ``` { y = 47.700000762939, z = 624, x = 1289 } ``` Player look: ``` { y = -0.060177478939295, z = -0.99817401170731, x = -0.0052266237325966 } ``` Player information: ``` { max_rtt = 7.3550000190735, avg_rtt = 0.17000000178814, min_jitter = 0, max_jitter = 2.9860000610352, connection_uptime = 14081, serialization_version = 29, patch = 0, state = "Active", lang_code = "", formspec_version = 5, avg_jitter = 0.0010000020265579, min_rtt = 0.16099999845028, major = 5, minor = 6, version_string = "5.6.0-dev-0db22e793-dirty", ip_version = 6, protocol_version = 40 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "1", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "5", digged_nodes = "1084126", placed_nodes = "353105", died = "66", xp = "1277653", ["petz:werewolf_clan_idx"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}", repellant = "0", crafted = "39483", inflicted_damage = "1391638", ["signslib:pos"] = "(1273,69,540)", ["stamina:exhaustion"] = "4.5", played_time = "20680976", hud_state = "on", ["stamina:level"] = "17", yl_commons_player_created = "1615351173", ["stamina:poisoned"] = "no", yl_commons_player_joined = "1659205144", yl_commons_thankyou = "132", punch_count = "84899", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", jointime = "1615351173", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_shield 1 3220\", \"3d_armor:chestplate_nether 1 6440\", \"nether_mobs:dragon_boots 1 3220\", \"3d_armor:leggings_nether 1 6440\", \"3d_armor:helmet_nether 1 3220\", \"\"}", bitten = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = Rc5xWMdE9TK5QQNQkk2hJavCDLqcXEL9 ``` Profiler save: ``` profile-20220730T221328.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 2d 17h 11min 14s | max lag: 1.8s | clients: E663568, NIGGAGAMING69, rabenkind, Therottenpotato, Papi, the_chosen_one, Lupercus, Lucien_II, alexandre2005, XeLNaGa, flux, SilentAvenger, daydream, Bla, Viofile, Service, pitman, AliasAlreadyTaken, Mielle, Bailiff ``` Teleport command: ``` /teleport xyz 1289 48 624 ``` Compass command: ``` /give_compass Construction Rc5xWMdE9TK5QQNQkk2hJavCDLqcXEL9 D2691E 1289 48 624 ```

AliasAlreadyTaken was assigned by yourland-report

2022-07-30 22:13:29 +00:00

AliasAlreadyTaken commented

2022-07-31 01:26:05 +00:00

This would cause Amanda's compasses be reprogrammable, leading to infinite compasses.

Sure, we could make different types, "Amanda type" and "player type".

This would cause Amanda's compasses be reprogrammable, leading to infinite compasses. Sure, we could make different types, "Amanda type" and "player type".

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-07-31 01:26:13 +00:00

flux commented

2022-07-31 16:08:42 +00:00

This would cause Amanda's compasses be reprogrammable, leading to infinite compasses.

Sure, we could make different types, "Amanda type" and "player type".

or we could require the player to hand a compass in to amanda to program it? i think i like the idea of amanda's compasses being "locked" better though.

> This would cause Amanda's compasses be reprogrammable, leading to infinite compasses. > > Sure, we could make different types, "Amanda type" and "player type". or we could require the player to hand a compass in to amanda to program it? i think i like the idea of amanda's compasses being "locked" better though.

JeCel commented

2022-07-31 16:43:31 +00:00

What about making it so that players can only reprogramm the compasses that they programmed themselves?
So that it would be how it's done with books.

What about making it so that players can only reprogramm the compasses that they programmed themselves? So that it would be how it's done with books.

flux commented

2022-07-31 16:47:28 +00:00

What about making it so that players can only reprogramm the compasses that they programmed themselves?
So that it would be how it's done with books.

that's how it is currently. however, when players want to share compasses, it can become confusing.

> What about making it so that players can only reprogramm the compasses that they programmed themselves? > So that it would be how it's done with books. that's how it is currently. however, when players want to share compasses, it can become confusing.

AliasAlreadyTaken commented

2022-08-03 19:07:59 +00:00

Does "sharing compasses" happen?

When X gives a preset compass to Y and Y wants to copy the values from that compass, currently the owner of the copy is still X. In my opinion, we should change that so that Y owns the copy, since Y "set" it.

Does "sharing compasses" happen? When X gives a preset compass to Y and Y wants to copy the values from that compass, currently the owner of the copy is still X. In my opinion, we should change that so that Y owns the copy, since Y "set" it.

flux commented

2022-08-03 20:54:28 +00:00

PM from daydream: I have a compass, I use it all the time, Lucien just gave me a second one and I can't get it to work... is that like a bug?
PM to daydream: you can only reprogram compasses that you craft yourself
PM from daydream: oh for heaven's sake, had no idea ok I'll give this one back to him... appaerntly Amanda can hand them out but not players then I guess
PM to daydream: i'm not really sure there's a purpose for that
PM to daydream: amanda hands out owned compasses as well
PM to daydream: i think?
PM from daydream: I guess it's so nobody takes your compass and changes it on you? but it's way more handy if a player can program a few and hand them out... but even if Lucient programmed it, the output for me would still not work...
PM from daydream: cuz input does work but screen HUD doesn't
PM to daydream: you've got to hold it in your hand for it to work
PM from daydream: as I said (?) I use compass all the time
PM to daydream: honestly i thinkt they should all be programable, i'm gonna make a fewature request for that
PM to daydream: oh right, very odd
PM from daydream: this is strange... I put Luciens coords into my compass and now can't see the HUD either
PM to daydream: i wonder if compasses know how to use HUDs correctly, a lot of mods do not use them right and can end up in weird states. try logging off and logging back on?

``` PM from daydream: I have a compass, I use it all the time, Lucien just gave me a second one and I can't get it to work... is that like a bug? PM to daydream: you can only reprogram compasses that you craft yourself PM from daydream: oh for heaven's sake, had no idea ok I'll give this one back to him... appaerntly Amanda can hand them out but not players then I guess PM to daydream: i'm not really sure there's a purpose for that PM to daydream: amanda hands out owned compasses as well PM to daydream: i think? PM from daydream: I guess it's so nobody takes your compass and changes it on you? but it's way more handy if a player can program a few and hand them out... but even if Lucient programmed it, the output for me would still not work... PM from daydream: cuz input does work but screen HUD doesn't PM to daydream: you've got to hold it in your hand for it to work PM from daydream: as I said (?) I use compass all the time PM to daydream: honestly i thinkt they should all be programable, i'm gonna make a fewature request for that PM to daydream: oh right, very odd PM from daydream: this is strange... I put Luciens coords into my compass and now can't see the HUD either PM to daydream: i wonder if compasses know how to use HUDs correctly, a lot of mods do not use them right and can end up in weird states. try logging off and logging back on? ```

AliasAlreadyTaken commented

2022-08-03 23:38:22 +00:00

Well yes. Compasses once set cannot be given to someone else. But unset compasses can.

Maybe a compass needs an "unset" button?

Well yes. Compasses once set cannot be given to someone else. But unset compasses can. Maybe a compass needs an "unset" button?

flux commented

2022-08-04 00:54:16 +00:00

Maybe a compass needs an "unset" button?

i'm in favor of that vs. the current mechanic (i've accidentally reset my own compasses before), though it doesn't address the free compasses from amanda

> Maybe a compass needs an "unset" button? i'm in favor of that vs. the current mechanic (i've accidentally reset my own compasses before), though it doesn't address the free compasses from amanda

AliasAlreadyTaken commented

2022-08-04 17:27:52 +00:00

It does: Only the owner should be able to use the unset button. Then people and NPCs could still hand out locked compasses, but people could "unset" their compasses and then hand them over to someone else.

Also, the "copy" should change owner.

It does: Only the owner should be able to use the unset button. Then people and NPCs could still hand out locked compasses, but people could "unset" their compasses and then hand them over to someone else. Also, the "copy" should change owner.

flux commented

2022-08-04 18:54:36 +00:00

ah, i get it now. yeah, that sounds good.

flux added this to the flux's TODO list project 2022-08-04 23:57:25 +00:00

flux self-assigned this 2022-08-04 23:57:30 +00:00

AliasAlreadyTaken referenced this issue

2022-08-07 07:52:52 +00:00

AspireMint reports: [Compass alt recipe] Low prior ... #2185

daydream commented

2022-09-01 07:10:04 +00:00

If Amanda offered a reward of some kind (random from a list) maybe players would have fun returning them to see what they get?

AliasAlreadyTaken commented

2022-09-01 07:11:27 +00:00

Most likely yes - but then player would also have fun returning any compass to Amanda, unless we programmatically make sure its only the compass owned by Amanda.

However I like the idea, but it doesn't change my opinion towards the unset button and that owned compasses should not be changeable.

Most likely yes - but then player would also have fun returning any compass to Amanda, unless we programmatically make sure its only the compass owned by Amanda. However I like the idea, but it doesn't change my opinion towards the unset button and that owned compasses should not be changeable.

flux changed title from ~~flux reports: compasses should be re-program ...~~ to compass UI should have a reset button

2022-11-02 22:26:35 +00:00

flux added the

4. step/blocked

label 2022-11-02 22:27:21 +00:00

flux commented

2022-11-02 22:28:18 +00:00

before we do this we need to figure out how to deal w/ the license-less, abandoned compass mod

flux added a new dependency 2022-11-02 22:28:33 +00:00

your-land/administration#171 - Licensing

whosit commented

2023-05-12 14:17:54 +00:00

Player making a copy is now the owner:

aa575ae02b...f4299c2cda

I think originally I didn't want to allow people to see the coords if it has label. Seems like that is not needed in practice :P

Thinking what to do with unsetting not-owned compass.

Player making a copy is now the owner: https://gitea.your-land.de/whosit/waypoint_compass/compare/aa575ae02bfe7246aac90ec19c12ceccc8537c40...f4299c2cda7a384608213bc32a7fbd0c8796cf04 I think originally I didn't want to allow people to see the coords if it has label. Seems like that is not needed in practice :P Thinking what to do with unsetting not-owned compass.

whosit commented

2023-05-12 14:54:50 +00:00

Cooking a compass will reset it.
4da4a63c6c

Makes sense to me :P

If you don't approve, ~~you have to live with it~~ please comment or thumbsdown.

Rationale why there was no way to reset: since you can get infinite amounts of compasses from different NPCs, reset button makes crafting them almost pointless.

Cooking a compass will reset it. https://gitea.your-land.de/whosit/waypoint_compass/commit/4da4a63c6c35bd3ed6e90f36c99b34dd7706e33d Makes sense to me :P If you don't approve, ~~you have to live with it~~ please comment or thumbsdown. Rationale why there was no way to reset: since you can get infinite amounts of compasses from different NPCs, reset button makes crafting them almost pointless.

whosit removed the

4. step/blocked

label 2023-05-12 14:59:55 +00:00

flux commented

2023-05-12 18:35:33 +00:00

since you can get infinite amounts of compasses from different NPCs, reset button makes crafting them almost pointless.

i think alias and i agreed somewhere above, that players should only be able to reset their own compasses - cooking them isn't great for exactly the reason you mention.

> since you can get infinite amounts of compasses from different NPCs, reset button makes crafting them almost pointless. i think alias and i agreed somewhere above, that players should only be able to reset *their own* compasses - cooking them isn't great for exactly the reason you mention.

whosit commented

2023-05-12 19:07:07 +00:00

To reset your own compass you can remove the coordinates (just leave an empty field). It will be treated as non-owned. This was always a feature although not really documented. I'm sure I explained how to do that, but this knowledge became lost to time... Perhaps that's what readme's for...

Or I maybe there should be a label saying "leave empty to de-own" near pos field?

~~Should I revert the cooking trick? :)~~

To reset your own compass you can remove the coordinates (just leave an empty field). It will be treated as non-owned. This was always a feature although not really documented. I'm sure I explained how to do that, but this knowledge became lost to time... Perhaps that's what readme's for... Or I maybe there should be a label saying "leave empty to de-own" near pos field? ~~Should I revert the cooking trick? :)~~

whosit commented

2023-05-12 19:24:03 +00:00

added readme:
38ca0a6480
reverted cooking:
637a2b949f

added readme: https://gitea.your-land.de/whosit/waypoint_compass/commit/38ca0a648099ccdb64d7f8c04efb88eb8f5e42b0 reverted cooking: https://gitea.your-land.de/whosit/waypoint_compass/commit/637a2b949fbe6cf2743b17866928b7f008d91fc9

👍 2

flux commented

2023-05-13 03:02:25 +00:00

yay :)

flux added the

4. step/ready to QA test

label 2023-05-13 03:02:36 +00:00

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-13 07:11:52 +00:00

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-13 15:09:29 +00:00

flux added