Documentation on autoshops, please #2283

New Issue

DanteLives · 2022-07-20T03:19:27Z

DanteLives commented

2022-07-20 03:19:27 +00:00

I'm finding the green border on autoshops completely baffling. Nearly all (but not all) of my shops turn green when I log in. Once I look in the shop the border disappears without doing anything in the shop. There are no payments in these shops. I have two shops that are always green because they are money exchanges, so they always have money in them.

Before this update I had nearly all my shops connected to send payments to a single storage. To check for sales I simply checked this single storage. Now I'm clicking through (nearly) all my shops just to remove the green border and it seems pointless.

Could it be that payment received into the storage turns all shops that are linked to the storage green? If so that seems like a bug to me because there is nothing to be collected from the shops - it's all by design in the storage.

I'm finding the green border on autoshops completely baffling. Nearly all (but not all) of my shops turn green when I log in. Once I look in the shop the border disappears without doing anything in the shop. There are no payments in these shops. I have two shops that are always green because they are money exchanges, so they always have money in them. Before this update I had nearly all my shops connected to send payments to a single storage. To check for sales I simply checked this single storage. Now I'm clicking through (nearly) all my shops just to remove the green border and it seems pointless. Could it be that payment received into the storage turns all shops that are linked to the storage green? If so that seems like a bug to me because there is nothing to be collected from the shops - it's all by design in the storage.

DanteLives commented

2022-07-20 03:42:23 +00:00

Okay, here are my observations after testing.

I go to the customer view of my shop (which sends payments to storage) and buy an item. The frame goes green. The payment goes to storage. The shop stays green until I go to storage, collect the payment, and return to view the shop's inventory again. Then, and only then, the green border turns off. If I do the same for a shop that I don't have connected to storage then the border turns off once I retreive the payment from the shop.

This still doesn't seem to account for what I'm seeing. The last two days when I've logged in nearly all of my shops have had green borders. If someone was buying stock from all of these shops then it seems I'd have more payments in storage than what I've retrieved. So I suspect something else is going on, or maybe I need to pay more attention and count next time to be sure.

I don't know. Among my digital pet peeves are alerts that are ildefined and not easy to turn off. To me they're stressful because it's like I'm supposed to be doing something about them instead of them serving me in some way. Perhaps an option to turn off the feature?

Okay, here are my observations after testing. I go to the customer view of my shop (which sends payments to storage) and buy an item. The frame goes green. The payment goes to storage. The shop stays green until I go to storage, collect the payment, and return to view the shop's inventory again. Then, and only then, the green border turns off. If I do the same for a shop that I don't have connected to storage then the border turns off once I retreive the payment from the shop. This still doesn't seem to account for what I'm seeing. The last two days when I've logged in nearly all of my shops have had green borders. If someone was buying stock from all of these shops then it seems I'd have more payments in storage than what I've retrieved. So I suspect something else is going on, or maybe I need to pay more attention and count next time to be sure. I don't know. Among my digital pet peeves are alerts that are ildefined and not easy to turn off. To me they're stressful because it's like I'm supposed to be doing something about them instead of them serving me in some way. Perhaps an option to turn off the feature?

flux added the

1. kind/documentation

1. kind/bug

labels 2022-07-20 15:57:57 +00:00

flux added this to the flux's TODO list project 2022-07-20 15:58:00 +00:00

flux self-assigned this 2022-07-20 15:58:05 +00:00

flux commented

2022-07-20 16:04:23 +00:00

@DanteLives i should probably attempt to tackle the tricky issue of updating the shop colors when a wifi storage's inventory is modified; it's tricky because you can end up having to update the colors of possibly lots of other shops when someone uses one. i thought about making the storage nodes have colors too, but the semantics becomes muddled, because one storage node can be the "send" storage for 1 shop and the "refill" storage for another.

DanteLives commented

2022-07-21 01:36:11 +00:00

Okay, today I can definitely report that there is something buggy going on. All of my autoshops that are connected to the same storage are green. I've checked that storage and it has one mese crystal in it. That's payment for one item. I have some 24+ autoshops that are green. So it seems that something other than a payment is triggering my shops to turn green. When I tested this yesterday the payment only turns the shop which received the payment green.

flux commented

2022-07-21 17:21:26 +00:00

upstream issues:

https://github.com/fluxionary/minetest-smartshop/issues/28

upstream issues: * https://github.com/fluxionary/minetest-smartshop/issues/28 *

flux commented

2022-07-21 17:28:01 +00:00

Okay, today I can definitely report that there is something buggy going on. All of my autoshops that are connected to the same storage are green. I've checked that storage and it has one mese crystal in it. That's payment for one item. I have some 24+ autoshops that are green. So it seems that something other than a payment is triggering my shops to turn green. When I tested this yesterday the payment only turns the shop which received the payment green.

when an area is loaded/unloaded, the shops re-initialize. if there's payment in storage, all shops which accept such payment will turn green. no, that's not useful.

> Okay, today I can definitely report that there is something buggy going on. All of my autoshops that are connected to the same storage are green. I've checked that storage and it has one mese crystal in it. That's payment for one item. I have some 24+ autoshops that are green. So it seems that something other than a payment is triggering my shops to turn green. When I tested this yesterday the payment only turns the shop which received the payment green. when an area is loaded/unloaded, the shops re-initialize. if there's payment in storage, all shops which accept such payment will turn green. no, that's not useful.

flux commented

2022-07-21 19:59:16 +00:00

i reworked the coloring 4df46c23e2

the new semantics is, if a shop contains a pay item, it turns green. if payment is sent to storage, the storage turns green, the shop stays as would it otherwise appear.

if something is purchased and it comes from refill storage, and the storage lacks further items, the storage turns red.

if a player puts/takes items out of storage by hand, the storage resets to normal.

note that updates to storage still don't automatically update the status of other connected shops, as storage nodes don't keep track of which shops are connected to them. because the # of shops connected to a single storage is effectively unbounded, i don't really want to implement that.

i reworked the coloring https://github.com/fluxionary/minetest-smartshop/commit/4df46c23e2ca6dce18575c0dce1fe3cacc91e693 the new semantics is, if a shop contains a pay item, it turns green. if payment is sent to storage, the storage turns green, the shop stays as would it otherwise appear. if something is purchased and it comes from refill storage, and the storage lacks further items, the storage turns red. if a player puts/takes items out of storage by hand, the storage resets to normal. note that updates to storage still don't automatically update the status of other connected shops, as storage nodes don't keep track of which shops are connected to them. because the # of shops connected to a single storage is effectively unbounded, i don't really want to implement that.

flux added the

4. step/ready to QA test

label 2022-07-21 19:59:23 +00:00

AliasAlreadyTaken was assigned by flux

2022-07-23 00:11:45 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2022-07-28 18:50:58 +00:00

flux removed this from the flux's TODO list project 2022-07-28 18:51:35 +00:00

flux removed their assignment 2022-07-28 18:51:38 +00:00