flux reports: use big ingots (ingots.big = t ... #2281

New Issue

yourland-report · 2022-07-20T01:49:39Z

yourland-report commented

2022-07-20 01:49:39 +00:00

flux reports a bug:

use big ingots (ingots.big = true in minetest.conf); we'll have to figure out a way to refund old piles tho

Player position:

{
	y = 47.5,
	x = 1266.1340332031,
	z = 595.71496582031
}

Player look:

{
	y = -0.17605400085449,
	x = 0.98417174816132,
	z = -0.020271783694625
}

Player information:

{
	min_rtt = 0.15000000596046,
	max_rtt = 5.5920000076294,
	connection_uptime = 35007,
	max_jitter = 4.4359998703003,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-0db22e793-dirty",
	avg_rtt = 0.1630000025034,
	state = "Active",
	avg_jitter = 0.0020000040531158,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 4180\", \"3d_armor:leggings_nether 1 8360\", \"3d_armor:chestplate_nether 1 8360\", \"3d_armor:helmet_nether 1 4180\", \"nether_mobs:dragon_shield 1 4180\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		["petz:werewolf"] = "0",
		jointime = "1615351173",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "97.5",
		["signslib:pos"] = "(1274,70,546)",
		digged_nodes = "1078550",
		yl_commons_player_joined = "1658246790",
		yl_commons_thankyou = "130",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		played_time = "20068445",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:level"] = "12",
		xp = "1268676",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1355034",
		crafted = "38779",
		["petz:werewolf_clan_idx"] = "1",
		punch_count = "83136",
		died = "66",
		placed_nodes = "353055",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = Kl7We4xInijhNp1Z5tbvE6xsGFAg7UX2

Profiler save:

profile-20220720T034939.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 1d 16h 28min 57s | max lag: 4.22s | clients: Mia22, daydream, Cody, Rabbit1, digdeep, Perrier, icecreamkek, Service, AliasAlreadyTaken, Bailiff, rheo, AspireMint, flux, tontolava

Teleport command:

/teleport xyz 1266 48 596

Compass command:

/give_compass Construction Kl7We4xInijhNp1Z5tbvE6xsGFAg7UX2 D2691E 1266 48 596

flux reports a bug: > use big ingots (ingots.big = true in minetest.conf); we'll have to figure out a way to refund old piles tho Player position: ``` { y = 47.5, x = 1266.1340332031, z = 595.71496582031 } ``` Player look: ``` { y = -0.17605400085449, x = 0.98417174816132, z = -0.020271783694625 } ``` Player information: ``` { min_rtt = 0.15000000596046, max_rtt = 5.5920000076294, connection_uptime = 35007, max_jitter = 4.4359998703003, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-0db22e793-dirty", avg_rtt = 0.1630000025034, state = "Active", avg_jitter = 0.0020000040531158, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 4180\", \"3d_armor:leggings_nether 1 8360\", \"3d_armor:chestplate_nether 1 8360\", \"3d_armor:helmet_nether 1 4180\", \"nether_mobs:dragon_shield 1 4180\", \"\"}", ["petz:werewolf_vignette_id"] = "20", ["petz:werewolf"] = "0", jointime = "1615351173", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "97.5", ["signslib:pos"] = "(1274,70,546)", digged_nodes = "1078550", yl_commons_player_joined = "1658246790", yl_commons_thankyou = "130", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", played_time = "20068445", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:level"] = "12", xp = "1268676", arenalib_infobox_arenaID = "0", inflicted_damage = "1355034", crafted = "38779", ["petz:werewolf_clan_idx"] = "1", punch_count = "83136", died = "66", placed_nodes = "353055", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = Kl7We4xInijhNp1Z5tbvE6xsGFAg7UX2 ``` Profiler save: ``` profile-20220720T034939.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 1d 16h 28min 57s | max lag: 4.22s | clients: Mia22, daydream, Cody, Rabbit1, digdeep, Perrier, icecreamkek, Service, AliasAlreadyTaken, Bailiff, rheo, AspireMint, flux, tontolava ``` Teleport command: ``` /teleport xyz 1266 48 596 ``` Compass command: ``` /give_compass Construction Kl7We4xInijhNp1Z5tbvE6xsGFAg7UX2 D2691E 1266 48 596 ```

AliasAlreadyTaken was assigned by yourland-report

2022-07-20 01:49:39 +00:00

Bla commented

2022-07-20 06:55:01 +00:00

not familiar with that one, could you explain what the difference would be?

flux added the

1. kind/enhancement

label 2022-07-20 15:26:12 +00:00

flux commented

2022-07-20 15:28:03 +00:00

not familiar with that one, could you explain what the difference would be?

reduce the node count for ingot piles from 704 to 88

EDIT: seems like brass doesn't have an ingot pile, so this would be from 640 to 80 (or 88 if we add brass ingots piles)

> not familiar with that one, could you explain what the difference would be? reduce the node count for ingot piles from 704 to 88 EDIT: seems like brass doesn't have an ingot pile, so this would be from 640 to 80 (or 88 if we add brass ingots piles)

Bla commented

2022-07-20 15:32:33 +00:00

ah sounds good, ty

AliasAlreadyTaken commented

2022-08-05 05:03:43 +00:00

I'm an idiot that I hadn't thought of this before.

We could make an LBM that grabs the old block and places a protected chest instead which has nothing as content but the number of ingots this position had before, but meh. That's a stupid solution.

The big ingots even look better than the small ones IMO.

The setting is NOT in the minetest.conf, but in ingots/conf.lua

conf.is_big = true

I'm an idiot that I hadn't thought of this before. We *could* make an LBM that grabs the old block and places a protected chest instead which has nothing as content but the number of ingots this position had before, but meh. That's a stupid solution. The big ingots even look better than the small ones IMO. The setting is NOT in the minetest.conf, but in ingots/conf.lua conf.is_big = true

flux commented

2022-08-05 15:39:34 +00:00

We could make an LBM that grabs the old block and places a protected chest instead which has nothing as content but the number of ingots this position had before, but meh. That's a stupid solution.

that's one of my possible solutions, because it'd be easy to do.

the better solution would also be an LBM, which would transform stacks of > 8 ingots into a stack of 8, and store the number of "excess" ingots in metadata. players could remove the excess ingots by right-clicking. infotext (which displays in the HUD when you point at the node) could help users understand that their ingots haven't disappeared.

conf.is_big = true

oh, looks like i added the setting when i updated the mod for blocky:

0a37675992

> We *could* make an LBM that grabs the old block and places a protected chest instead which has nothing as content but the number of ingots this position had before, but meh. That's a stupid solution. that's one of my possible solutions, because it'd be easy to do. the better solution would also be an LBM, which would transform stacks of > 8 ingots into a stack of 8, and store the number of "excess" ingots in metadata. players could remove the excess ingots by right-clicking. infotext (which displays in the HUD when you point at the node) could help users understand that their ingots haven't disappeared. > conf.is_big = true oh, looks like i added the setting when i updated the mod for blocky: * https://github.com/BlockySurvival/ingots/commit/0a37675992985a740bab31e033570b7d84b6fd6c

flux commented

2022-08-05 15:42:53 +00:00

![](https://gitea.your-land.de/attachments/df3e0b61-d9dd-4d85-aad5-5b2cc55b4629) ![](https://gitea.your-land.de/attachments/5b07441a-77c3-4f7e-9e76-34af20c04598)

screenshot_20220805_083326.png

680 KiB

screenshot_20220805_084211.png

419 KiB

flux commented

2022-10-11 04:37:12 +00:00

The setting is NOT in the minetest.conf, but in ingots/conf.lua

conf.is_big = true

ah. i apparently forgot that i fixed that for blocky survival and not upstream: 0a37675992 (diff-d5faac49beea75d07295bef975287addbff4be76bcbe2899b94b6c781fd728c7)

> The setting is NOT in the minetest.conf, but in ingots/conf.lua > > conf.is_big = true ah. i apparently forgot that i fixed that for blocky survival and not upstream: https://github.com/Skamiz/ingots/commit/0a37675992985a740bab31e033570b7d84b6fd6c#diff-d5faac49beea75d07295bef975287addbff4be76bcbe2899b94b6c781fd728c7

flux commented

2022-10-11 04:38:45 +00:00

@AliasAlreadyTaken if you approve this, i can update the mod and provide an ABM in yl_commons (or yl_integration, if we ever get there) that will convert the old ingot stacks into protected chests.

👍 1

AliasAlreadyTaken added the

4. step/approved

label 2022-10-11 14:21:09 +00:00

flux added the

4. step/at work

label 2022-11-02 02:41:01 +00:00

flux commented

2022-11-02 02:56:12 +00:00

working on this. thought i'd knock it out in 30 minutes but i keep doofing it up.

flux commented

2022-11-02 17:41:59 +00:00

implemented

ingots commits: 28c96a9ca5 and 24d1c2f654

yl_commons commit: 125614b441

when the ingots mod is updated, and ingots.big = true in minetest.conf, then the routine in yl_commons will convert the ingots.

this is partially reversible - if ingots.big is turned off, ingot stacks of 1-8 ingots will turn back into small ingot piles, but larger stacks, which turn into yl_tools:protected_chests will remain as chests. if you think it's worth the effort, i could mark the chests w/ some node metadata and set up a system to revert those as well.

implemented ingots commits: https://gitea.your-land.de/your-land/ingots/commit/28c96a9ca521f0ffc2f708ea77a18f914eee95c0 and https://gitea.your-land.de/your-land/ingots/commit/24d1c2f6545e28fd6f6002a34d4ab4fd96702690 yl_commons commit: https://gitea.your-land.de/your-land/yl_commons/commit/125614b44145461ad377e9ca8474772ac1e5e6c0 when the ingots mod is updated, and `ingots.big = true` in minetest.conf, then the routine in yl_commons will convert the ingots. this is partially reversible - if `ingots.big` is turned off, ingot stacks of 1-8 ingots will turn back into small ingot piles, but larger stacks, which turn into `yl_tools:protected_chest`s will remain as chests. if you think it's worth the effort, i could mark the chests w/ some node metadata and set up a system to revert those as well.

flux added

4. step/ready to QA test

and removed

4. step/at work

labels 2022-11-02 17:42:09 +00:00

AliasAlreadyTaken referenced this issue

2022-11-02 21:36:29 +00:00

1.1.116 #2637

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-02 21:36:41 +00:00

AliasAlreadyTaken removed this from the 1.1.116 milestone 2022-11-08 10:56:08 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2022-11-08 10:56:14 +00:00

AliasAlreadyTaken commented

2022-11-08 10:59:34 +00:00

The normally placed protected chests (the red ones) can't be opened by non-area owners.

The generated with the ingots can be opened by everyone. Demonstration on the Haven main square testserver.

The normally placed protected chests (the red ones) can't be opened by non-area owners. The generated with the ingots can be opened by everyone. Demonstration on the Haven main square testserver.

flux commented

2022-11-08 14:51:17 +00:00

The generated with the ingots can be opened by everyone. Demonstration on the Haven main square testserver.

interesting, i don't have the yl_tools mod so i couldn't test this. i'll try to figure out what the difference is.

> The generated with the ingots can be opened by everyone. Demonstration on the Haven main square testserver. interesting, i don't have the yl_tools mod so i couldn't test this. i'll try to figure out what the difference is.

flux added

4. step/at work

and removed

4. step/ready to QA test

labels 2022-11-08 14:52:03 +00:00

flux added this to the flux's TODO list project 2022-11-08 14:52:08 +00:00

flux self-assigned this 2022-11-08 14:52:15 +00:00

AliasAlreadyTaken commented

2022-11-08 15:52:55 +00:00

That would be those: https://gitea.your-land.de/osmal/yl_tools

And guess what: There's no license. runs in circles, screaming

That would be those: https://gitea.your-land.de/osmal/yl_tools And guess what: There's no license. *runs in circles, screaming*

flux commented

2022-11-08 18:08:32 +00:00

current update is a93e97b9ff

in this update, the big 8-ingot stack has an inventory that can hold up to 56 ingots of the same type. anyone who could modify the ingot stack, can take/put nodes in the inventory. this also allows for full conversion of large ingots back to small ingots.

current update is https://gitea.your-land.de/your-land/yl_commons/commit/a93e97b9ffcf48ddd565b7d3bca1d3997594b46f in this update, the big 8-ingot stack has an inventory that can hold up to 56 ingots of the same type. anyone who could modify the ingot stack, can take/put nodes in the inventory. this also allows for full conversion of large ingots back to small ingots.

flux added

4. step/ready to QA test

and removed

4. step/at work

labels 2022-11-08 18:08:51 +00:00

AliasAlreadyTaken commented

2022-11-11 13:25:39 +00:00

Maybe its too specific, but wouldn't upstream also benefit from a conversion back and forth?

flux commented

2022-11-11 15:16:51 +00:00

Maybe its too specific, but wouldn't upstream also benefit from a conversion back and forth?

i thought about that, i can't remember why i decided against it. i'll PR them w/ the code and see what happens.

> Maybe its too specific, but wouldn't upstream also benefit from a conversion back and forth? i thought about that, i can't remember why i decided against it. i'll PR them w/ the code and see what happens.

AliasAlreadyTaken added the

3. source/mod upstream

label 2022-11-11 15:34:49 +00:00

flux commented

2022-11-11 17:19:25 +00:00

ah, the reason is that the mod is a mess and i don't want to spend the time to clean it up to integrate the patch properly.

👍 1

flux commented

2022-11-18 22:44:07 +00:00

@AliasAlreadyTaken i think the code is live, but you need to set conf.is_big = true in minetest.conf

@AliasAlreadyTaken i think the code is live, but you need to set `conf.is_big = true` in minetest.conf

flux added this to the 1.1.117 milestone 2022-11-18 22:44:21 +00:00

AliasAlreadyTaken commented

2022-11-23 06:46:06 +00:00

Will be in upon next restart.

flux commented

2022-11-24 02:59:22 +00:00

@AliasAlreadyTaken i hope you realized i meant ingots.big instead of conf.is_big. the latter is something weird my brain seems to have made up O_O

@AliasAlreadyTaken i hope you realized i meant `ingots.big` instead of `conf.is_big`. the latter is something weird my brain seems to have made up O_O

AliasAlreadyTaken commented

2022-11-24 17:02:16 +00:00

Of course! I totally put ingots.big instead of conf.is_big ... hahaha ... who would think conf.is_big is a valid setting?

sneaks off to change conf.is_big to ingots.big

Of course! I totally put ingots.big instead of conf.is_big ... hahaha ... who would think conf.is_big is a valid setting? *sneaks off to change conf.is_big to ingots.big*

AliasAlreadyTaken commented

2023-01-18 14:00:51 +00:00

When a player digs a pile of big ingots which has more ingots in its inventory, they only get the 8 big ingots, not the inventory.

Repro:

Do //load bugtracker2281 on the testserver
Don't have creative or give
Look inside, there should be 30 gold ingots inside
Use a pickaxe to dig the pile

Expected: The pile should not be diggable due to inventory OR you should have 38 ingots in your inventory

Is Wrong: You have 8 gold ingots in your inventory

When a player digs a pile of big ingots which has more ingots in its inventory, they only get the 8 big ingots, not the inventory. Repro: 1. Do `//load bugtracker2281` on the testserver 2. Don't have creative or give 3. Look inside, there should be 30 gold ingots inside 4. Use a pickaxe to dig the pile Expected: The pile should not be diggable due to inventory OR you should have 38 ingots in your inventory Is Wrong: You have 8 gold ingots in your inventory

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-01-18 14:00:58 +00:00

flux added the

2. prio/critical

label 2023-01-19 01:15:51 +00:00

flux commented

2023-01-19 01:38:18 +00:00

When a player digs a pile of big ingots which has more ingots in its inventory, they only get the 8 big ingots, not the inventory.

...

Expected: The pile should not be diggable due to inventory OR you should have 38 ingots in your inventory

w/ the following commit, they are undigable if they have inventory, and they'll drop the items if they are somehow destroyed.
faf5bf7757

> When a player digs a pile of big ingots which has more ingots in its inventory, they only get the 8 big ingots, not the inventory. > > ... > > Expected: The pile should not be diggable due to inventory OR you should have 38 ingots in your inventory w/ the following commit, they are undigable if they have inventory, and they'll drop the items if they are somehow destroyed. https://gitea.your-land.de/your-land/yl_commons/commit/faf5bf7757ee074b6643f698ce61ba8687cb5729

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-01-19 09:42:39 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-01-25 17:04:55 +00:00

flux removed this from the flux's TODO list project 2023-01-25 17:04:58 +00:00

AliasAlreadyTaken was unassigned by flux