your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

honey can be harvest from petz:beehive even if it is protected #22

New Issue
Closed
opened 2020-09-18 21:27:52 +00:00 by AliasAlreadyTaken · 13 comments
AliasAlreadyTaken commented 2020-09-18 21:27:52 +00:00
Owner
Copy Link

Reporter: ThinkSome

Reporter: ThinkSome
👍 1
AliasAlreadyTaken added the
1. kind/bug
 label 2020-09-19 22:48:45 +00:00
Skyisblue commented 2020-09-19 23:30:45 +00:00
Owner
Copy Link

Seems like we need locked beehives :P

Seems like we need locked beehives :P
AliasAlreadyTaken added the
3. source/mod upstream
3. source/integration
 labels 2020-09-20 20:19:50 +00:00
Skyisblue commented 2020-12-07 15:43:13 +00:00
Owner
Copy Link

Idk why but im actually fine with that.

Idk why but im actually fine with that.
Styxcolor added the
ugh/petz
 label 2021-11-16 17:00:26 +00:00
Styxcolor self-assigned this 2022-01-05 07:36:48 +00:00
Styxcolor added this to the (deleted) project 2022-01-05 07:36:50 +00:00
AliasAlreadyTaken was assigned by Styxcolor 2022-01-07 05:30:40 +00:00
Styxcolor commented 2022-01-07 05:31:23 +00:00
Owner
Copy Link

We will test ingame whether the issue still persist and if so try to reach out upstream.

We will test ingame whether the issue still persist and if so try to reach out upstream.
flux commented 2022-05-28 15:42:56 +00:00
Member
Copy Link

This still persists. Created an upstream issue: https://github.com/runsy/petz/issues/102

If runsy decides that this is intended, we could always add protection on the beehive ourselves if we choose, by overriding on_rightclick.

This still persists. Created an upstream issue: https://github.com/runsy/petz/issues/102 If runsy decides that this is intended, we could always add protection on the beehive ourselves if we choose, by overriding `on_rightclick`.
flux commented 2022-06-22 00:57:10 +00:00
Member
Copy Link

poked runsy on the upstream issue

poked runsy on the upstream issue
flux commented 2022-06-24 15:42:39 +00:00
Member
Copy Link

runsy implemented something: a47472e2fb (and 9115576ec7)

runsy implemented something: https://github.com/runsy/petz/commit/a47472e2fb56ed833ca3502aa1fdc758d44d3a4a (and https://github.com/runsy/petz/commit/9115576ec7cf869bb2e8c61d403661c0d37616c0)
AliasAlreadyTaken added this to the 1.1.115 milestone 2022-06-28 22:54:03 +00:00
flux added the
4. step/ready to QA test
 label 2022-07-02 17:48:45 +00:00
flux modified the project from (deleted) to flux's TODO list 2022-07-02 23:39:40 +00:00
flux commented 2022-08-31 00:13:52 +00:00
Member
Copy Link

The proper code is in place, but I forgot to enable the right setting.

Fixed that in 587ed99ec9

The proper code is in place, but I forgot to enable the right setting. Fixed that in https://gitea.your-land.de/your-land/petz/commit/587ed99ec9ee4b13cabe8ec2e31c776d63d0ca54
AliasAlreadyTaken modified the milestone from 1.1.115 to 1.1.116 2022-10-18 01:43:19 +00:00
AliasAlreadyTaken commented 2022-10-26 02:52:20 +00:00
Author
Owner
Copy Link

Now even as area owner, with areas priv or protection_bypass I can't harvest honey.

Is that a bug or does that only happen on existing beehives? On the testserver there's a beehive near 2188 23 1233 which has honey, but can't be accessed. There are several others in the public farm, but they don't have honey.

Now even as area owner, with areas priv or protection_bypass I can't harvest honey. Is that a bug or does that only happen on existing beehives? On the testserver there's a beehive near 2188 23 1233 which has honey, but can't be accessed. There are several others in the public farm, but they don't have honey.
flux commented 2022-10-26 02:59:52 +00:00
Member
Copy Link

Now even as area owner, with areas priv or protection_bypass I can't harvest honey.

using the metaphors i've used before, petz beehives have changed from being public to being private. you're asking that they be made protected, but not private.

i'm not sure i want to bother runs w/ refining this, he's mostly concerned w/ how petz work in single-player worlds, so far as i can tell. fixing this can be done w/ a generalized protection API, to allow easily switching between those 3 modes, which has been slowly been getting proposed in various issues.

> Now even as area owner, with areas priv or protection_bypass I can't harvest honey. using the metaphors i've used before, petz beehives have changed from being public to being private. you're asking that they be made protected, but not private. i'm not sure i want to bother runs w/ refining this, he's mostly concerned w/ how petz work in single-player worlds, so far as i can tell. fixing this can be done w/ a generalized protection API, to allow easily switching between those 3 modes, which has been slowly been getting proposed in various issues.
flux commented 2022-10-26 03:05:45 +00:00
Member
Copy Link

in the meantime, i don't think the issue is a big deal, whether the hive is public or private. the major problem is whether the person who placed the hive has a choice in how it is used.

in the meantime, i don't think the issue is a big deal, whether the hive is public or private. the major problem is whether the person who placed the hive has a choice in how it is used.
AliasAlreadyTaken commented 2022-10-27 04:45:39 +00:00
Author
Owner
Copy Link

your-land/administration#172

https://gitea.your-land.de/your-land/administration/issues/172
flux commented 2022-10-27 16:08:30 +00:00
Member
Copy Link

made the beehive protected (not private) in 3f43d5a95c, pending administration#172

made the beehive protected (not private) in https://gitea.your-land.de/your-land/yl_commons/commit/3f43d5a95cda1524d466becc3d25b05b7c49c5a7, pending administration#172
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2022-11-13 17:09:38 +00:00
flux removed this from the flux's TODO list project 2022-11-13 17:09:40 +00:00
Styxcolor was unassigned by flux 2022-11-13 17:09:42 +00:00
AliasAlreadyTaken was unassigned by flux 2022-11-13 17:09:42 +00:00
flux commented 2022-11-13 17:10:05 +00:00
Member
Copy Link

this is live

this is live
flux closed this issue 2022-11-13 17:10:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.116
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#22
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?