Hulda reports: Using the ESC key to throw awa ... #2161

New Issue

yourland-report · 2022-07-04T06:18:06+02:00

yourland-report commented

2022-07-04 06:18:06 +02:00

Hulda reports a bug:

Using the ESC key to throw away changes in the LUA editor is perhaps not the best key sequence. Users coming from Vi/Vim and other command mode editors typically hit ESC from habit to exit their mode and it can be quite frustrating when changes get discarded. Perhaps asking to save or revert would be a better choice?

Player position:

{
	y = -2344.4370117188,
	x = 1845.4580078125,
	z = 3149.7849121094
}

Player look:

{
	y = -0.84897166490555,
	x = -0.48180997371674,
	z = 0.21703964471817
}

Player information:

{
	min_rtt = 0.06700000166893,
	max_rtt = 8.9490003585815,
	connection_uptime = 4501,
	max_jitter = 8.8550004959106,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.079000003635883,
	state = "Active",
	avg_jitter = 0.0089999958872795,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"shields:shield_crystal 1 34720\", \"3d_armor:chestplate_crystal 1 27660\", \"3d_armor:boots_crystal 1 27660\", \"3d_armor:helmet_crystal 1 27660\", \"3d_armor:leggings_crystal 1 27660\", \"\"}",
		yl_commons_thankyou = "7",
		["ocean_build.ocean_built"] = "12",
		jointime = "1645489565",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "45.5",
		["signslib:pos"] = "(1846,-2350,3141)",
		["ocean_build.last_warning"] = "1.65605e+09",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		digged_nodes = "359262",
		punch_count = "11341",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -2349, [\"x\"] = 1881, [\"z\"] = 3158}, [\"last_death_portal\"] = 1656817726}",
		["ocean_build.forbidden"] = "true",
		["stamina:level"] = "17",
		xp = "305409",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "177866",
		crafted = "90409",
		yl_commons_player_joined = "1656903798",
		died = "161",
		played_time = "1251317",
		placed_nodes = "140037",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1645489565"
	}
}

Log identifier


[MOD] yl_report log identifier = Oxqfk4a0r26vi7SPtMqbEnlE6aKDzPWV

Profiler save:

profile-20220704T061806.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 10d 14h 57min 55s | max lag: 2.9s | clients: Thert, Lupercus, Queenfire234312, Hulda, Test_User, Woodman1234, evil123, Service, AliasAlreadyTaken, Bailiff, jackofthebean000, Nibsokube, flux, pitman

Teleport command:

/teleport xyz 1845 -2344 3150

Compass command:

/give_compass Construction Oxqfk4a0r26vi7SPtMqbEnlE6aKDzPWV D2691E 1845 -2344 3150

Hulda reports a bug: > Using the ESC key to throw away changes in the LUA editor is perhaps not the best key sequence. Users coming from Vi/Vim and other command mode editors typically hit ESC from habit to exit their mode and it can be quite frustrating when changes get discarded. Perhaps asking to save or revert would be a better choice? Player position: ``` { y = -2344.4370117188, x = 1845.4580078125, z = 3149.7849121094 } ``` Player look: ``` { y = -0.84897166490555, x = -0.48180997371674, z = 0.21703964471817 } ``` Player information: ``` { min_rtt = 0.06700000166893, max_rtt = 8.9490003585815, connection_uptime = 4501, max_jitter = 8.8550004959106, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.079000003635883, state = "Active", avg_jitter = 0.0089999958872795, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"shields:shield_crystal 1 34720\", \"3d_armor:chestplate_crystal 1 27660\", \"3d_armor:boots_crystal 1 27660\", \"3d_armor:helmet_crystal 1 27660\", \"3d_armor:leggings_crystal 1 27660\", \"\"}", yl_commons_thankyou = "7", ["ocean_build.ocean_built"] = "12", jointime = "1645489565", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "45.5", ["signslib:pos"] = "(1846,-2350,3141)", ["ocean_build.last_warning"] = "1.65605e+09", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", digged_nodes = "359262", punch_count = "11341", yl_church = "return {[\"last_death\"] = {[\"y\"] = -2349, [\"x\"] = 1881, [\"z\"] = 3158}, [\"last_death_portal\"] = 1656817726}", ["ocean_build.forbidden"] = "true", ["stamina:level"] = "17", xp = "305409", arenalib_infobox_arenaID = "0", inflicted_damage = "177866", crafted = "90409", yl_commons_player_joined = "1656903798", died = "161", played_time = "1251317", placed_nodes = "140037", hud_state = "on", repellant = "0", yl_commons_player_created = "1645489565" } } ``` Log identifier ``` [MOD] yl_report log identifier = Oxqfk4a0r26vi7SPtMqbEnlE6aKDzPWV ``` Profiler save: ``` profile-20220704T061806.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 10d 14h 57min 55s | max lag: 2.9s | clients: Thert, Lupercus, Queenfire234312, Hulda, Test_User, Woodman1234, evil123, Service, AliasAlreadyTaken, Bailiff, jackofthebean000, Nibsokube, flux, pitman ``` Teleport command: ``` /teleport xyz 1845 -2344 3150 ``` Compass command: ``` /give_compass Construction Oxqfk4a0r26vi7SPtMqbEnlE6aKDzPWV D2691E 1845 -2344 3150 ```

AliasAlreadyTaken was assigned by yourland-report

2022-07-04 06:18:06 +02:00

flux added the

1. kind/enhancement

label 2022-07-04 19:20:37 +02:00

flux commented

2022-07-04 19:23:18 +02:00

i'm not entirely sure how possible this is. for one, it'd have to be a per-formspec solution. and while it's possible to catch the "quit" command, i'm not sure it's possible to recover e.g. an email or luacontroller program that the player was composing. i'd love to implement this if possible, though, i've certainly esc-ed and lost emails/code many times.

i'm not entirely sure how possible this is. for one, it'd have to be a per-formspec solution. and while it's possible to catch the "quit" command, i'm not sure it's possible to recover e.g. an email or luacontroller program that the player was composing. i'd love to implement this if possible, though, i've certainly `esc`-ed and lost emails/code many times.

flux added this to the flux's TODO list project 2022-07-04 19:24:33 +02:00

flux added the

2. prio/interesting

label 2022-07-04 19:24:41 +02:00

AliasAlreadyTaken commented

2022-08-07 11:06:53 +02:00

Since MT lacks a full keyboard mapping, we're bound by what the engine gives us. Also, I'd rather not change a well-established routine to satisfy a workflow on a most likely lesser used editor.

nano rules!

Since MT lacks a full keyboard mapping, we're bound by what the engine gives us. Also, I'd rather not change a well-established routine to satisfy a workflow on a most likely lesser used editor. nano rules!

flux commented

2022-10-29 20:59:01 +02:00

i'm not entirely sure how possible this is.

did some testing. if you hit "escape" while typing an email or editing a luacontroller, all the server gets is

{
	quit = "true"
}

so this is technically impossible w/out updates to the client code.

> i'm not entirely sure how possible this is. did some testing. if you hit "escape" while typing an email or editing a luacontroller, all the server gets is ```lua { quit = "true" } ``` so this is technically impossible w/out updates to the client code.

flux added the

3. source/client

label 2022-10-29 20:59:21 +02:00

flux added the

4. step/blocked

label 2023-02-12 02:05:18 +01:00

flux removed this from the flux's TODO list project 2024-03-30 20:48:46 +01:00

AliasAlreadyTaken was unassigned by flux

2024-03-30 20:48:48 +01:00

tour commented

2025-04-17 16:01:16 +02:00

The engine got an update. It should be possible now: https://github.com/luanti-org/luanti/pull/15971

👍 1

whosit commented

2025-04-17 16:05:56 +02:00

Noting here that to escape an unescapable formspec you can press shift+ESC X)
And new formspec is called allow_close[] (for gitea search)

UPD: (they changed it from ctrl to shift)

Noting here that to escape an unescapable formspec you can press `shift+ESC` X) And new formspec is called `allow_close[]` (for gitea search) UPD: (they changed it from ctrl to shift)

😆 2

Sign in to join this conversation.