HP bar doesn't disappear when Service account is invisible #2042

New Issue

flux · 2022-06-07T15:36:49Z

flux commented

2022-06-07 15:36:49 +00:00

As mentioned in a comment in #91, the HP bar from the gauges mod doesn't disappear when a player becomes invisible. The solution for this is a proper API for invisibility, with "on_vanish" and "on_appear" callbacks, as well as some other goodies I've got in mind (like a generalized mechanism for un-vanishing players, as done by the evoker, balrog, and in the nether).

Dependent mods:

mobs_balrog
mobs_redo
yl_commons
yl_crafts
yl_nether
yl_nether_mobs

Mods which should get a dependency:

gauges

As mentioned in a comment in #91, the HP bar from the `gauges` mod doesn't disappear when a player becomes invisible. The solution for this is a proper API for invisibility, with "on_vanish" and "on_appear" callbacks, as well as some other goodies I've got in mind (like a generalized mechanism for un-vanishing players, as done by the evoker, balrog, and in the nether). Dependent mods: * [ ] mobs_balrog * [ ] mobs_redo * [ ] yl_commons * [ ] yl_crafts * [ ] yl_nether * [ ] yl_nether_mobs Mods which should get a dependency: * [ ] gauges

flux added the

1. kind/enhancement

label 2022-06-07 15:37:03 +00:00

flux commented

2022-06-07 15:39:55 +00:00

@AliasAlreadyTaken one outstanding question I have is, should a player's model disappear when they drink an invisibility potion? The code currently implies that this should happen, but it clearly does not, and I'm not sure why. The last time I started cleaning up the code, it magically started happening, and I had to undo most of what I did in order to not create a surprising new ability.

@AliasAlreadyTaken one outstanding question I have is, should a player's model disappear when they drink an invisibility potion? The code currently implies that this *should* happen, but it clearly does not, and I'm not sure why. The last time I started cleaning up the code, it magically started happening, and I had to undo most of what I did in order to not create a surprising new ability.

flux added the

4. step/question

4. step/want approval

labels 2022-06-07 15:40:10 +00:00

flux commented

2022-06-07 15:44:35 +00:00

Also, the mechanism used to make the player "vanish" is to set the size of their player model to 0, which I think would make them unhitable by other players, which would make for a nasty confound for PvP...

flux self-assigned this 2022-06-07 15:57:28 +00:00

flux referenced this issue

2022-06-07 18:16:05 +00:00

rheo reports: staff can't stay invisible in ... #2040

flux commented

2022-06-07 22:40:46 +00:00

hm. perhaps instead of a rewrite of invisibility itself, it should be worked into yl_statuseffects, which i could flesh out the API for in the process (see your-land/administration#63).

hm. perhaps instead of a rewrite of invisibility itself, it should be worked into [yl_statuseffects](https://gitea.your-land.de/your-land/yl_statuseffects), which i could flesh out the API for in the process (see https://gitea.your-land.de/your-land/administration/issues/63).

AliasAlreadyTaken commented

2022-06-08 11:13:31 +00:00

The current invisibility mod will need to go anyway, once we do 1.4 classes and abilities

Statuseffects seems a much more appropriate place. maybe all statuseffects need a callback when they are applied and when they go away.

The current invisibility mod will need to go anyway, once we do 1.4 classes and abilities Statuseffects seems a much more appropriate place. maybe all statuseffects need a callback when they are applied and when they go away.

flux commented

2022-06-08 15:26:09 +00:00

I'm going to sit on this one for a while, because it'll require a number of changes to unexposed behavior in mobs_redo, and would make it hard to merge any other upstream fixes. perhaps this should wait until we've ported all our mobs to a more reasonable underlying API, it doesn't seem worth the potential problems to just get rid of Service's HP bar.

flux added this to the flux's TODO list project 2022-07-02 22:08:10 +00:00

flux added a new dependency 2022-10-28 20:37:34 +00:00

your-land/administration#63 - MOD Statuseffects

Sign in to join this conversation.