petz crash #2038

Closed
opened 2022-06-06 21:34:35 +00:00 by flux · 6 comments
Member
  1. spawn in a wagon through the creative inventory
  2. place the wagon
  3. punch the wagon

tested locally and on the test server

2022-06-06 14:30:17: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'petz' in callback luaentity_Punch(): ...n/../worl
ds/your-land/worldmods/petz/petz/misc/wagon.lua:17: attempt to perform arithmetic on local 'damage' (a nil value)
2022-06-06 14:30:17: ERROR[Main]: stack traceback:
2022-06-06 14:30:17: ERROR[Main]:       ...n/../worlds/your-land/worldmods/petz/petz/misc/wagon.lua:17: in function 'func'
2022-06-06 14:30:17: ERROR[Main]:       /opt/minetest/bin/../builtin/profiler/instrumentation.lua:107: in function </opt/minetest/bin/.
./builtin/profiler/instrumentation.lua:100>
1. spawn in a wagon through the creative inventory 2. place the wagon 3. punch the wagon tested locally and on the test server ``` 2022-06-06 14:30:17: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'petz' in callback luaentity_Punch(): ...n/../worl ds/your-land/worldmods/petz/petz/misc/wagon.lua:17: attempt to perform arithmetic on local 'damage' (a nil value) 2022-06-06 14:30:17: ERROR[Main]: stack traceback: 2022-06-06 14:30:17: ERROR[Main]: ...n/../worlds/your-land/worldmods/petz/petz/misc/wagon.lua:17: in function 'func' 2022-06-06 14:30:17: ERROR[Main]: /opt/minetest/bin/../builtin/profiler/instrumentation.lua:107: in function </opt/minetest/bin/. ./builtin/profiler/instrumentation.lua:100> ```
flux added the
1. kind/bug
2. prio/critical
labels 2022-06-06 21:36:37 +00:00
Author
Member

seems to work w/ crafted wagons as well

seems to work w/ crafted wagons as well
Author
Member

can't reproduce in a simple world w/ only petz and default... hm.

can't reproduce in a simple world w/ only petz and default... hm.
Author
Member

Definitely due to something in yl_commons...

Definitely due to something in yl_commons...
Author
Member

problem was i wasn't passing a necessary value in the carts redo code.

fixed in be4fc9e96e

problem was i wasn't passing a necessary value in the carts redo code. fixed in https://gitea.your-land.de/your-land/yl_commons/commit/be4fc9e96e0adcace3c84ad2ea91c953b353970a
flux added the
4. step/ready to QA test
label 2022-06-06 22:04:22 +00:00
Author
Member

now back to seeing how else i can get the deployer/node breaker to crash things...

now back to seeing how else i can get the deployer/node breaker to crash things...
AliasAlreadyTaken added this to the 1.1.112 milestone 2022-06-07 05:32:30 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2022-06-07 17:13:16 +00:00
Author
Member

this is live

this is live
flux closed this issue 2022-06-07 17:13:21 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2038
No description provided.