JeCel reports: Could we have a one or two mor ... #2010

New Issue

yourland-report · 2022-05-30T21:49:47Z

yourland-report commented

2022-05-30 21:49:47 +00:00

JeCel reports a bug:

Could we have a one or two more textures options for the bookshelves? Right now it looks really repetitive having a lots of them next to each other.

Player position:

{
	y = -31.498998641968,
	x = 6643.3759765625,
	z = 10393.674804688
}

Player look:

{
	y = -0.56078350543976,
	x = 0.71847730875015,
	z = 0.41147562861443
}

Player information:

{
	min_rtt = 0.027000000700355,
	max_rtt = 0.20999999344349,
	connection_uptime = 295,
	max_jitter = 0.12000000476837,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.029999999329448,
	state = "Active",
	avg_jitter = 0.0010000001639128,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 17080\", \"3d_armor:chestplate_crystal 1 17080\", \"3d_armor:leggings_crystal 1 17080\", \"3d_armor:boots_crystal 1 17080\", \"shields:shield_crystal 1 17080\", \"\"}",
		played_time = "1297443",
		["ocean_build.ocean_built"] = "6",
		jointime = "1621787993",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "158",
		["signslib:pos"] = "(6499,-22,10369)",
		digged_nodes = "562973",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "main",
		xp = "852565",
		yl_commons_thankyou = "23",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29660, [\"x\"] = 1970, [\"z\"] = 1577}}",
		died = "17",
		["stamina:level"] = "10",
		punch_count = "12578",
		arenalib_infobox_arenaID = "0",
		xp_redo_hud_color = "0x99ffff",
		crafted = "221794",
		yl_commons_player_joined = "1653947114",
		["ocean_build.last_warning"] = "1.65313e+09",
		inflicted_damage = "230240",
		placed_nodes = "118628",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621787993"
	}
}

Log identifier


[MOD] yl_report log identifier = GAK3TDfon1NG8ecV8l36b2qYGoT8k1In

Profiler save:

profile-20220530T234947.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 6h 23min 33s | max lag: 6.13s | clients: MicaelStarfire, HorusDamocles, alexandre2005, Lupercus, darealbang, Lucien, jackofthebean000, Gardenfire2007, Nibsokube, Jamelpro, Lucien_II, ourland, pitman, Zizis, GrimPixel, Service, Empempires, Bailiff, shanish2, JeCel, flux, AliasAlreadyTaken, kinzie225, Alex1977, aymane

Teleport command:

/teleport xyz 6643 -31 10394

Compass command:

/give_compass Construction GAK3TDfon1NG8ecV8l36b2qYGoT8k1In D2691E 6643 -31 10394

JeCel reports a bug: > Could we have a one or two more textures options for the bookshelves? Right now it looks really repetitive having a lots of them next to each other. Player position: ``` { y = -31.498998641968, x = 6643.3759765625, z = 10393.674804688 } ``` Player look: ``` { y = -0.56078350543976, x = 0.71847730875015, z = 0.41147562861443 } ``` Player information: ``` { min_rtt = 0.027000000700355, max_rtt = 0.20999999344349, connection_uptime = 295, max_jitter = 0.12000000476837, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.029999999329448, state = "Active", avg_jitter = 0.0010000001639128, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 17080\", \"3d_armor:chestplate_crystal 1 17080\", \"3d_armor:leggings_crystal 1 17080\", \"3d_armor:boots_crystal 1 17080\", \"shields:shield_crystal 1 17080\", \"\"}", played_time = "1297443", ["ocean_build.ocean_built"] = "6", jointime = "1621787993", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "158", ["signslib:pos"] = "(6499,-22,10369)", digged_nodes = "562973", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "main", xp = "852565", yl_commons_thankyou = "23", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29660, [\"x\"] = 1970, [\"z\"] = 1577}}", died = "17", ["stamina:level"] = "10", punch_count = "12578", arenalib_infobox_arenaID = "0", xp_redo_hud_color = "0x99ffff", crafted = "221794", yl_commons_player_joined = "1653947114", ["ocean_build.last_warning"] = "1.65313e+09", inflicted_damage = "230240", placed_nodes = "118628", hud_state = "on", repellant = "0", yl_commons_player_created = "1621787993" } } ``` Log identifier ``` [MOD] yl_report log identifier = GAK3TDfon1NG8ecV8l36b2qYGoT8k1In ``` Profiler save: ``` profile-20220530T234947.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 6h 23min 33s | max lag: 6.13s | clients: MicaelStarfire, HorusDamocles, alexandre2005, Lupercus, darealbang, Lucien, jackofthebean000, Gardenfire2007, Nibsokube, Jamelpro, Lucien_II, ourland, pitman, Zizis, GrimPixel, Service, Empempires, Bailiff, shanish2, JeCel, flux, AliasAlreadyTaken, kinzie225, Alex1977, aymane ``` Teleport command: ``` /teleport xyz 6643 -31 10394 ``` Compass command: ``` /give_compass Construction GAK3TDfon1NG8ecV8l36b2qYGoT8k1In D2691E 6643 -31 10394 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2022-05-30 21:49:47 +00:00

flux added the

1. kind/enhancement

label 2022-05-30 22:58:52 +00:00

flux commented

2022-05-30 23:08:27 +00:00

I found https://github.com/v-rob/library which looks cool:

I found https://github.com/v-rob/library which looks cool: ![](https://gitea.your-land.de/attachments/b9aab940-6168-4abf-8bb4-481d88dc39df)

screenshot_20220530_160738.png

754 KiB

JeCel commented

2022-05-31 00:36:35 +00:00

Wow, that really looks amazing! Only the color of the wood seems a bit off to me, but I guess that's no big deal or could easily be changed.

Question though would be then, which of those also would be library bookshelves? Because of all the maximum block amount talk. I'd guess the set wouldn't be wanted twice because of that?

Wow, that really looks amazing! Only the color of the wood seems a bit off to me, but I guess that's no big deal or could easily be changed. Question though would be then, which of those also would be library bookshelves? Because of all the maximum block amount talk. I'd guess the set wouldn't be wanted twice because of that?

flux commented

2022-05-31 00:41:26 +00:00

The mod adds 23 new nodes. I think that's likely to get approved?

flux commented

2022-05-31 01:08:02 +00:00

Only the color of the wood seems a bit off to me, but I guess that's no big deal or could easily be changed.

It's the default_wood.png texture, same as the wood in the background. Which is what the current bookshelves use? I assume you'd want them to match?

> Only the color of the wood seems a bit off to me, but I guess that's no big deal or could easily be changed. It's the `default_wood.png` texture, same as the wood in the background. Which is what the current bookshelves use? I assume you'd want them to match?

flux commented

2022-05-31 01:39:47 +00:00

There's actually only 17 unique bookshelves, the others are superfluous. Since the mod is "WIP" from 4 years ago, I think we can assume it's abandoned, and change it as we see fit.

There's 4 identical "empty" bookshelves (because the mod creator seems to have thought that was easier than implementing weighted choice), a "card catalog" (who's formspec feels like useless garbage), and two "corner" nodes which are redundant w/ wood cut in the circular saw.

There's also 7 new colored book variants, though these can't be placed as nodes.

A lot of the variants have 1 shared crafting recipe and turn into a random variant (1 of 2 to 6) when placed, and while this is a neat mechanic, I feel like we should alter this somehow to give players more control (e.g. create a cycle of crafting recipes for the variants).

Here's a depiction of the 17 unique nodes, with 2 default:bookshelf to the far left.

There's actually only 17 unique bookshelves, the others are superfluous. Since the mod is "WIP" from 4 years ago, I think we can assume it's abandoned, and change it as we see fit. There's 4 identical "empty" bookshelves (because the mod creator seems to have thought that was easier than implementing weighted choice), a "card catalog" (who's formspec feels like useless garbage), and two "corner" nodes which are redundant w/ wood cut in the circular saw. There's also 7 new colored book variants, though these can't be placed as nodes. A lot of the variants have 1 shared crafting recipe and turn into a random variant (1 of 2 to 6) when placed, and while this is a neat mechanic, I feel like we should alter this somehow to give players more control (e.g. create a cycle of crafting recipes for the variants). Here's a depiction of the 17 unique nodes, with 2 default:bookshelf to the far left. ![](https://gitea.your-land.de/attachments/5347729b-d55e-4feb-9494-5d17d03338cd)

screenshot_20220530_182923.png

983 KiB

JeCel commented

2022-06-02 00:43:50 +00:00

Only the color of the wood seems a bit off to me, but I guess that's no big deal or could easily be changed.

It's the default_wood.png texture, same as the wood in the background. Which is what the current bookshelves use? I assume you'd want them to match?

Yes, I just thought it looked darker, but that was because of my phone screen apparently.

A lot of the variants have 1 shared crafting recipe and turn into a random variant (1 of 2 to 6) when placed, and while this is a neat mechanic, I feel like we should alter this somehow to give players more control (e.g. create a cycle of crafting recipes for the variants).

Maybe it could be done like Sokomine did with her Cottage Barrels? If I remember correctly they change rotation when left clicking on them. Maybe one could make it so, that the texture changes instead on left click?
Or an extra tool, something like the chisle for the jonez marble. That extra tool could just be a book, so that it's as if you would rearange the books in the shelf by left clicking (or right? Don't know right now, which one is used, to open a book) it.

> > Only the color of the wood seems a bit off to me, but I guess that's no big deal or could easily be changed. > > It's the `default_wood.png` texture, same as the wood in the background. Which is what the current bookshelves use? I assume you'd want them to match? Yes, I just thought it looked darker, but that was because of my phone screen apparently. > A lot of the variants have 1 shared crafting recipe and turn into a random variant (1 of 2 to 6) when placed, and while this is a neat mechanic, I feel like we should alter this somehow to give players more control (e.g. create a cycle of crafting recipes for the variants). Maybe it could be done like Sokomine did with her Cottage Barrels? If I remember correctly they change rotation when left clicking on them. Maybe one could make it so, that the texture changes instead on left click? Or an extra tool, something like the chisle for the jonez marble. That extra tool could just be a book, so that it's as if you would rearange the books in the shelf by left clicking (or right? Don't know right now, which one is used, to open a book) it.

flux commented

2022-06-02 01:15:07 +00:00

Maybe it could be done like Sokomine did with her Cottage Barrels? If I remember correctly they change rotation when left clicking on them. Maybe one could make it so, that the texture changes instead on left click?

Honestly, it would make more sense here than for the cottages barrel. In my (unfinished) cottages rewrite, you just use the screwdriver/rhotator. Also, such a mechanic creates a problem - who should be able to change the texture of a bookshelf? The person who placed it? Anyone in the protection area? How do you prevent accidental changes?

Or an extra tool, something like the chisel for the jonez marble. That extra tool could just be a book, so that it's as if you would rearange the books in the shelf by left clicking (or right? Don't know right now, which one is used, to open a book) it.

As someone who uses jonez extensively, I dislike the chisel mechanic. I'd prefer something that worked like the moreblocks circular saw.

> Maybe it could be done like Sokomine did with her Cottage Barrels? If I remember correctly they change rotation when left clicking on them. Maybe one could make it so, that the texture changes instead on left click? Honestly, it would make more sense here than for the cottages barrel. In my (unfinished) cottages rewrite, you just use the screwdriver/rhotator. Also, such a mechanic creates a problem - who should be able to change the texture of a bookshelf? The person who placed it? Anyone in the protection area? How do you prevent accidental changes? > Or an extra tool, something like the chisel for the jonez marble. That extra tool could just be a book, so that it's as if you would rearange the books in the shelf by left clicking (or right? Don't know right now, which one is used, to open a book) it. As someone who uses jonez extensively, I dislike the chisel mechanic. I'd prefer something that worked like the moreblocks circular saw.

flux added this to the flux's TODO list project 2022-07-02 22:04:21 +00:00

flux commented

2022-07-14 04:16:58 +00:00

@AliasAlreadyTaken i'd love to have these. omitting the empty shelves w/out spiderwebs seems totally reasonable (we've already got one empty shelf node), without those it's just 15 new nodes.

flux added the

1. kind/node limit

label 2022-09-11 00:22:32 +00:00

flux added the

4. step/ready to QA test

label 2022-09-13 18:06:14 +00:00

flux commented

2022-09-13 18:08:49 +00:00

added the bookshelves w/ recipes in 09443c3936

added the bookshelves w/ recipes in https://gitea.your-land.de/your-land/yl_commons/commit/09443c3936b9555ec5194a55f10893147cd9cbb6

👍 2

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-09-13 19:03:10 +00:00