Giuseppe reports: tomato:farming and tomato:cuci ... #1964

New Issue

yourland-report · 2022-05-22T16:10:31Z

yourland-report commented

2022-05-22 16:10:31 +00:00

Giuseppe reports a bug:

tomato:farming and tomato:cucina_vegana should have same recipes for example canned tomato is possible only with tomato:farming; same with sunflowers for example sunflowers oil is possible only with seeds of cucina vegana

Player position:

{
	y = 21.5,
	x = 1991.4810791016,
	z = 1514.791015625
}

Player look:

{
	y = -0.34349578619003,
	x = 0.45201021432877,
	z = -0.82322376966476
}

Player information:

{
	min_rtt = 0.046999998390675,
	max_rtt = 28.20599937439,
	connection_uptime = 5864,
	max_jitter = 13.235999107361,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "it",
	version_string = "5.5.0",
	avg_rtt = 0.072999998927116,
	state = "Active",
	avg_jitter = 0.0020000040531158,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 3080\", \"3d_armor:chestplate_rainbow 1 3080\", \"3d_armor:leggings_rainbow 1 3080\", \"3d_armor:boots_crystal 1 7700\", \"\", \"shields:shield_rainbow 1 3080\"}",
		yl_commons_thankyou = "25",
		["ocean_build.ocean_built"] = "12",
		jointime = "1638020000",
		yl_commons_player_joined = "1653229997",
		["stamina:exhaustion"] = "94.5",
		["signslib:pos"] = "(1990,23,1529)",
		digged_nodes = "788527",
		["stamina:poisoned"] = "no",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "main",
		placed_nodes = "159469",
		["ocean_build.last_warning"] = "1.65259e+09",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -1148, [\"x\"] = 2174, [\"z\"] = 1507}, [\"last_death_portal\"] = 1653068868}",
		["ocean_build.forbidden"] = "true",
		["stamina:level"] = "12",
		xp = "861005",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1225734",
		crafted = "5588",
		played_time = "2884234",
		punch_count = "65702",
		xp_redo_hud_color = "0xaaaaaa",
		died = "167",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1638020000"
	}
}

Log identifier


[MOD] yl_report log identifier = CdwKp41DPMXM4Q6ESa8TYOcXoF8JqsGx

Profiler save:

profile-20220522T181030.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 1d 1h 33min 1s | max lag: 6.69s | clients: rohit, dweek, randomboredperson, slayer, debian44, LZXTVhCSVlr, celestial, RostbarschUmbto, Woldar, Unelias, EvilRevised, upie, Secret_Human, shanish2, pitman, Prius, Bla, Service, AliasAlreadyTaken, Alex1977, Giuseppe, Bastet, kinzie225, alexandre2005, Boot, Aleks555, darealbang, Bailiff, flux

Teleport command:

/teleport xyz 1991 22 1515

Compass command:

/give_compass Construction CdwKp41DPMXM4Q6ESa8TYOcXoF8JqsGx D2691E 1991 22 1515

Giuseppe reports a bug: > tomato:farming and tomato:cucina_vegana should have same recipes for example canned tomato is possible only with tomato:farming; same with sunflowers for example sunflowers oil is possible only with seeds of cucina vegana Player position: ``` { y = 21.5, x = 1991.4810791016, z = 1514.791015625 } ``` Player look: ``` { y = -0.34349578619003, x = 0.45201021432877, z = -0.82322376966476 } ``` Player information: ``` { min_rtt = 0.046999998390675, max_rtt = 28.20599937439, connection_uptime = 5864, max_jitter = 13.235999107361, minor = 5, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "it", version_string = "5.5.0", avg_rtt = 0.072999998927116, state = "Active", avg_jitter = 0.0020000040531158, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 3080\", \"3d_armor:chestplate_rainbow 1 3080\", \"3d_armor:leggings_rainbow 1 3080\", \"3d_armor:boots_crystal 1 7700\", \"\", \"shields:shield_rainbow 1 3080\"}", yl_commons_thankyou = "25", ["ocean_build.ocean_built"] = "12", jointime = "1638020000", yl_commons_player_joined = "1653229997", ["stamina:exhaustion"] = "94.5", ["signslib:pos"] = "(1990,23,1529)", digged_nodes = "788527", ["stamina:poisoned"] = "no", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "main", placed_nodes = "159469", ["ocean_build.last_warning"] = "1.65259e+09", yl_church = "return {[\"last_death\"] = {[\"y\"] = -1148, [\"x\"] = 2174, [\"z\"] = 1507}, [\"last_death_portal\"] = 1653068868}", ["ocean_build.forbidden"] = "true", ["stamina:level"] = "12", xp = "861005", arenalib_infobox_arenaID = "0", inflicted_damage = "1225734", crafted = "5588", played_time = "2884234", punch_count = "65702", xp_redo_hud_color = "0xaaaaaa", died = "167", hud_state = "on", repellant = "0", yl_commons_player_created = "1638020000" } } ``` Log identifier ``` [MOD] yl_report log identifier = CdwKp41DPMXM4Q6ESa8TYOcXoF8JqsGx ``` Profiler save: ``` profile-20220522T181030.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 1d 1h 33min 1s | max lag: 6.69s | clients: rohit, dweek, randomboredperson, slayer, debian44, LZXTVhCSVlr, celestial, RostbarschUmbto, Woldar, Unelias, EvilRevised, upie, Secret_Human, shanish2, pitman, Prius, Bla, Service, AliasAlreadyTaken, Alex1977, Giuseppe, Bastet, kinzie225, alexandre2005, Boot, Aleks555, darealbang, Bailiff, flux ``` Teleport command: ``` /teleport xyz 1991 22 1515 ``` Compass command: ``` /give_compass Construction CdwKp41DPMXM4Q6ESa8TYOcXoF8JqsGx D2691E 1991 22 1515 ```

AliasAlreadyTaken was assigned by yourland-report

2022-05-22 16:10:31 +00:00

flux added the

1. kind/enhancement

label 2022-05-22 16:31:22 +00:00

flux commented

2022-05-22 16:32:56 +00:00

Given that cucina vegana depends on farming, i have no idea why they added their own version of several vegetables O_O.

EDIT: oh right, because there's a "farming" mod in minetest_game that only has cotton and wheat...

Given that cucina vegana *depends on farming*, i have no idea why they added their own version of several vegetables O_O. EDIT: oh right, because there's a "farming" mod in minetest_game that only has cotton and wheat...

mrminer commented

2022-05-25 18:38:47 +00:00

Hmm. Gona look into that.

flux commented

2022-05-25 21:53:42 +00:00

Actually, it has explicit code for compatibility w/ both farming_redo and mtg's farming. I'm still of the opinion that redundant crop items should be aliased to a single variant, but that got voted down last time. I'll add the new CV veg to the appropriate groups and update the relevant recipes.

Actually, it has *explicit* code for compatibility w/ both farming_redo and mtg's farming. I'm still of the opinion that redundant crop items should be aliased to a single variant, but that got voted down last time. I'll add the new CV veg to the appropriate groups and update the relevant recipes.

👍 1

flux added the

3. source/integration

4. step/at work

labels 2022-05-25 21:54:04 +00:00

flux commented

2022-05-26 04:04:06 +00:00

My attempt to fix this turned into a major cleanup effort of yl_commons, which isn't quite done yet. I found it really troublesome to understand where/what to change in that mod, and decided to inflict some order onto it.

My attempt to fix this turned into a major cleanup effort of `yl_commons`, which isn't quite done yet. I found it really troublesome to understand where/what to change in that mod, and decided to inflict some order onto it.

flux commented

2022-05-27 19:43:45 +00:00

Fixed in c68e10883b

Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/c68e10883b59e1aa5106fc0365af6794d26ddaf2

flux added

4. step/ready to QA test

and removed

4. step/at work

labels 2022-05-27 19:43:55 +00:00

flux self-assigned this 2022-05-27 19:44:01 +00:00

AliasAlreadyTaken added this to the 1.1.112 milestone 2022-05-28 12:46:49 +00:00

flux added