your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

crash due to /list_areas #1869

New Issue
Closed
opened 2022-05-02 22:48:20 +00:00 by flux · 4 comments
flux commented 2022-05-02 22:48:20 +00:00
Member
Copy Link

oh, this is the version of the areas mod where it tries to concatenate the info about every area on the server into a single string and runs out of memory.

94faafcada/chatcommands.lua (L175-L190)

we fixed this on blocky:

927b7324a7

i'll submit a similar PR to our fork

oh, this is the version of the areas mod where it tries to concatenate the info about *every area on the server* into a *single string* and runs out of memory. https://gitea.your-land.de/your-land/areas/src/commit/94faafcada3544c1b4d60b3bf8132b59f3677a6a/chatcommands.lua#L175-L190 we fixed this on blocky: https://github.com/BlockySurvival/areas/commit/927b7324a71a3b759b661e97f8884541c9e71fe0 i'll submit a similar PR to our fork
flux added the
1. kind/bug
2. prio/critical
 labels 2022-05-02 23:13:35 +00:00
flux commented 2022-05-02 23:27:47 +00:00
Author
Member
Copy Link

fix @ your-land/areas#2

fix @ https://gitea.your-land.de/your-land/areas/pulls/2
AliasAlreadyTaken commented 2022-05-03 04:58:22 +00:00
Owner
Copy Link

2022-05-03 00:40:41: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_chat_message(): String too long
2022-05-03 00:40:41: ERROR[Main]: stack traceback:
2022-05-03 00:40:41: ERROR[Main]: [C]: in function 'chat_send_player'
2022-05-03 00:40:41: ERROR[Main]: .../mtlive/5.5.0/Minetest_live/bin/../builtin/game/chat.lua:103: in function 'func'
2022-05-03 00:40:41: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
2022-05-03 00:40:41: ERROR[Main]: ...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:425: in function <...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:409>

2022-05-03 00:40:41: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_chat_message(): String too long 2022-05-03 00:40:41: ERROR[Main]: stack traceback: 2022-05-03 00:40:41: ERROR[Main]: [C]: in function 'chat_send_player' 2022-05-03 00:40:41: ERROR[Main]: .../mtlive/5.5.0/Minetest_live/bin/../builtin/game/chat.lua:103: in function 'func' 2022-05-03 00:40:41: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> 2022-05-03 00:40:41: ERROR[Main]: ...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:425: in function <...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:409>
AliasAlreadyTaken commented 2022-05-03 06:47:02 +00:00
Owner
Copy Link

IMO this should be solved in the engine. Here's the upstream bugs.

https://github.com/minetest/minetest/issues/10246

https://github.com/minetest/minetest/issues/10246

I pulled the PR regardless, because it does help to solve the immediate problem.

IMO this should be solved in the engine. Here's the upstream bugs. https://github.com/minetest/minetest/issues/10246 https://github.com/minetest/minetest/issues/10246 I pulled the PR regardless, because it does help to solve the immediate problem.
AliasAlreadyTaken added this to the 1.1.110 milestone 2022-05-03 06:47:08 +00:00
AliasAlreadyTaken added the
3. source/mod upstream
 label 2022-05-03 06:50:24 +00:00
flux commented 2022-05-03 19:27:55 +00:00
Author
Member
Copy Link

Seems the open upstream issue is https://github.com/minetest/minetest/issues/9326

Seems the open upstream issue is https://github.com/minetest/minetest/issues/9326
👍 1
AliasAlreadyTaken added the
5. result/fixed
 label 2022-05-04 18:01:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.110
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1869
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?