Freebie reports: How to change the leader of th ... #1755

New Issue

yourland-report · 2022-04-14T18:32:42Z

yourland-report commented

2022-04-14 18:32:42 +00:00

Freebie reports a bug:

How to change the leader of the party from one to another, both agrees?

Player position:

{
	y = -12.498999595642,
	x = 5984.046875,
	z = 2968.1989746094
}

Player look:

{
	y = -0.14763678610325,
	x = -0.7465523481369,
	z = -0.64873945713043
}

Player information:

{
	min_rtt = 0.010999999940395,
	max_rtt = 0.25,
	connection_uptime = 1597,
	max_jitter = 0.23199999332428,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "de",
	version_string = "5.5.0",
	avg_rtt = 0.01799999922514,
	state = "Active",
	avg_jitter = 0.0080000013113022,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 13600\", \"3d_armor:leggings_crystal 1 13600\", \"shields:shield_crystal 1 13600\", \"3d_armor:boots_crystal 1 13600\", \"3d_armor:helmet_crystal 1 13600\", \"\"}",
		played_time = "1526",
		["stamina:level"] = "12",
		arenalib_infobox_arenaID = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "83",
		jointime = "1649959597",
		hud_state = "on",
		yl_commons_player_joined = "1649959598",
		bitten = "0",
		repellant = "0",
		yl_commons_player_created = "1649959597"
	}
}

Log identifier


[MOD] yl_report log identifier = TSBSZQQqnMR2riIihVAWiYutDpID2uhk

Profiler save:

profile-20220414T203242.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 10h 12min 18s | max lag: 3.62s | clients: CityFinder, TobiasGaming, Ravise, Bla, shanish, Coolstorms, paneg, AliasAlreadyTaken, Service, mindfrost, GrimPixel, debiankaios, Bishiro, tour, Lucien, shanish2, my-names-is-vaeria, Bailiff, flux, pitman, Boot, Freebie, Boris

Teleport command:

/teleport xyz 5984 -12 2968

Compass command:

/give_compass Construction TSBSZQQqnMR2riIihVAWiYutDpID2uhk D2691E 5984 -12 2968

Freebie reports a bug: > How to change the leader of the party from one to another, both agrees? Player position: ``` { y = -12.498999595642, x = 5984.046875, z = 2968.1989746094 } ``` Player look: ``` { y = -0.14763678610325, x = -0.7465523481369, z = -0.64873945713043 } ``` Player information: ``` { min_rtt = 0.010999999940395, max_rtt = 0.25, connection_uptime = 1597, max_jitter = 0.23199999332428, minor = 5, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "de", version_string = "5.5.0", avg_rtt = 0.01799999922514, state = "Active", avg_jitter = 0.0080000013113022, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 13600\", \"3d_armor:leggings_crystal 1 13600\", \"shields:shield_crystal 1 13600\", \"3d_armor:boots_crystal 1 13600\", \"3d_armor:helmet_crystal 1 13600\", \"\"}", played_time = "1526", ["stamina:level"] = "12", arenalib_infobox_arenaID = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "83", jointime = "1649959597", hud_state = "on", yl_commons_player_joined = "1649959598", bitten = "0", repellant = "0", yl_commons_player_created = "1649959597" } } ``` Log identifier ``` [MOD] yl_report log identifier = TSBSZQQqnMR2riIihVAWiYutDpID2uhk ``` Profiler save: ``` profile-20220414T203242.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 10h 12min 18s | max lag: 3.62s | clients: CityFinder, TobiasGaming, Ravise, Bla, shanish, Coolstorms, paneg, AliasAlreadyTaken, Service, mindfrost, GrimPixel, debiankaios, Bishiro, tour, Lucien, shanish2, my-names-is-vaeria, Bailiff, flux, pitman, Boot, Freebie, Boris ``` Teleport command: ``` /teleport xyz 5984 -12 2968 ``` Compass command: ``` /give_compass Construction TSBSZQQqnMR2riIihVAWiYutDpID2uhk D2691E 5984 -12 2968 ```

AliasAlreadyTaken was assigned by yourland-report

2022-04-14 18:32:42 +00:00

flux commented

2022-04-14 22:28:41 +00:00

I don't think there's a way to do this, other than to disband the party and re-form it?

flux added the

1. kind/enhancement

1. kind/documentation

labels 2022-04-14 22:28:47 +00:00

AliasAlreadyTaken commented

2022-04-16 21:21:00 +00:00

Unfortuately there is no such command. We could try to make one, but even upstream would benefit.

https://github.com/neinwhal/party/issues/1

Unfortuately there is no such command. We could try to make one, but even upstream would benefit. https://github.com/neinwhal/party/issues/1

AliasAlreadyTaken added the

3. source/mod upstream

label 2022-04-16 21:21:06 +00:00

Boot commented

2022-11-07 18:37:47 +00:00

And? Coder neinwhal said something about a working version there in April.

flux commented

2022-11-07 19:20:54 +00:00

And? Coder neinwhal said something about a working version there in April.

and they never responded again nor did they release a new version.

> And? Coder neinwhal said something about a working version there in April. and they never responded again nor did they release a new version.

AliasAlreadyTaken commented

2022-11-08 16:36:03 +00:00

Looks like edgy implemented this in 0afca39449 but it was never PRed into upstream.

Looks like edgy implemented this in https://github.com/neinwhal/party/commit/0afca39449460bba74093fc2e728b0bb76ba3976 but it was never PRed into upstream.

Boot commented

2023-07-06 14:59:02 +00:00

How does it going?

Boot commented

2024-01-24 15:58:20 +00:00

There are several options. We are still waiting for neinwhal. Or we do a PR with the necessary code, which nodial then promised to wave through. Or we can take the only registered fork of MoNTE48 there. https://github.com/MoNTE48/party

He has already built in a lot of things in the applicant's interest. The administrator has been given the additional possibility to reset the leader via command, see init.lua line 242. By the way, from line 677 onwards, further exciting functions will be added.

There are several options. We are still waiting for neinwhal. Or we do a PR with the necessary code, which nodial then promised to wave through. Or we can take the only registered fork of MoNTE48 there. https://github.com/MoNTE48/party He has already built in a lot of things in the applicant's interest. The administrator has been given the additional possibility to reset the leader via command, see init.lua line 242. By the way, from line 677 onwards, further exciting functions will be added.

👀 1

Boot referenced this issue

2024-01-24 16:03:44 +00:00

Cities should have a tool to manage residents #5449

Boot commented

2024-03-21 19:32:35 +00:00

Have my suggestions above been considered?

AliasAlreadyTaken commented

2024-03-22 14:52:18 +00:00

Looking at the party mod situation:

Upstream maintainer neinwhal(https://github.com/neinwhal) is still active, but is unwilling or unable to fix the upstream party(https://github.com/neinwhal/party) mod
There is a fork by MoNTE48(https://github.com/MoNTE48) who forked and fixed part of his party(https://github.com/MoNTE48/party) mod, but unfortunately hard-depends(https://github.com/MoNTE48/party/blob/master/mod.conf) on player_skin.
The partymod itself is in a dormant/unmaintained state. We appear to be the only major server that uses it
The current party mod uses a terrible safe format, with underscores as delimiters.
With 1.6 war the parties will need a major rework anyways.

Options

Attempt a YL rewrite ahead of time, the requirements are known
Switch to a different party mod and migrate the data
Pull in the code changes in yl_stable and postpone rewrite until 1.6
Switch upstream to MoNTE48's fork and fix the dependency problem in yl_stable

Looking at those options it appears that

High effort, high reward. This will hit us eventually in the future anyways.
High effort, medium reward. There are not many good ones or usable ones.
Low effort, medium reward. Then we're stuck with a Frankenstein monster once again until upstream fixes it.
Medium effort, low reward. Then we're stuck with a Frankenstein monster once again, no maintenance.

I'd vote for option 3, until we can make 1 happen

Looking at the party mod situation: * Upstream maintainer neinwhal(https://github.com/neinwhal) is still active, but is unwilling or unable to fix the upstream party(https://github.com/neinwhal/party) mod * There is a fork by MoNTE48(https://github.com/MoNTE48) who forked and fixed part of his party(https://github.com/MoNTE48/party) mod, but unfortunately hard-depends(https://github.com/MoNTE48/party/blob/master/mod.conf) on player_skin. * The partymod itself is in a dormant/unmaintained state. We appear to be the only major server that uses it * The current party mod uses a terrible safe format, with underscores as delimiters. * With 1.6 war the parties will need a major rework anyways. Options 1. Attempt a YL rewrite ahead of time, the requirements are known 2. Switch to a different party mod and migrate the data 3. Pull in the code changes in yl_stable and postpone rewrite until 1.6 4. Switch upstream to MoNTE48's fork and fix the dependency problem in yl_stable Looking at those options it appears that 1. High effort, high reward. This will hit us eventually in the future anyways. 2. High effort, medium reward. There are not many good ones or usable ones. 3. Low effort, medium reward. Then we're stuck with a Frankenstein monster once again until upstream fixes it. 4. Medium effort, low reward. Then we're stuck with a Frankenstein monster once again, no maintenance. I'd vote for option 3, until we can make 1 happen

flux commented

2024-03-25 19:26:23 +00:00

does MoNTE48's fork actually fix anything that's a problem for us? it doesn't seem to fix "underscores as delimiters", nor does it allow changing party owners. in fact, the basic architecture of both forks means that changing the owner is going to be a horribly painful process. also, instead of needing kick/ban privs for certain actions, it requires a new "moderator" priv which it doesn't even create itself.

i vote that we rewrite parties from scratch, and figure out some way to port existing party data to the new mod. but i don't think that's a high priority.

does MoNTE48's fork actually fix anything that's a problem for us? it doesn't seem to fix "underscores as delimiters", nor does it allow changing party owners. in fact, the basic architecture of both forks means that changing the owner is going to be a horribly painful process. also, instead of needing kick/ban privs for certain actions, it requires a new "moderator" priv which it doesn't even create itself. i vote that we rewrite parties from scratch, and figure out some way to port existing party data to the new mod. but i don't think that's a high priority.

tour referenced this issue

2024-04-21 15:50:22 +00:00

Reimplement party mod #6691

Boot referenced this issue

2024-04-21 21:28:21 +00:00

Reimplement party mod #6691

Sign in to join this conversation.