petz/misc/lycanthropy.lua:67: attempt to call method 'get_meta' (a nil value) #1736
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#1736
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
2022-04-12 19:44:38: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'sailing_kit' in callback environment_Step(): ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:67: attempt to call method 'get_meta' (a nil value)
2022-04-12 19:44:38: ERROR[Main]: stack traceback:
2022-04-12 19:44:38: ERROR[Main]: ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:67: in function 'is_werewolf'
2022-04-12 19:44:38: ERROR[Main]: ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:317: in function 'func'
2022-04-12 19:44:38: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function 'callback'
2022-04-12 19:44:38: ERROR[Main]: .../mtlive/5.5.0/Minetest_live/bin/../mods/stamina/init.lua:434: in function 'old_do_item_eat'
2022-04-12 19:44:38: ERROR[Main]: ...5.0/Minetest_live/bin/../mods/yl_statuseffects/tipsy.lua:6: in function 'on_use'
2022-04-12 19:44:38: ERROR[Main]: ...ve/5.5.0/Minetest_live/bin/../mods/pipeworks/wielder.lua:328: in function 'act'
2022-04-12 19:44:38: ERROR[Main]: ...ve/5.5.0/Minetest_live/bin/../mods/pipeworks/wielder.lua:111: in function 'wielder_on'
2022-04-12 19:44:38: ERROR[Main]: ...ve/5.5.0/Minetest_live/bin/../mods/pipeworks/wielder.lua:147: in function 'action_on'
2022-04-12 19:44:38: ERROR[Main]: ...Minetest_live/bin/../mods/mesecons/mesecons/internal.lua:192: in function <...Minetest_live/bin/../mods/mesecons/mesecons/internal.lua:185>
2022-04-12 19:44:38: ERROR[Main]: ...etest_live/bin/../mods/mesecons/mesecons/actionqueue.lua:137: in function 'old_execute'
2022-04-12 19:44:38: ERROR[Main]: ...ve/worldmods/mesecons_debug/overrides/mesecons_queue.lua:20: in function 'execute'
2022-04-12 19:44:38: ERROR[Main]: ...etest_live/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_live/bin/../mods/mesecons/mesecons/actionqueue.lua:73>
2022-04-12 19:44:38: ERROR[Main]: ...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:425: in function <...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:409>
2022-04-12 20:08:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'sailing_kit' in callback environment_Step(): ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:68: attempt to call method 'get_meta' (a nil value)
2022-04-12 20:08:10: ERROR[Main]: stack traceback:
2022-04-12 20:08:10: ERROR[Main]: ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:68: in function 'is_werewolf'
2022-04-12 20:08:10: ERROR[Main]: ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:318: in function 'func'
2022-04-12 20:08:10: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function 'callback'
2022-04-12 20:08:10: ERROR[Main]: .../mtlive/5.5.0/Minetest_live/bin/../mods/stamina/init.lua:434: in function 'old_do_item_eat'
2022-04-12 20:08:10: ERROR[Main]: ...5.0/Minetest_live/bin/../mods/yl_statuseffects/tipsy.lua:6: in function 'on_use'
2022-04-12 20:08:10: ERROR[Main]: ...ve/5.5.0/Minetest_live/bin/../mods/pipeworks/wielder.lua:328: in function 'act'
2022-04-12 20:08:10: ERROR[Main]: ...ve/5.5.0/Minetest_live/bin/../mods/pipeworks/wielder.lua:111: in function 'wielder_on'
2022-04-12 20:08:10: ERROR[Main]: ...ve/5.5.0/Minetest_live/bin/../mods/pipeworks/wielder.lua:147: in function 'action_on'
2022-04-12 20:08:10: ERROR[Main]: ...Minetest_live/bin/../mods/mesecons/mesecons/internal.lua:192: in function <...Minetest_live/bin/../mods/mesecons/mesecons/internal.lua:185>
2022-04-12 20:08:10: ERROR[Main]: ...etest_live/bin/../mods/mesecons/mesecons/actionqueue.lua:137: in function 'old_execute'
2022-04-12 20:08:10: ERROR[Main]: ...ve/worldmods/mesecons_debug/overrides/mesecons_queue.lua:20: in function 'execute'
2022-04-12 20:08:10: ERROR[Main]: ...etest_live/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_live/bin/../mods/mesecons/mesecons/actionqueue.lua:73>
2022-04-12 20:08:10: ERROR[Main]: ...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:425: in function <...ive/5.5.0/Minetest_live/bin/../builtin/game/register.lua:409>
did... someone put a lycanthropy cure in a deployer or something?
no, looks like they put food in a deployer
while the immediate cause of the crash could be attributed to petz not checking to see if the "player" is a real player or not, i feel like the real source of the problem is pipeworks. having to add extra logic to check for pipeworks fake users in every mod that handles user actions is totally untenable. i have seen it cause crashes in something like a dozen mods.
https://github.com/mt-mods/pipeworks/issues/18
2022-04-12 20:14:38: ACTION[Main]: Server: Shutting down
2022-04-12 20:14:39: ERROR[Main]: ModError: Failed to load and run script from /home/mtlive/5.5.0/Minetest_live/bin/../mods/petz/petz/init.lua:
2022-04-12 20:14:39: ERROR[Main]: .../5.5.0/Minetest_live/bin/../mods/petz/petz/misc/misc.lua:13: ...Minetest_live/bin/../mods/petz/petz/misc/lycanthropy.lua:68: function arguments expected near ')'
2022-04-12 20:14:39: ERROR[Main]: stack traceback:
2022-04-12 20:14:39: ERROR[Main]: [C]: in function 'assert'
2022-04-12 20:14:39: ERROR[Main]: .../5.5.0/Minetest_live/bin/../mods/petz/petz/misc/misc.lua:13: in main chunk
2022-04-12 20:14:39: ERROR[Main]: ...tlive/5.5.0/Minetest_live/bin/../mods/petz/petz/init.lua:32: in main chunk
https://github.com/runsy/petz/issues/99
Fixed in
c68a216f28
Looks like upstream neither petz nor pipeworks want to fix that, so we must do it. currently it's still directly in the petz mod, because easy. Later when yl_commons is a bit cleaned up we may want to move it there
Readded in
49dc95a5fc