Flight enabled in ethereal #1683

Closed
opened 2022-04-04 15:17:58 +00:00 by flux · 7 comments
Member

A recent update ignores settings and always enables flight. See https://notabug.org/TenPlus1/ethereal/issues/46

A recent update ignores settings and always enables flight. See https://notabug.org/TenPlus1/ethereal/issues/46
flux added the
1. kind/bug
3. source/mod upstream
2. prio/critical
labels 2022-04-04 15:17:58 +00:00
Author
Member

Created an upstream PR to fix this:

https://notabug.org/TenPlus1/ethereal/pulls/47

Created an upstream PR to fix this: https://notabug.org/TenPlus1/ethereal/pulls/47
Author
Member

10+1 fixed it his own way:

ee13374d44

10+1 fixed it his own way: https://notabug.org/TenPlus1/ethereal/commit/ee13374d444fcdaa6b002f4a55de23c8e09fdb1f

So, what do we do?

  1. Either Tenplus1 patches it out or we will. Most likely this already has been done due flux' quick reaction on Tenplus1's repo.
  2. Find the players who did it: select * from "player_metadata" where "attr" like '%ethereal:fly_timer%'
  3. Find the remaining potions ingame: cat Minetest_live.out | grep ethereal:flight_potion
  4. /warn Everyone who uses or used fly potions, please report to AliasAlreadyTaken. Your playermeta needs to be cleaned and you can trade in your flight potions for the materials.
So, what do we do? 1. Either Tenplus1 patches it out or we will. Most likely this already has been done due flux' quick reaction on Tenplus1's repo. 2. Find the players who did it: select * from "player_metadata" where "attr" like '%ethereal:fly_timer%' 3. Find the remaining potions ingame: cat Minetest_live.out | grep ethereal:flight_potion 4. /warn Everyone who uses or used fly potions, please report to AliasAlreadyTaken. Your playermeta needs to be cleaned and you can trade in your flight potions for the materials.

Since a mapgen mod is a terrible place for backdooring gamemechanics into a server, maybe we should add a minetest.clear_craft?

Since a mapgen mod is a terrible place for backdooring gamemechanics into a server, maybe we should add a minetest.clear_craft?
Author
Member

minetest.clear_craft

why? in case this happens again? suppose that makes sense.

also, re: the flight potions themselves; i was assuming they'd become unknown items, and was going to keep the single one i crafted as a souvenir. is that a problem?

> `minetest.clear_craft` why? in case this happens again? suppose that makes sense. also, re: the flight potions themselves; i was assuming they'd become unknown items, and was going to keep the single one i crafted as a souvenir. is that a problem?

Hopefully the roles mod will prevent that in the future, but you never know

https://gitea.your-land.de/your-land/yl_roles

Please destroy it or hand it in, I'll exchange it for the materials.

Having the potions as unknown items is not bad per se, but I think its unprofessional(?) or at least a sign of bad maintenance to have unknown items in the world. That's why I hunt them down, via log and database and everywhere I can :D

Hopefully the roles mod will prevent that in the future, but you never know https://gitea.your-land.de/your-land/yl_roles Please destroy it or hand it in, I'll exchange it for the materials. Having the potions as unknown items is not bad per se, but I think its *unprofessional(?)* or at least a sign of bad maintenance to have unknown items in the world. That's why I hunt them down, via log and database and everywhere I can :D

Fixed in 588875097a

Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/588875097ad0e328225aa43d1b315d27d018118d
AliasAlreadyTaken added the
5. result/fixed
label 2022-04-07 21:35:27 +00:00
AliasAlreadyTaken added this to the 1.1.109 milestone 2022-04-07 21:35:29 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1683
No description provided.