Eris_still_crafts reports: Using the "craft ALL" button d ... #161

New Issue

yourland-report · 2021-01-09T15:45:44Z

yourland-report commented

2021-01-09 15:45:44 +00:00

Eris_still_crafts reports a bug:

Using the "craft ALL" button doesn't consume hunger

Player position:

{
	y = -25.499000549316,
	x = 2083.9802246094,
	z = 598.53399658203
}

Player look:

{
	y = -0.046932112425566,
	x = 0.9752938747406,
	z = 0.2158685028553
}

Log identifier


[MOD] yl_report log identifier = wN3WOJlBbB4nvulCfs1mGdTiCxg0rpTj

Profiler save:

profile-20210109T164543.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=35934.2, max_lag=1.61773, clients={Aristotle, Kelpi, Sorii, TyrellCorporation, Eris_still_crafts, Rex_2000, Cepheus, Bailiff, AliasAlreadyTaken}

Eris_still_crafts reports a bug: ``` Using the "craft ALL" button doesn't consume hunger ``` Player position: ``` { y = -25.499000549316, x = 2083.9802246094, z = 598.53399658203 } ``` Player look: ``` { y = -0.046932112425566, x = 0.9752938747406, z = 0.2158685028553 } ``` Log identifier ``` [MOD] yl_report log identifier = wN3WOJlBbB4nvulCfs1mGdTiCxg0rpTj ``` Profiler save: ``` profile-20210109T164543.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=35934.2, max_lag=1.61773, clients={Aristotle, Kelpi, Sorii, TyrellCorporation, Eris_still_crafts, Rex_2000, Cepheus, Bailiff, AliasAlreadyTaken} ```

AliasAlreadyTaken was assigned by yourland-report

2021-01-09 15:45:44 +00:00

AliasAlreadyTaken added the

1. kind/bug

3. source/mod upstream

labels 2021-01-09 15:50:37 +00:00

Styxcolor added the

4. step/question

label 2021-11-07 00:55:17 +00:00

Styxcolor commented

2021-11-07 00:55:33 +00:00

Oh, should it?

flux commented

2022-01-04 22:18:44 +00:00

Regular crafting does cost hunger. See https://gitlab.com/tunnelers-abyss/unified_inventory_plus for a version of UI+ which prevents players from abusing the "all" button.

I'm not sure it fixes the issue w/ disappearing replacement items, though.

Regular crafting does cost hunger. See https://gitlab.com/tunnelers-abyss/unified_inventory_plus for a version of UI+ which prevents players from abusing the "all" button. I'm not sure it fixes the issue w/ disappearing replacement items, though.

flux referenced this issue

2022-01-04 22:21:31 +00:00

Dereko reports: when you press "all while usin ... #195

flux added this to the (deleted) project 2022-01-11 01:08:22 +00:00

AliasAlreadyTaken was unassigned by flux

2022-01-11 01:08:31 +00:00

flux self-assigned this 2022-01-11 01:08:31 +00:00

flux commented

2022-01-11 01:12:33 +00:00

The current version of unified_inventory does drain stamina, but not for the fork of stamina we're currently using. Possibly, the "tipsy" effect, and anything else the main fork are missing, could be extracted.

The current version of unified_inventory *does* drain stamina, but not for the fork of stamina we're currently using. Possibly, the "tipsy" effect, and anything else the main fork are missing, could be extracted.

flux referenced this issue

2022-01-13 00:42:30 +00:00

Move to minetest-mods stamina #1323

flux commented

2022-04-14 16:59:30 +00:00

We're using the right version of stamina now, but it looks like my last fix to unified_inventory_plus broke the logic to check whether to exhaust the player while crafting.

While I'm in there, I might put in a check to disallow using the "craft-all" button if the player is low on stamina.

We're using the right version of stamina now, but it looks like my last fix to unified_inventory_plus broke the logic to check whether to exhaust the player while crafting. While I'm in there, I might put in a check to disallow using the "craft-all" button if the player is low on stamina.

flux commented

2022-04-14 19:17:03 +00:00

https://github.com/bousket/unified_inventory_plus/pull/19

flux removed the

4. step/question

label 2022-04-14 19:17:17 +00:00

AliasAlreadyTaken added this to the 1.1.110 milestone 2022-04-16 21:37:40 +00:00

AliasAlreadyTaken closed this issue

2022-04-16 21:37:43 +00:00

AliasAlreadyTaken added the

5. result/fixed

label 2022-04-16 21:37:48 +00:00

AliasAlreadyTaken commented

2022-04-16 21:40:48 +00:00

@flux Line 113 of that PR:

minetest.chat_send_player(player_name, "has stamina")

Is this a debug print?

https://github.com/bousket/unified_inventory_plus/pull/19/files#diff-e1d00aba99de070d6b8e3f72e3930a174b63ac5c7c253b3f3106060fe9e21d5dR113

Same question for the other, similar lines below?

The initial problem is solved, craft all now consumes hunger. But when it does, it prints "has stamina" to the player as many times as the craft was executed.

@flux Line 113 of that PR: minetest.chat_send_player(player_name, "has stamina") Is this a debug print? https://github.com/bousket/unified_inventory_plus/pull/19/files#diff-e1d00aba99de070d6b8e3f72e3930a174b63ac5c7c253b3f3106060fe9e21d5dR113 Same question for the other, similar lines below? > The initial problem is solved, craft all now consumes hunger. But when it does, it prints "has stamina" to the player as many times as the craft was executed.

AliasAlreadyTaken reopened this issue

2022-04-16 21:40:48 +00:00

AliasAlreadyTaken removed the

5. result/fixed

label 2022-04-16 21:40:58 +00:00

flux commented

2022-04-16 22:36:53 +00:00

Whoops, yeah that's a debug print =D