Arabella reports: node replacer tool can even re ... #1560

New Issue

yourland-report · 2022-03-10T19:27:43Z

yourland-report commented

2022-03-10 19:27:43 +00:00

Arabella reports a bug:

node replacer tool can even replace maptools like nointeract blocks. the tool shouldnt be allowed to be that powerful

Player position:

{
	y = 52.5,
	x = 10638.065429688,
	z = -5555.0673828125
}

Player look:

{
	y = -0.71812629699707,
	x = -0.34553465247154,
	z = -0.60406982898712
}

Player information:

{
	min_rtt = 0.023000000044703,
	max_rtt = 24.856000900269,
	connection_uptime = 3040,
	max_jitter = 24.548999786377,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-4c8c649",
	avg_rtt = 0.2790000140667,
	state = "Active",
	avg_jitter = 0.24500000476837,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 60350\", \"shields:shield_admin\", \"\", \"\", \"\", \"\"}",
		["petz:werewolf_vignette_id"] = "19",
		played_time = "4669772",
		jointime = "1624205010",
		yl_commons_player_joined = "1646937482",
		["signslib:pos"] = "(4955,4,4351)",
		digged_nodes = "59114",
		placed_nodes = "100545",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		xp = "149720",
		["petz:lycanthropy"] = "0",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 14948, [\"z\"] = 13759}, [\"last_heal\"] = 1627128051, [\"last_death_portal\"] = 1645726799}",
		yl_commons_thankyou = "195",
		["stamina:level"] = "17",
		punch_count = "16557",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1290270",
		crafted = "476",
		["petz:werewolf_clan_idx"] = "1",
		["petz:werewolf"] = "0",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		died = "30",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1624205010"
	}
}

Log identifier


[MOD] yl_report log identifier = 8o6i4xTJ2hfxVmnUXFUcjN4biLGNMJY8

Profiler save:

profile-20220310T202742.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=823850, max_lag=4.02008, clients={aliwoto_III, guestxmart, Ravise, Julia, shanish, pakers, Arabella, my-names-is-vaeria, Carp-Hunter, Ineva, shanish2, flux, mindfrost, Bailiff, AliasAlreadyTaken, Service, Noofky}

Teleport command:

/teleport xyz 10638 53 -5555

Compass command:

/give_compass Construction 8o6i4xTJ2hfxVmnUXFUcjN4biLGNMJY8 D2691E 10638 53 -5555

Arabella reports a bug: > node replacer tool can even replace maptools like nointeract blocks. the tool shouldnt be allowed to be that powerful Player position: ``` { y = 52.5, x = 10638.065429688, z = -5555.0673828125 } ``` Player look: ``` { y = -0.71812629699707, x = -0.34553465247154, z = -0.60406982898712 } ``` Player information: ``` { min_rtt = 0.023000000044703, max_rtt = 24.856000900269, connection_uptime = 3040, max_jitter = 24.548999786377, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-4c8c649", avg_rtt = 0.2790000140667, state = "Active", avg_jitter = 0.24500000476837, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 60350\", \"shields:shield_admin\", \"\", \"\", \"\", \"\"}", ["petz:werewolf_vignette_id"] = "19", played_time = "4669772", jointime = "1624205010", yl_commons_player_joined = "1646937482", ["signslib:pos"] = "(4955,4,4351)", digged_nodes = "59114", placed_nodes = "100545", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", xp = "149720", ["petz:lycanthropy"] = "0", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 14948, [\"z\"] = 13759}, [\"last_heal\"] = 1627128051, [\"last_death_portal\"] = 1645726799}", yl_commons_thankyou = "195", ["stamina:level"] = "17", punch_count = "16557", arenalib_infobox_arenaID = "0", inflicted_damage = "1290270", crafted = "476", ["petz:werewolf_clan_idx"] = "1", ["petz:werewolf"] = "0", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", died = "30", hud_state = "on", repellant = "0", yl_commons_player_created = "1624205010" } } ``` Log identifier ``` [MOD] yl_report log identifier = 8o6i4xTJ2hfxVmnUXFUcjN4biLGNMJY8 ``` Profiler save: ``` profile-20220310T202742.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=823850, max_lag=4.02008, clients={aliwoto_III, guestxmart, Ravise, Julia, shanish, pakers, Arabella, my-names-is-vaeria, Carp-Hunter, Ineva, shanish2, flux, mindfrost, Bailiff, AliasAlreadyTaken, Service, Noofky} ``` Teleport command: ``` /teleport xyz 10638 53 -5555 ``` Compass command: ``` /give_compass Construction 8o6i4xTJ2hfxVmnUXFUcjN4biLGNMJY8 D2691E 10638 53 -5555 ```

AliasAlreadyTaken was assigned by yourland-report

2022-03-10 19:27:43 +00:00

flux commented

2022-03-11 03:47:34 +00:00

Maptools nodes need to be replaceable by a creative player, but should not be by a normal player.

You can't get a maptool "item" drop by replacing it, they all drop "".

The "solution" we used on blocky, was to protect the area.

Maptools nodes need to be replaceable by a creative player, but should not be by a normal player. You can't get a maptool "item" drop by replacing it, they all drop "". The "solution" we used on blocky, was to protect the area.

aliwoto commented

2022-03-21 09:10:30 +00:00

@flux maptools are used in a few places in nether (such as Corridor Corridor), and you can't protect any area in nether, thus players can still replace nointeract and other maptools in those places

flux commented

2022-04-07 21:08:28 +00:00

proposed solution: admins should be able to protect areas even in the nether, such as the Netherlands corridor.

flux added the

1. kind/enhancement

1. kind/documentation

labels 2022-04-07 21:13:21 +00:00

AliasAlreadyTaken commented

2022-04-16 23:33:53 +00:00

Maptools nodes need to be replaceable by a creative player, but should not be by a normal player.

Why? I cannot think of a situation where someone nonstaff needs to replace maptools nodes?

IMO it would be best if we added maptools nodes to the blacklist of the replacer

> Maptools nodes need to be replaceable by a creative player, but should not be by a normal player. Why? I cannot think of a situation where someone nonstaff needs to replace maptools nodes? IMO it would be best if we added maptools nodes to the blacklist of the replacer

flux commented

2022-04-16 23:40:34 +00:00

Maptools nodes need to be replaceable by a creative player, but should not be by a normal player.

Why? I cannot think of a situation where someone nonstaff needs to replace maptools nodes?

IMO it would be best if we added maptools nodes to the blacklist of the replacer

if they're added to the blacklist, then staff won't be able to use them w/ the replacer, either, and there's absolutely cases where staff will want to.

> > Maptools nodes need to be replaceable by a creative player, but should not be by a normal player. > > Why? I cannot think of a situation where someone nonstaff needs to replace maptools nodes? > > IMO it would be best if we added maptools nodes to the blacklist of the replacer if they're added to the blacklist, then staff won't be able to use them w/ the replacer, either, and there's absolutely cases where staff will want to.

flux added this to the flux's TODO list project 2022-07-02 20:00:23 +00:00

flux commented

2022-07-02 20:02:04 +00:00

i think this would be resolved by adopting my replacer redo variant. i need to do more testing w/ the creative replacement tool, though.

i think this would be resolved by adopting my [replacer redo](https://github.com/fluxionary/minetest-replacer_redo) variant. i need to do more testing w/ the creative replacement tool, though.

AliasAlreadyTaken commented

2022-08-08 05:47:33 +00:00

We'll eventually need to come to a technical comparison between the now-updated replacer mod of Sokomine and the rewrite by flux. Currently we're using the swissalps version and there are plenty of others out there. I think we'd do MT a favour if we tried to unify them.

But: https://xkcd.com/927/

We'll eventually need to come to a technical comparison between the now-updated replacer mod of Sokomine and the rewrite by flux. Currently we're using the swissalps version and there are plenty of others out there. I think we'd do MT a favour if we tried to unify them. But: https://xkcd.com/927/

flux added the

4. step/discussion

label 2022-09-20 20:03:52 +00:00

flux commented

2022-10-17 03:52:27 +00:00

But: https://xkcd.com/927/

the various different replacer implementations are each imperfect for different contexts. SwissalpS and Sokomine focus more on creative servers, while trying to also be useful on survival servers. i provide separate tools for both creative and survival, which have distinct capabilities. however, SwissalpS and Sokomine allow you more control over what the tool does for both creative and survival players; i'm trying to re-imagine the tool as something that is less magic particulary for non-creative players.

probably, it should even have wear, though i'm still weighing that decison. i'm gating that decision until i decide whether i want to create a mod that will prevent tools from "fully" breaking, and just become useless, until they are repaired (in a possibly special manner).

> But: https://xkcd.com/927/ the various different replacer implementations are each imperfect for different contexts. SwissalpS and Sokomine focus more on creative servers, while trying to also be useful on survival servers. i provide separate tools for both creative and survival, which have distinct capabilities. however, SwissalpS and Sokomine allow you more control over what the tool does for both creative and survival players; i'm trying to re-imagine the tool as something that is less magic particulary for non-creative players. probably, it should even have wear, though i'm still weighing that decison. i'm gating that decision until i decide whether i want to create a mod that will prevent tools from "fully" breaking, and just become useless, until they are repaired (in a possibly special manner).

flux commented

2023-03-10 19:55:15 +00:00

drgn accidentally replaced the maptools nointeract blocks in the netherlands portal area. they immediately reported the issue, and i fixed it w/ rheo (//r), but we should try to figure out a better solution.

drgn accidentally replaced the maptools nointeract blocks in the netherlands portal area. they immediately reported the issue, and i fixed it w/ rheo (`//r`), but we should try to figure out a better solution.

flux added the

2. prio/elevated

label 2023-03-10 19:55:40 +00:00

Sokomine commented

2023-03-10 23:54:12 +00:00

Adding wear to the replacer would from my POV be almost criminal. Don't hinder builders!

My version of the replacer supports blacklists for blocks.

Adding wear to the replacer would from my POV be almost criminal. Don't hinder builders! My version of the replacer supports blacklists for blocks.

flux commented

2023-03-13 02:34:28 +00:00

My version of the replacer supports blacklists for blocks.

the version we use (SwissalpS') also supports blacklists, and we already use those. honestly, i like Sokomine's version more than SwissalpS', mostly because the latter has insane "modes" that can easily result in terrible accidents while doing normal things. my minimalist rewrite also supports blacklists, though via a different API. replacer balancing is complex.

> My version of the replacer supports blacklists for blocks. the version we use (SwissalpS') also supports blacklists, and we already use those. honestly, i like Sokomine's version more than SwissalpS', mostly because the latter has insane "modes" that can easily result in terrible accidents while doing normal things. my minimalist rewrite also supports blacklists, though via a different API. replacer balancing is complex.

Sign in to join this conversation.