debiankaios reports: if you die and log out while y ... #1503

New Issue

yourland-report · 2022-02-19T08:14:53Z

yourland-report commented

2022-02-19 08:14:53 +00:00

debiankaios reports a bug:

if you die and log out while you die and then log in again you are at plac where you are died

Player position:

{
	y = 14.5,
	x = 2049.6730957031,
	z = 1192.1770019531
}

Player look:

{
	y = -0.48037657141685,
	x = 0.86953890323639,
	z = 0.114631280303
}

Player information:

{
	min_rtt = 0.012000000104308,
	max_rtt = 0.64600002765656,
	connection_uptime = 2485,
	max_jitter = 0.63000005483627,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "de",
	version_string = "5.6.0-dev-80812b8",
	avg_rtt = 0.016000000759959,
	state = "Active",
	avg_jitter = 0.0010000001639128,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 1440\", \"3d_armor:helmet_rainbow 1 576\", \"3d_armor:leggings_rainbow 1 576\", \"3d_armor:chestplate_rainbow 1 576\", \"shields:shield_rainbow 1 576\", \"\"}",
		played_time = "1496926",
		jointime = "1618169882",
		yl_commons_player_joined = "1645256017",
		["signslib:pos"] = "(-1543,164,-3652)",
		digged_nodes = "126910",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 124, [\"x\"] = -1482, [\"z\"] = -3530}, [\"last_death_portal\"] = 1645256093}",
		["stamina:level"] = "14.6",
		punch_count = "21250",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "410064",
		crafted = "1467",
		xp = "116524",
		yl_commons_thankyou = "46",
		placed_nodes = "46151",
		died = "222",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1618169882"
	}
}

Log identifier


[MOD] yl_report log identifier = ekAynM0rtHouc2iWnPXgBoekTsG7qoNH

Profiler save:

profile-20220219T091452.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=234824, max_lag=3.35319, clients={Player95, evil123, Bishiro, debiankaios, bizon, BondGirl, TheSingingBee, sankar21, Apocralypse, Bailiff, AliasAlreadyTaken, Service, 1tester1, FrostRanger, guestxmart, flux}

Teleport command:

/teleport xyz 2050 15 1192

Compass command:

/give_compass Construction ekAynM0rtHouc2iWnPXgBoekTsG7qoNH D2691E 2050 15 1192

debiankaios reports a bug: > if you die and log out while you die and then log in again you are at plac where you are died Player position: ``` { y = 14.5, x = 2049.6730957031, z = 1192.1770019531 } ``` Player look: ``` { y = -0.48037657141685, x = 0.86953890323639, z = 0.114631280303 } ``` Player information: ``` { min_rtt = 0.012000000104308, max_rtt = 0.64600002765656, connection_uptime = 2485, max_jitter = 0.63000005483627, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "de", version_string = "5.6.0-dev-80812b8", avg_rtt = 0.016000000759959, state = "Active", avg_jitter = 0.0010000001639128, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 1440\", \"3d_armor:helmet_rainbow 1 576\", \"3d_armor:leggings_rainbow 1 576\", \"3d_armor:chestplate_rainbow 1 576\", \"shields:shield_rainbow 1 576\", \"\"}", played_time = "1496926", jointime = "1618169882", yl_commons_player_joined = "1645256017", ["signslib:pos"] = "(-1543,164,-3652)", digged_nodes = "126910", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 124, [\"x\"] = -1482, [\"z\"] = -3530}, [\"last_death_portal\"] = 1645256093}", ["stamina:level"] = "14.6", punch_count = "21250", arenalib_infobox_arenaID = "0", inflicted_damage = "410064", crafted = "1467", xp = "116524", yl_commons_thankyou = "46", placed_nodes = "46151", died = "222", hud_state = "on", repellant = "0", yl_commons_player_created = "1618169882" } } ``` Log identifier ``` [MOD] yl_report log identifier = ekAynM0rtHouc2iWnPXgBoekTsG7qoNH ``` Profiler save: ``` profile-20220219T091452.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=234824, max_lag=3.35319, clients={Player95, evil123, Bishiro, debiankaios, bizon, BondGirl, TheSingingBee, sankar21, Apocralypse, Bailiff, AliasAlreadyTaken, Service, 1tester1, FrostRanger, guestxmart, flux} ``` Teleport command: ``` /teleport xyz 2050 15 1192 ``` Compass command: ``` /give_compass Construction ekAynM0rtHouc2iWnPXgBoekTsG7qoNH D2691E 2050 15 1192 ```

AliasAlreadyTaken was assigned by yourland-report

2022-02-19 08:14:53 +00:00

Styxcolor added the

1. kind/bug

label 2022-02-19 22:14:31 +00:00

flux commented

2022-02-20 01:00:11 +00:00

i'm pretty sure this is a dupe, but i'm not finding the other one. see the first part of this file for a "fix":

https://github.com/BlockySurvival/bls_custom/blob/master/fix_dead_on_login.lua

i'm pretty sure this is a dupe, but i'm not finding the other one. see the first part of this file for a "fix": https://github.com/BlockySurvival/bls_custom/blob/master/fix_dead_on_login.lua

AliasAlreadyTaken commented

2022-05-09 20:22:02 +00:00

I tried to respawn out of map bounds, but I got reset to 0,0,0 wiht this log message:

2022-05-09 22:06:34: ACTION[Server]: Respawn position for player "AliasAlreadyTaken" outside limits, resetting

Looks like the out of bound check is not necessary anymore, but unfortunately we are reset to 0,0,0 instead of the spawnpoint we want. This is the code responsible: https://github.com/minetest/minetest/blob/backport-5/src/serverenvironment.cpp#L602

Setting them to spawnpoint after they logged in with 0 HP is a good idea though. I added it to https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/bugfixes/bugfixes_logindeath.lua here: a6c34e68fd

I tried to respawn out of map bounds, but I got reset to 0,0,0 wiht this log message: ``` 2022-05-09 22:06:34: ACTION[Server]: Respawn position for player "AliasAlreadyTaken" outside limits, resetting ``` Looks like the out of bound check is not necessary anymore, but unfortunately we are reset to 0,0,0 instead of the spawnpoint we want. This is the code responsible: https://github.com/minetest/minetest/blob/backport-5/src/serverenvironment.cpp#L602 Setting them to spawnpoint after they logged in with 0 HP is a good idea though. I added it to https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/bugfixes/bugfixes_logindeath.lua here: https://gitea.your-land.de/your-land/yl_commons/commit/a6c34e68fd53851d33c65bcdbf34315f7c01e612

AliasAlreadyTaken closed this issue

2022-05-09 20:22:02 +00:00

AliasAlreadyTaken added the

5. result/fixed

label 2022-05-09 20:23:35 +00:00

AliasAlreadyTaken added this to the 1.1.111 milestone 2022-05-09 20:23:38 +00:00

flux commented

2022-05-10 02:15:22 +00:00

I was talking more about

    if player:get_hp() == 0 then
        player:set_hp(20, "respawn")
        player:set_pos(spawn_pos)
    end

the map boundary checking was for a different issue, and yeah it looks like that's been fixed upstream.

there's still possibly a problem where if you die and time out, you don't get sent to /spawn when you revive.

I was talking more about ``` if player:get_hp() == 0 then player:set_hp(20, "respawn") player:set_pos(spawn_pos) end ``` the map boundary checking was for a different issue, and yeah it looks like that's been fixed upstream. there's still possibly a problem where if you die and time out, you don't get sent to /spawn when you revive.

AliasAlreadyTaken commented

2022-05-10 10:54:48 +00:00

there's still possibly a problem where if you die and time out, you don't get sent to /spawn when you revive.

@flux How so?

> there's still possibly a problem where if you die and time out, you don't get sent to /spawn when you revive. @flux How so?

AliasAlreadyTaken reopened this issue

2022-05-10 10:54:55 +00:00

AliasAlreadyTaken removed the

5. result/fixed

label 2022-05-10 10:55:00 +00:00

flux commented

2022-05-10 18:23:07 +00:00

I honestly have no idea how to replicate this, or what we could do to fix it properly. But I've heard other similar issues from other players for years, on occasion. That's the reason for that code block.