flux reports: my party name doesn't re-appea ... #1249

New Issue

yourland-report · 2021-12-30T23:23:39Z

yourland-report commented

2021-12-30 23:23:39 +00:00

flux reports a bug:

my party name doesn't re-appear when an inviz potion wears off

Player position:

{
	y = 5.5,
	x = 766.35101318359,
	z = 1994.7080078125
}

Player look:

{
	y = -0.15057067573071,
	x = -0.40587922930717,
	z = -0.90143805742264
}

Player information:

{
	min_rtt = 0.14900000393391,
	max_rtt = 28.721000671387,
	connection_uptime = 194039,
	max_jitter = 28.479999542236,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.0",
	avg_rtt = 0.16200000047684,
	state = "Active",
	avg_jitter = 0.0020000040531158,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_nether 1 4240\", \"3d_armor:chestplate_nether 1 4240\", \"shields:shield_rainbow 1 32\", \"3d_armor:helmet_nether 1 2120\", \"3d_armor:boots_crystal 1 2380\", \"\"}",
		["petz:werewolf_vignette_id"] = "15",
		played_time = "6725689",
		jointime = "1615351173",
		yl_commons_player_joined = "1640712599",
		["signslib:pos"] = "(-1348,64,959)",
		digged_nodes = "768977",
		placed_nodes = "288177",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		punch_count = "25794",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29822, [\"x\"] = 1949, [\"z\"] = 1608}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1640581842}",
		yl_commons_thankyou = "39",
		["stamina:level"] = "18.725",
		xp = "855658",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "435650",
		crafted = "24579",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf_clan_idx"] = "1",
		["petz:werewolf"] = "0",
		died = "57",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = dIRHJD7FmYIkBHmk7mnM23ZlBCOchvEN

Profiler save:

profile-20211231T002339.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=208543, max_lag=5.86679, clients={digdeep, DreamNotFound, Lucien, meatball, DangerousDan, Makenji, Sokomine, jackofthebean000, Lupercus, Bla, Boris, ccady, RIPBla, Violetta, karlbrock, Player305, LeetPeet, guestxmart, Bailiff, AliasAlreadyTaken, turtle, Service, flux}

Teleport command:

/teleport xyz 766 6 1995

Compass command:

/give_compass Construction dIRHJD7FmYIkBHmk7mnM23ZlBCOchvEN D2691E 766 6 1995

flux reports a bug: > my party name doesn't re-appear when an inviz potion wears off Player position: ``` { y = 5.5, x = 766.35101318359, z = 1994.7080078125 } ``` Player look: ``` { y = -0.15057067573071, x = -0.40587922930717, z = -0.90143805742264 } ``` Player information: ``` { min_rtt = 0.14900000393391, max_rtt = 28.721000671387, connection_uptime = 194039, max_jitter = 28.479999542236, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.0", avg_rtt = 0.16200000047684, state = "Active", avg_jitter = 0.0020000040531158, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:leggings_nether 1 4240\", \"3d_armor:chestplate_nether 1 4240\", \"shields:shield_rainbow 1 32\", \"3d_armor:helmet_nether 1 2120\", \"3d_armor:boots_crystal 1 2380\", \"\"}", ["petz:werewolf_vignette_id"] = "15", played_time = "6725689", jointime = "1615351173", yl_commons_player_joined = "1640712599", ["signslib:pos"] = "(-1348,64,959)", digged_nodes = "768977", placed_nodes = "288177", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", punch_count = "25794", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29822, [\"x\"] = 1949, [\"z\"] = 1608}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1640581842}", yl_commons_thankyou = "39", ["stamina:level"] = "18.725", xp = "855658", arenalib_infobox_arenaID = "0", inflicted_damage = "435650", crafted = "24579", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf_clan_idx"] = "1", ["petz:werewolf"] = "0", died = "57", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = dIRHJD7FmYIkBHmk7mnM23ZlBCOchvEN ``` Profiler save: ``` profile-20211231T002339.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=208543, max_lag=5.86679, clients={digdeep, DreamNotFound, Lucien, meatball, DangerousDan, Makenji, Sokomine, jackofthebean000, Lupercus, Bla, Boris, ccady, RIPBla, Violetta, karlbrock, Player305, LeetPeet, guestxmart, Bailiff, AliasAlreadyTaken, turtle, Service, flux} ``` Teleport command: ``` /teleport xyz 766 6 1995 ``` Compass command: ``` /give_compass Construction dIRHJD7FmYIkBHmk7mnM23ZlBCOchvEN D2691E 766 6 1995 ```

AliasAlreadyTaken was assigned by yourland-report

2021-12-30 23:23:39 +00:00

Styxcolor added the

1. kind/bug

label 2021-12-30 23:35:42 +00:00

Styxcolor commented

2022-01-01 08:46:38 +00:00

update: the party name did reappear after a while, but it should be back immediately, so that is still a bug.

Styxcolor referenced this issue

2022-01-03 02:51:47 +00:00

flux reports: when an evoker spots you in th ... #1262

flux added the

3. source/integration

4. step/want approval

labels 2022-05-22 19:15:16 +00:00

flux commented

2022-05-22 19:25:14 +00:00

@AliasAlreadyTaken the correct way to fix this, and several other name-related issues, is with a name monoid, which other mods would then depend upon and use if it's available. The name monoid in more_monoids which i wrote for blocky, is not flexible enough for our use cases - which include totally disappearing the tag, layout, and color - so i'll start work on something new.

@AliasAlreadyTaken the correct way to fix this, and several other name-related issues, is with a name monoid, which other mods would then depend upon and use if it's available. The name monoid in [more_monoids](https://github.com/BlockySurvival/more_monoids) which i wrote for blocky, is not flexible enough for our use cases - which include totally disappearing the tag, layout, and color - so i'll start work on something new.

flux commented

2022-05-23 18:12:35 +00:00

@AliasAlreadyTaken

I've got a working version of the name monoid now, with minimal changes to invisibility (the API redo for that has consequences to several more mods, and can be addressed later).

https://gitea.your-land.de/flux/name_monoid

However, this will require adding the mod to yourland-mods, and pushing changes to the following mods:

invisibility
mobs_balrog (which needs to correctly use the invisibility "API" as it is)
party
xp_redo (which has logic for showing level in the nametag, which we currently don't use, but see e.g. #308)
yl_nether_mobs (like mobs_balrog, the evoker needs to use the invisibility "API")

All of the changes are minor, and don't have a hard dependency on the name_monoid, so they could be pushed now without breaking anything. How would you prefer I proceed with this?

@AliasAlreadyTaken I've got a working version of the name monoid now, with minimal changes to invisibility (the API redo for that has consequences to several more mods, and can be addressed later). https://gitea.your-land.de/flux/name_monoid However, this will require adding the mod to yourland-mods, and pushing changes to the following mods: * invisibility * mobs_balrog (which needs to correctly use the invisibility "API" as it is) * party * xp_redo (which has logic for showing level in the nametag, which we currently don't use, but see e.g. #308) * yl_nether_mobs (like mobs_balrog, the evoker needs to use the invisibility "API") All of the changes are minor, and don't have a hard dependency on the name_monoid, so they could be pushed now without breaking anything. How would you prefer I proceed with this?

flux commented

2022-05-23 20:21:13 +00:00

I pushed the updates to mobs_balrog and yl_nether_mobs, as that was clearly just buggy behavior, and created three PRs for the other mods:

I pushed the updates to mobs_balrog and yl_nether_mobs, as that was clearly just buggy behavior, and created three PRs for the other mods: * https://gitea.your-land.de/your-land/invisibility/pulls/1 * https://gitea.your-land.de/your-land/party/pulls/1 * https://gitea.your-land.de/your-land/xp_redo/pulls/3

👍 1

AliasAlreadyTaken commented

2022-05-23 20:34:05 +00:00

Maybe you should publish your name_monoid, it might be useful for a lot of others who deal with the same problem. We simply can't be the only ones having to deal with mods competing over the player name.