LeetPeet reports: The date order in /info is dif ... #1240

New Issue

yourland-report · 2021-12-30T01:40:20Z

yourland-report commented

2021-12-30 01:40:20 +00:00

LeetPeet reports a bug:

The date order in /info is different from that of /last-login. In /info, it's d.m.y., but on /last-login, it's y.m.d. This can be confusing, and I thing we should instead have the m.d.y. format, meaning we change both of them.

Player position:

{
	y = 69.5,
	x = 61.059001922607,
	z = 21122.80078125
}

Player look:

{
	y = 0.49545869231224,
	x = 0.68894696235657,
	z = 0.52903002500534
}

Player information:

{
	min_rtt = 0.090999998152256,
	max_rtt = 3.7650001049042,
	connection_uptime = 8216,
	max_jitter = 3.6630001068115,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.18000000715256,
	state = "Active",
	avg_jitter = 0.084000006318092,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_rainbow 1 5264\", \"3d_armor:helmet_rainbow 1 5264\", \"3d_armor:chestplate_rainbow 1 5264\", \"3d_armor:boots_crystal 1 22200\", \"\", \"\"}",
		played_time = "2232021",
		yl_commons_player_joined = "1640820224",
		["signslib:pos"] = "(827,6,1997)",
		digged_nodes = "1252881",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "main",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 99, [\"x\"] = 27, [\"z\"] = 21108}, [\"last_heal\"] = 1630693112, [\"last_death_portal\"] = 1640264684}",
		["stamina:level"] = "13.85",
		punch_count = "7661",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "70890",
		crafted = "15076",
		xp = "1102422",
		yl_commons_thankyou = "11",
		died = "169",
		placed_nodes = "152478",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1609243939"
	}
}

Log identifier


[MOD] yl_report log identifier = ICriuTmq9MnT3kZhXFMikOlVJdC4g95r

Profiler save:

profile-20211230T024020.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=130422, max_lag=3.5503, clients={Lupercus, Bailiff, AliasAlreadyTaken, Service, ccady, Styxcolor, karlbrock, wishingirl, LeetPeet, kohai, Xonon, Sokomine, Oakenshield, flux}

Teleport command:

/teleport xyz 61 70 21123

Compass command:

/give_compass Construction ICriuTmq9MnT3kZhXFMikOlVJdC4g95r D2691E 61 70 21123

LeetPeet reports a bug: > The date order in /info is different from that of /last-login. In /info, it's d.m.y., but on /last-login, it's y.m.d. This can be confusing, and I thing we should instead have the m.d.y. format, meaning we change both of them. Player position: ``` { y = 69.5, x = 61.059001922607, z = 21122.80078125 } ``` Player look: ``` { y = 0.49545869231224, x = 0.68894696235657, z = 0.52903002500534 } ``` Player information: ``` { min_rtt = 0.090999998152256, max_rtt = 3.7650001049042, connection_uptime = 8216, max_jitter = 3.6630001068115, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.18000000715256, state = "Active", avg_jitter = 0.084000006318092, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:leggings_rainbow 1 5264\", \"3d_armor:helmet_rainbow 1 5264\", \"3d_armor:chestplate_rainbow 1 5264\", \"3d_armor:boots_crystal 1 22200\", \"\", \"\"}", played_time = "2232021", yl_commons_player_joined = "1640820224", ["signslib:pos"] = "(827,6,1997)", digged_nodes = "1252881", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "main", yl_church = "return {[\"last_death\"] = {[\"y\"] = 99, [\"x\"] = 27, [\"z\"] = 21108}, [\"last_heal\"] = 1630693112, [\"last_death_portal\"] = 1640264684}", ["stamina:level"] = "13.85", punch_count = "7661", arenalib_infobox_arenaID = "0", inflicted_damage = "70890", crafted = "15076", xp = "1102422", yl_commons_thankyou = "11", died = "169", placed_nodes = "152478", hud_state = "on", repellant = "0", yl_commons_player_created = "1609243939" } } ``` Log identifier ``` [MOD] yl_report log identifier = ICriuTmq9MnT3kZhXFMikOlVJdC4g95r ``` Profiler save: ``` profile-20211230T024020.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=130422, max_lag=3.5503, clients={Lupercus, Bailiff, AliasAlreadyTaken, Service, ccady, Styxcolor, karlbrock, wishingirl, LeetPeet, kohai, Xonon, Sokomine, Oakenshield, flux} ``` Teleport command: ``` /teleport xyz 61 70 21123 ``` Compass command: ``` /give_compass Construction ICriuTmq9MnT3kZhXFMikOlVJdC4g95r D2691E 61 70 21123 ```

AliasAlreadyTaken was assigned by yourland-report

2021-12-30 01:40:20 +00:00

Styxcolor added the

1. kind/enhancement

label 2021-12-30 01:41:01 +00:00

Styxcolor commented

2021-12-30 01:43:48 +00:00

it might be a good idea to unify the formats - but we shouldn't go for the American format and take d/m/y as standard for the future.

flux commented

2022-01-03 21:50:23 +00:00

the american format is m/d/y. the international format is y/m/d. i highly advocate for the international format.

https://en.wikipedia.org/wiki/ISO_8601

the american format is m/d/y. the international format is y/m/d. i highly advocate for the international format. https://en.wikipedia.org/wiki/ISO_8601

AliasAlreadyTaken commented

2022-05-12 00:10:37 +00:00

+1 for international format.

Lucky the /last-login format is already in this format and we control the /info one.

Fixed in c065c03a71

+1 for international format. Lucky the /last-login format is already in this format and we control the /info one. Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/c065c03a71f961b43db89b4724bc362956b895a3

AliasAlreadyTaken closed this issue

2022-05-12 00:10:38 +00:00

AliasAlreadyTaken added the

5. result/fixed

label 2022-05-12 00:10:44 +00:00

AliasAlreadyTaken added this to the 1.1.111 milestone 2022-05-12 00:10:47 +00:00

Sign in to join this conversation.