ThinkSome reports: why are there 3 separate "Mixi ... #119

New Issue

yourland-report · 2020-12-11T01:48:14Z

yourland-report commented

2020-12-11 01:48:14 +00:00

ThinkSome reports a bug:

why are there 3 separate "Mixing" and "Crafting" recipes for 1 coal lump -> 4 black dye?

Player position:

{
	y = 15.5,
	x = 2112.4001464844,
	z = 1145.0200195313
}

Player look:

{
	y = -0.34365969896317,
	x = -0.91420739889145,
	z = 0.21476218104362
}

Log identifier


[MOD] yl_report log identifier = rVC9s1jk3IfRW8uv5NvWcOgZ6ainjOh0

Profiler save:

profile-20201211T024814.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=14908.4, max_lag=0.840135, clients={ForceLoadSome, ThinkSome}

ThinkSome reports a bug: ``` why are there 3 separate "Mixing" and "Crafting" recipes for 1 coal lump -> 4 black dye? ``` Player position: ``` { y = 15.5, x = 2112.4001464844, z = 1145.0200195313 } ``` Player look: ``` { y = -0.34365969896317, x = -0.91420739889145, z = 0.21476218104362 } ``` Log identifier ``` [MOD] yl_report log identifier = rVC9s1jk3IfRW8uv5NvWcOgZ6ainjOh0 ``` Profiler save: ``` profile-20201211T024814.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=14908.4, max_lag=0.840135, clients={ForceLoadSome, ThinkSome} ```

AliasAlreadyTaken was assigned by yourland-report

2020-12-11 01:48:14 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2020-12-11 10:07:19 +00:00

AliasAlreadyTaken commented

2020-12-11 12:32:40 +00:00

That's probably due to recipes not overwriting each other properly. I will investigate. Thanks!

AliasAlreadyTaken commented

2021-07-18 09:45:42 +00:00

One comes out of the bakedclay mod

Styxcolor self-assigned this 2021-11-03 01:01:56 +00:00

Styxcolor commented

2021-11-03 01:03:03 +00:00

This contradicts issue #556
Has this one been overcorrected?

This contradicts issue #556 Has this one been overcorrected?

Styxcolor added the

4. step/question

label 2021-11-03 01:03:12 +00:00

Styxcolor added

2. prio/low

and removed

4. step/question

labels 2021-11-04 21:15:17 +00:00

Styxcolor commented

2021-11-04 21:17:48 +00:00

Talked with Alias about it. This is indeed a bug, but it is not very harmful, as at the end of the day, you get the black dye. But it is of course a redundancy and we will fix it. The low prio label comes due to this issue having no impact on the game, rather being an issue of aesthetics.

Styxcolor commented

2021-11-04 21:18:29 +00:00

The other issue is not really a duplicate and was a language problem on my side. Coal is from minig coal, charcoal is the coal you get from trees. We talked about that issue, too. More about it there.

Styxcolor added the

4. step/at work

label 2021-11-04 21:18:40 +00:00

Styxcolor commented

2021-11-04 21:19:22 +00:00

my plan for this bugfix: find the 3 different mods that assign a recipe for coal to black dye, check the code and see what can or should be fixed to not have three different displays.

Styxcolor commented

2021-11-04 21:55:00 +00:00

so black dye is originally defined in the dye mod from the standard game.

bakedclay\init.lua
line 126 ff.
bakedclay:dye:black defines the second black dye recipe that is equal to the first.

the third crafting recipe seems to sit in unifieddyes\dyes-crafting.lua
line 186

that one is a monster though and seems to look more like a table than anything.

so black dye is originally defined in the dye mod from the standard game. bakedclay\init.lua line 126 ff. bakedclay:dye:black defines the second black dye recipe that is equal to the first. the third crafting recipe seems to sit in unifieddyes\dyes-crafting.lua line 186 that one is a monster though and seems to look more like a table than anything.

Styxcolor commented

2021-11-04 22:27:51 +00:00

with a workaround thought up by Alias we could at least remove one of the three recipes. We can indeed not touch the table, but most likely the default recipe got cut using the clear_craft function on input instead of output.