ElvenEmpreror reports: An informal survey concluded ( ... #1082

New Issue

yourland-report · 2021-11-21T20:43:48Z

yourland-report commented

2021-11-21 20:43:48 +00:00

ElvenEmpreror reports a bug:

An informal survey concluded (n=2) that a stack size of 100 would be far cooler than a stack size of 99

Player position:

{
	y = -427.4990234375,
	x = 2126.8591308594,
	z = 1601.1719970703
}

Player look:

{
	y = -0.22325012087822,
	x = -0.54013156890869,
	z = 0.81142914295197
}

Player information:

{
	min_rtt = 0.028000000864267,
	max_rtt = 0.52499997615814,
	connection_uptime = 10447,
	max_jitter = 0.49399998784065,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.035000000149012,
	state = "Active",
	avg_jitter = 0.010999999940395,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		played_time = "24444",
		jointime = "1636913325",
		yl_commons_player_joined = "1637517044",
		digged_nodes = "2212",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_small\"}",
		["stamina:level"] = "11.6",
		punch_count = "151",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1770",
		crafted = "214",
		xp = "2746",
		placed_nodes = "541",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1636913325"
	}
}

Log identifier


[MOD] yl_report log identifier = ThTCOwqpj7OIcvGX2uzG16IsMHqtPp2X

Profiler save:

profile-20211121T214347.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=116051, max_lag=14.1519, clients={ccady, Kur, Gooey_Honey, khan, jakob, Bla, Apocralypse, Sokomine, Lichberry, Velvet, Lucien, Cutieplayz, KayKay, Lazalatin, ElvenEmpreror, Quailgianna, bizon, Boot, Empempires, Bailiff, servo, Service, AliasAlreadyTaken}

Teleport command:

/teleport xyz 2127 -427 1601

Compass command:

/give_compass Construction ThTCOwqpj7OIcvGX2uzG16IsMHqtPp2X D2691E 2127 -427 1601

ElvenEmpreror reports a bug: > An informal survey concluded (n=2) that a stack size of 100 would be far cooler than a stack size of 99 Player position: ``` { y = -427.4990234375, x = 2126.8591308594, z = 1601.1719970703 } ``` Player look: ``` { y = -0.22325012087822, x = -0.54013156890869, z = 0.81142914295197 } ``` Player information: ``` { min_rtt = 0.028000000864267, max_rtt = 0.52499997615814, connection_uptime = 10447, max_jitter = 0.49399998784065, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.035000000149012, state = "Active", avg_jitter = 0.010999999940395, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", played_time = "24444", jointime = "1636913325", yl_commons_player_joined = "1637517044", digged_nodes = "2212", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_small\"}", ["stamina:level"] = "11.6", punch_count = "151", arenalib_infobox_arenaID = "0", inflicted_damage = "1770", crafted = "214", xp = "2746", placed_nodes = "541", hud_state = "on", repellant = "0", yl_commons_player_created = "1636913325" } } ``` Log identifier ``` [MOD] yl_report log identifier = ThTCOwqpj7OIcvGX2uzG16IsMHqtPp2X ``` Profiler save: ``` profile-20211121T214347.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=116051, max_lag=14.1519, clients={ccady, Kur, Gooey_Honey, khan, jakob, Bla, Apocralypse, Sokomine, Lichberry, Velvet, Lucien, Cutieplayz, KayKay, Lazalatin, ElvenEmpreror, Quailgianna, bizon, Boot, Empempires, Bailiff, servo, Service, AliasAlreadyTaken} ``` Teleport command: ``` /teleport xyz 2127 -427 1601 ``` Compass command: ``` /give_compass Construction ThTCOwqpj7OIcvGX2uzG16IsMHqtPp2X D2691E 2127 -427 1601 ```

AliasAlreadyTaken was assigned by yourland-report

2021-11-21 20:43:48 +00:00

Styxcolor added the

1. kind/enhancement

label 2021-11-21 22:08:33 +00:00

Styxcolor self-assigned this 2021-11-21 22:08:44 +00:00

Styxcolor commented

2021-11-21 22:09:46 +00:00

...if we wanted to implement that, would that mean we would have to change the stack size of every single item? Or is there something like one master command to change that on a deeper level like changing the default for it?

Styxcolor added the

3. source/mod upstream

label 2021-12-18 05:22:07 +00:00

Styxcolor commented

2021-12-18 05:22:18 +00:00

I suspect that is a thing upstream

Styxcolor added this to the (deleted) project 2021-12-20 11:22:02 +00:00

flux commented

2022-01-03 22:54:38 +00:00

there is a setting for this:
1965628705/builtin/settingtypes.txt (L1150)

however, setting the stack max to 100 causes issues for players using small screens (phones) - the stack amounts extend into adjacent inventory cells.

also, there's some advantages to using a multiple of 9, as it makes it easy to evenly convert e.g. a stack of iron ingots into iron blocks, with nothing left over.

there is a setting for this: https://github.com/minetest/minetest/blob/196562870552b156265feb83043da2bc21bd6246/builtin/settingtypes.txt#L1150 however, setting the stack max to 100 causes issues for players using small screens (phones) - the stack amounts extend into adjacent inventory cells. also, there's some advantages to using a multiple of 9, as it makes it easy to evenly convert e.g. a stack of iron ingots into iron blocks, with nothing left over.

AliasAlreadyTaken commented

2022-01-06 04:47:59 +00:00

The small screen reason is valid, so is the "multpile of nine" one.

Also, I wouldn't be surprised if MT relied on stacks of 99 in one place or another. And if not MT itself, then most likely one of the bazillion mods.

Changing this would require extensive testing for little gain. Unless a very good reason crops up why we should do that, I'd say we won't fix.

The small screen reason is valid, so is the "multpile of nine" one. Also, I wouldn't be surprised if MT relied on stacks of 99 in one place or another. And if not MT itself, then most likely one of the bazillion mods. Changing this would require extensive testing for little gain. Unless a very good reason crops up why we should do that, I'd say we won't fix.

AliasAlreadyTaken closed this issue

2022-01-06 04:47:59 +00:00

AliasAlreadyTaken added the

5. result/wontfix

label 2022-01-06 04:48:27 +00:00

AliasAlreadyTaken removed this from the (deleted) project 2022-01-06 04:48:31 +00:00

flux commented

2022-05-02 16:48:59 +00:00

Also, I wouldn't be surprised if MT relied on stacks of 99 in one place or another. And if not MT itself, then most likely one of the bazillion mods.

MT engine does just fine w/ other stack sizes; the mods are a different story. I think I've fixed issues w/ non-standard stack sizes w/ e.g. unified_inventory_plus.

> Also, I wouldn't be surprised if MT relied on stacks of 99 in one place or another. And if not MT itself, then most likely one of the bazillion mods. MT engine does just fine w/ other stack sizes; the mods are a different story. I think I've fixed issues w/ non-standard stack sizes w/ e.g. unified_inventory_plus.

flux referenced this issue

2023-12-25 17:27:29 +00:00

Jammy reports: please make the stack size 100 ... #5824

Sign in to join this conversation.