Bla reports: unify nets to catch mobs, eith ... #1039

New Issue

yourland-report · 2021-11-12T19:47:29Z

yourland-report commented

2021-11-12 19:47:29 +00:00

Bla reports a bug:

unify nets to catch mobs, either reduce to 1 net or a group:nets

Player position:

{
	y = 42.5,
	x = -3301.7360839844,
	z = 3447.7219238281
}

Player look:

{
	y = -0.16487546265125,
	x = 0.87029701471329,
	z = 0.46411117911339
}

Player information:

{
	min_rtt = 0.032000001519918,
	max_rtt = 1.1729999780655,
	connection_uptime = 3371,
	max_jitter = 1.0859999656677,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-02292e03e-dirty",
	avg_rtt = 0.079999998211861,
	state = "Active",
	avg_jitter = 0.0019999966025352,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:enchanted_leggings_mithril_strong 1 25996\", \"3d_armor:boots_crystal 1 22405\", \"3d_armor:enchanted_helmet_mithril_strong 1 25996\", \"3d_armor:enchanted_chestplate_mithril_strong 1 25996\", \"shields:shield_crystal 1 5080\", \"\"}",
		yl_commons_thankyou = "21",
		jointime = "1635266646",
		yl_commons_player_joined = "1636743100",
		["signslib:pos"] = "(30927,2,30926)",
		digged_nodes = "53091",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 117, [\"x\"] = 15264, [\"z\"] = 15192}, [\"last_heal\"] = 1635970005, [\"last_death_portal\"] = 1636697670}",
		["stamina:level"] = "18",
		xp = "31972",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "43110",
		crafted = "2676",
		punch_count = "2880",
		died = "25",
		played_time = "640647",
		placed_nodes = "7397",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1635266646"
	}
}

Log identifier


[MOD] yl_report log identifier = g6Ip3VQLNxYbGCImU1lJLUDeRij5KQZS

Profiler save:

profile-20211112T204729.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=4825.44, max_lag=4.36961, clients={LeniOwO, kathi, BFF, Imhotheb, befe11, bizon, Bailiff, GrimPixel, ccady, Anaconda, attila, Bla, Grey, _DRAGON_, AliasAlreadyTaken, Service}

Teleport command:

/teleport xyz -3302 43 3448

Compass command:

/give_compass Construction g6Ip3VQLNxYbGCImU1lJLUDeRij5KQZS D2691E -3302 43 3448

Bla reports a bug: > unify nets to catch mobs, either reduce to 1 net or a group:nets Player position: ``` { y = 42.5, x = -3301.7360839844, z = 3447.7219238281 } ``` Player look: ``` { y = -0.16487546265125, x = 0.87029701471329, z = 0.46411117911339 } ``` Player information: ``` { min_rtt = 0.032000001519918, max_rtt = 1.1729999780655, connection_uptime = 3371, max_jitter = 1.0859999656677, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-02292e03e-dirty", avg_rtt = 0.079999998211861, state = "Active", avg_jitter = 0.0019999966025352, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:enchanted_leggings_mithril_strong 1 25996\", \"3d_armor:boots_crystal 1 22405\", \"3d_armor:enchanted_helmet_mithril_strong 1 25996\", \"3d_armor:enchanted_chestplate_mithril_strong 1 25996\", \"shields:shield_crystal 1 5080\", \"\"}", yl_commons_thankyou = "21", jointime = "1635266646", yl_commons_player_joined = "1636743100", ["signslib:pos"] = "(30927,2,30926)", digged_nodes = "53091", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 117, [\"x\"] = 15264, [\"z\"] = 15192}, [\"last_heal\"] = 1635970005, [\"last_death_portal\"] = 1636697670}", ["stamina:level"] = "18", xp = "31972", arenalib_infobox_arenaID = "0", inflicted_damage = "43110", crafted = "2676", punch_count = "2880", died = "25", played_time = "640647", placed_nodes = "7397", hud_state = "on", repellant = "0", yl_commons_player_created = "1635266646" } } ``` Log identifier ``` [MOD] yl_report log identifier = g6Ip3VQLNxYbGCImU1lJLUDeRij5KQZS ``` Profiler save: ``` profile-20211112T204729.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=4825.44, max_lag=4.36961, clients={LeniOwO, kathi, BFF, Imhotheb, befe11, bizon, Bailiff, GrimPixel, ccady, Anaconda, attila, Bla, Grey, _DRAGON_, AliasAlreadyTaken, Service} ``` Teleport command: ``` /teleport xyz -3302 43 3448 ``` Compass command: ``` /give_compass Construction g6Ip3VQLNxYbGCImU1lJLUDeRij5KQZS D2691E -3302 43 3448 ```

AliasAlreadyTaken was assigned by yourland-report

2021-11-12 19:47:29 +00:00

Styxcolor added the

1. kind/enhancement

label 2021-11-13 13:32:19 +00:00

Styxcolor self-assigned this 2021-11-13 13:32:23 +00:00

Styxcolor added the

ugh/petz

label 2021-11-13 13:36:11 +00:00

Styxcolor commented

2021-11-14 08:41:09 +00:00

We're talking about mobs:net and fireflies:bug_net?
Or is mobs:lasso included?

We're talking about mobs:net and fireflies:bug_net? Or is mobs:lasso included?

Styxcolor removed the

ugh/petz

label 2021-11-14 08:41:16 +00:00

Styxcolor added the

4. step/question

label 2021-11-14 08:43:01 +00:00

Bla commented

2021-11-14 10:19:45 +00:00

Yes those 2 nets and not the lasso.
This issue might change from "balancing" to bug.

I couldn´t catch water_life:piranha with my mobs:net yesterday, had a short glimpse at the piranha catch code that it needs the fireflies:bug_net.

Looked again today to answer here and noticed that piranha and snakes are both from water_life but snakes are catchable by mobs:net and piranhas not.
Turns out water_life supports the mobs:net but piranhas doesn´t use it while snakes do.

Nonetheless nets should either be unified or have a consistent rule which one to use.

Yes those 2 nets and not the lasso. This issue might change from "balancing" to bug. I couldn´t catch water_life:piranha with my mobs:net yesterday, had a short glimpse at the [piranha catch code](https://github.com/berengma/water_life/blob/f089c5066e0a61896c0c366275c7048993282fe6/animals/piranha.lua#L127) that it needs the fireflies:bug_net. Looked again today to answer here and noticed that piranha and snakes are both from water_life but snakes are catchable by mobs:net and piranhas not. Turns out [water_life supports](https://github.com/berengma/water_life/blob/f089c5066e0a61896c0c366275c7048993282fe6/init.lua#L86) the mobs:net but [piranhas](https://github.com/berengma/water_life/blob/f089c5066e0a61896c0c366275c7048993282fe6/animals/piranha.lua#L127) doesn´t use it while [snakes](https://github.com/berengma/water_life/blob/f089c5066e0a61896c0c366275c7048993282fe6/animals/snake.lua#L234) do. Nonetheless nets should either be unified or have a consistent rule which one to use.

Styxcolor removed the

4. step/question

label 2021-11-14 18:24:54 +00:00

Styxcolor commented

2021-11-14 18:25:22 +00:00

Wow, thanks for explaining! That sounds like quite the frustrating experience indeed. I'd also have used the "wrong" net for the piranha.

Styxcolor added

1. kind/bug

and removed

1. kind/enhancement

labels 2021-11-14 18:25:41 +00:00

Styxcolor commented

2021-11-15 15:28:43 +00:00

Took a look at the issue again and was overwhelmed with the amount of mob mod submodules I was greeted with. We need a comparative list of all mobs in YL and then go through each of them to tweak their capture settings. I don't have anything against several types of nets if they were working predictably like the bugnet really only for bugs. But for accessibility it might really be better to have one single net and no experiences like having to guess the net and fail.

I might take Alias mob drop list and work from there. You'll hear from me again.

Took a look at the issue again and was overwhelmed with the amount of mob mod submodules I was greeted with. We need a comparative list of all mobs in YL and then go through each of them to tweak their capture settings. I don't have anything against several types of nets if they were working predictably like the bugnet really only for bugs. But for accessibility it might really be better to have one single net and no experiences like having to guess the net and fail. I might take Alias mob drop list and work from there. You'll hear from me again.

Styxcolor added the

4. step/at work

label 2021-11-15 15:28:54 +00:00

Bla commented

2021-11-18 19:34:38 +00:00

petz code for catching an animal doesnt support item_groups currently.
See #1061

petz code for catching an animal doesnt support item_groups currently. See #1061

Styxcolor commented

2021-12-16 18:06:49 +00:00

our decision is here,
we will integrate the fireflies bugnet into the other net, so the red net wins.
We must check every animal affected by the blue net so that you can still catch them with the red one later. But this change is coming.

our decision is here, we will integrate the fireflies bugnet into the other net, so the red net wins. We must check every animal affected by the blue net so that you can still catch them with the red one later. But this change is coming.

AliasAlreadyTaken was unassigned by Styxcolor

2021-12-16 18:07:01 +00:00

Styxcolor added

1. kind/enhancement

and removed

1. kind/bug

labels 2021-12-16 18:07:10 +00:00

Styxcolor added this to the (deleted) project 2022-01-06 22:05:43 +00:00

Styxcolor removed this from the (deleted) project 2022-01-28 00:27:34 +00:00

Styxcolor removed the

4. step/at work

label 2022-01-28 00:27:40 +00:00