your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

vector.lua:59: attempt to index local 'b' (a nil value) #1028

New Issue
Closed
opened 2021-11-10 01:02:18 +00:00 by AliasAlreadyTaken · 7 comments
AliasAlreadyTaken commented 2021-11-10 01:02:18 +00:00
Owner
Copy Link

2021-11-10 02:00:35: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'water_life' in callback luaentity_Step(): ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: attempt to index local 'b' (a nil value)
2021-11-10 02:00:35: ERROR[Main]: stack traceback:
2021-11-10 02:00:35: ERROR[Main]: ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: in function 'dist2tgt'
2021-11-10 02:00:35: ERROR[Main]: /home/mtlive1/.minetest/mods/water_life/behaviors.lua:1226: in function 'func'
2021-11-10 02:00:35: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:621: in function 'execute_queues'
2021-11-10 02:00:35: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:848: in function 'func'
2021-11-10 02:00:35: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:106: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>

2021-11-10 02:00:35: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'water_life' in callback luaentity_Step(): ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: attempt to index local 'b' (a nil value) 2021-11-10 02:00:35: ERROR[Main]: stack traceback: 2021-11-10 02:00:35: ERROR[Main]: ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: in function 'dist2tgt' 2021-11-10 02:00:35: ERROR[Main]: /home/mtlive1/.minetest/mods/water_life/behaviors.lua:1226: in function 'func' 2021-11-10 02:00:35: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:621: in function 'execute_queues' 2021-11-10 02:00:35: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:848: in function 'func' 2021-11-10 02:00:35: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:106: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2021-11-10 01:02:57 +00:00
Styxcolor commented 2021-11-10 08:11:40 +00:00
Owner
Copy Link

Wait a moment.
These stem from water_life, too:

#972
#896
#396

Wait a moment. These stem from water_life, too: #972 #896 #396
AliasAlreadyTaken was assigned by Styxcolor 2021-11-10 08:11:50 +00:00
AliasAlreadyTaken commented 2021-11-14 05:57:41 +00:00
Author
Owner
Copy Link

2021-11-14 03:59:49: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'water_life' in callback luaentity_Step(): ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: attempt to index local 'b' (a nil value)
2021-11-14 03:59:49: ERROR[Main]: stack traceback:
2021-11-14 03:59:49: ERROR[Main]: ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: in function 'dist2tgt'
2021-11-14 03:59:49: ERROR[Main]: /home/mtlive1/.minetest/mods/water_life/behaviors.lua:1226: in function 'func'
2021-11-14 03:59:49: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:621: in function 'execute_queues'
2021-11-14 03:59:49: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:848: in function 'func'
2021-11-14 03:59:49: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:106: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
2021-11-14 04:01:06: WARNING[Main]: system-wide share not found at "/usr/local/share/minetest"

2021-11-14 03:59:49: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'water_life' in callback luaentity_Step(): ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: attempt to index local 'b' (a nil value) 2021-11-14 03:59:49: ERROR[Main]: stack traceback: 2021-11-14 03:59:49: ERROR[Main]: ...ve1/5.4.1/Minetest_live/bin/../builtin/common/vector.lua:59: in function 'dist2tgt' 2021-11-14 03:59:49: ERROR[Main]: /home/mtlive1/.minetest/mods/water_life/behaviors.lua:1226: in function 'func' 2021-11-14 03:59:49: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:621: in function 'execute_queues' 2021-11-14 03:59:49: ERROR[Main]: /home/mtlive1/.minetest/mods/mobkit/init.lua:848: in function 'func' 2021-11-14 03:59:49: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:106: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> 2021-11-14 04:01:06: WARNING[Main]: system-wide share not found at "/usr/local/share/minetest"
Styxcolor commented 2021-11-15 15:37:48 +00:00
Owner
Copy Link

The server crashes must end. Let's start and hopefully finish operation "snake lobotomy" this week. Even if the waterlife snake mob gets dumber as a result, that is better than returning a nil in some abstract attack vector thing and crashing the server.

The server crashes must end. Let's start and hopefully finish operation "snake lobotomy" this week. Even if the waterlife snake mob gets dumber as a result, that is better than returning a nil in some abstract attack vector thing and crashing the server.
Styxcolor commented 2021-11-15 15:45:42 +00:00
Owner
Copy Link

this is the function in question
function water_life.hq_snake_warn(self,target,prty,duration,anim)
anim = anim or 'warn'
local init = true

local func=function(self)
	if init then 
		mobkit.make_sound(self,"warn")
		minetest.after(1,function(anim)
			mobkit.animate(self,anim)
		end,anim)
		init=false
	end
	local yaw = water_life.get_yaw_to_object(self,target)
	self.object:set_yaw(yaw)
	duration = duration-self.dtime
    
	local dist = water_life.dist2tgt(self,target) --this line brings our server down
	
    if  dist > self.view_range then
		minetest.after(3,function()
			return true
		end)
	end
	if duration <= 0 or dist < 4 then
		mobkit.remember(self,"warned",target:get_player_name())
		return true
	end
end
mobkit.queue_high(self,func,prty)

end

this is the function in question function water_life.hq_snake_warn(self,target,prty,duration,anim) anim = anim or 'warn' local init = true local func=function(self) if init then mobkit.make_sound(self,"warn") minetest.after(1,function(anim) mobkit.animate(self,anim) end,anim) init=false end local yaw = water_life.get_yaw_to_object(self,target) self.object:set_yaw(yaw) duration = duration-self.dtime local dist = water_life.dist2tgt(self,target) --this line brings our server down if dist > self.view_range then minetest.after(3,function() return true end) end if duration <= 0 or dist < 4 then mobkit.remember(self,"warned",target:get_player_name()) return true end end mobkit.queue_high(self,func,prty) end
Styxcolor commented 2021-11-15 15:47:41 +00:00
Owner
Copy Link

unfortunately this goes way beyond my current horizon, as I first have to look into what the mobkit is and how it works.

unfortunately this goes way beyond my current horizon, as I first have to look into what the mobkit is and how it works.
AliasAlreadyTaken commented 2021-11-18 02:44:27 +00:00
Author
Owner
Copy Link

Good news, we have a repro.

5.5.0-dev or 5.4.1, water_life 211111 and latest mobkit from content db, one MT instance a server, one a client

  1. Replace water_life.dist2tgt with the following in api.lua line ~210
-- distance from self to target
function water_life.dist2tgt(self,tgt)
	core.log("action","self="..dump(self))
	core.log("action","tgt="..dump(tgt))
	local pos = mobkit.get_stand_pos(self)
	local tpos = tgt:get_pos()
	local thp = tgt:get_hp()
	core.log("action","pos="..dump(pos))
	core.log("action","tpos="..dump(tpos))
	core.log("action","thp="..dump(thp))
	return vector.distance(pos,tpos)
end
  1. Enable water_life and mobkit on one instance of MT, lets call it MT1
  2. Start the server on MT1
  3. Start a client on the other instance, lets call it MT2
  4. grant all, get some snakes and release them on MT2
  5. Walk up to the snake on MT2 and match the hq_snake_warn conditions: dist > 4 and dist < self.view_range and not action
  6. As soon as it warns, log out with MT2.

BOOM!

=>

2021-11-18 03:05:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'water_life' in callback luaentity_Step(): ...5.5.0-dev/minetest-test/bin/../builtin/common/vector.lua:116: attempt to index local 'b' (a nil value)
2021-11-18 03:05:21: ERROR[Main]: stack traceback:
2021-11-18 03:05:21: ERROR[Main]: 	...5.5.0-dev/minetest-test/bin/../builtin/common/vector.lua:116: in function 'dist2tgt'
2021-11-18 03:05:21: ERROR[Main]: 	...0-dev/minetest-test/bin/../mods/water_life/behaviors.lua:1225: in function 'func'
2021-11-18 03:05:21: ERROR[Main]: 	...test/5.5.0-dev/minetest-test/bin/../mods/mobkit/init.lua:621: in function 'execute_queues'
2021-11-18 03:05:21: ERROR[Main]: 	...test/5.5.0-dev/minetest-test/bin/../mods/mobkit/init.lua:848: in function <...test/5.5.0-dev/minetest-test/bin/../mods/mobkit/init.lua:825>

But why? We obviously have a playerobject. Only that its get_pos() returns nil when logging out??

That's what the debug says:

2021-11-18 03:18:57: ACTION[Server]: pos={
	y = 18.510999679789,
	x = -316.15753173828,
	z = -411.00021362305
}
2021-11-18 03:18:57: ACTION[Server]: tpos=nil
2021-11-18 03:18:57: ACTION[Server]: thp=1

Try it yourself, you may take a couple of attempts to log out the right moment, but its a 100% repro over here by now. No lag or other mods involved but mtg, mobkit and water_life :)

Good news, we have a repro. > 5.5.0-dev or 5.4.1, water_life 211111 and latest mobkit from content db, one MT instance a server, one a client 1. Replace water_life.dist2tgt with the following in api.lua line ~210 ``` -- distance from self to target function water_life.dist2tgt(self,tgt) core.log("action","self="..dump(self)) core.log("action","tgt="..dump(tgt)) local pos = mobkit.get_stand_pos(self) local tpos = tgt:get_pos() local thp = tgt:get_hp() core.log("action","pos="..dump(pos)) core.log("action","tpos="..dump(tpos)) core.log("action","thp="..dump(thp)) return vector.distance(pos,tpos) end ``` 2. Enable water_life and mobkit on one instance of MT, lets call it MT1 3. Start the server on MT1 4. Start a client on the other instance, lets call it MT2 5. grant all, get some snakes and release them on MT2 6. Walk up to the snake on MT2 and match the hq_snake_warn conditions: dist > 4 and dist < self.view_range and not action 7. As soon as it warns, log out with MT2. BOOM! => ``` 2021-11-18 03:05:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'water_life' in callback luaentity_Step(): ...5.5.0-dev/minetest-test/bin/../builtin/common/vector.lua:116: attempt to index local 'b' (a nil value) 2021-11-18 03:05:21: ERROR[Main]: stack traceback: 2021-11-18 03:05:21: ERROR[Main]: ...5.5.0-dev/minetest-test/bin/../builtin/common/vector.lua:116: in function 'dist2tgt' 2021-11-18 03:05:21: ERROR[Main]: ...0-dev/minetest-test/bin/../mods/water_life/behaviors.lua:1225: in function 'func' 2021-11-18 03:05:21: ERROR[Main]: ...test/5.5.0-dev/minetest-test/bin/../mods/mobkit/init.lua:621: in function 'execute_queues' 2021-11-18 03:05:21: ERROR[Main]: ...test/5.5.0-dev/minetest-test/bin/../mods/mobkit/init.lua:848: in function <...test/5.5.0-dev/minetest-test/bin/../mods/mobkit/init.lua:825> ``` But why? We obviously have a playerobject. Only that its get_pos() returns nil when logging out?? That's what the debug says: ``` 2021-11-18 03:18:57: ACTION[Server]: pos={ y = 18.510999679789, x = -316.15753173828, z = -411.00021362305 } 2021-11-18 03:18:57: ACTION[Server]: tpos=nil 2021-11-18 03:18:57: ACTION[Server]: thp=1 ``` Try it yourself, you may take a couple of attempts to log out the right moment, but its a 100% repro over here by now. No lag or other mods involved but mtg, mobkit and water_life :)
AliasAlreadyTaken added this to the 1.1.100 milestone 2021-11-18 02:44:41 +00:00
AliasAlreadyTaken commented 2021-11-18 02:51:40 +00:00
Author
Owner
Copy Link

Fixed in 1e28fc84d386217c17ca10dd330c8fc2c0269bb0

Fixed in 1e28fc84d386217c17ca10dd330c8fc2c0269bb0
AliasAlreadyTaken added the
5. result/fixed
 label 2021-11-18 02:51:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.100
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1028
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?