Sandwiches peanut doesn't grow #1009
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#1009
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Eraldemay brought up that you can't find the peanuts from the sandwiches mod anywhere in the wild...so you can't craft sandwiches items that rely on peanuts in the recipe.
I suggested making it a group with cucina vegana peanuts that can be easily obtained - so that you can use these in the recipe, too.
Got a greenlight from Annalysa to proceed.
Solution: creating group from "cucina_vegana:peanut" and "sandwiches:peanuts" or registering the first as alias for recipes of the latter. I will have to look into how this works. According to the documentation alias is rather meant for renaming things, while to me it seems only the group solution makes you actually use them interchangeably.
recipes in cucina_vegana affected:
cucina_vegana:peanut_butter
cucina_vegana:edamame
recipes in sandwiches affected:
sandwiches:peanut_butter
Fixed in
commit aa35e782b79248a021a7549dfdc9cde238f3b3e2
noticed that you don't get a glass bottle back when you consume cucina'vegana's peanut butter. Couldn't fix immediately due to peanut butter being defined in a table in cucina vegana's register mods. The on_use function breaks the consumability of the item if I try to assign the "vessels:glass_bottle" as variable. Will open a separate issue for that.
Rest is tested and works!
New issue: #1010