your-land/yl_cinema
21
0
Fork 2
generated from your-land/yl_template
Code Issues 1 Pull Requests 2 Packages Projects Releases Wiki Activity

Allow multiple captions with configurable position and color (+documentation and cleanup) #3

Open
GreenXenith wants to merge 2 commits from GreenXenith/yl_cinema:captions into master
pull from: GreenXenith/yl_cinema:captions
merge into: your-land:master
Conversation 1 Commits 2 Files Changed 162 +296 -1617
GreenXenith commented 2024-09-05 09:14:52 +02:00
First-time contributor
Copy Link

Now uses a list of caption definitions, each with text, x, y, fgcolor, and bgcolor. Legacy captions are still supported but not recommended.
Added dev testing data for captions, and cleaned up existing test data.
Documented JSON and file structure.

Now uses a list of caption definitions, each with `text`, `x`, `y`, `fgcolor`, and `bgcolor`. Legacy captions are still supported but not recommended. Added dev testing data for captions, and cleaned up existing test data. Documented JSON and file structure.
GreenXenith added 1 commit 2024-09-05 09:14:52 +02:00
AliasAlreadyTaken requested review from AliasAlreadyTaken 2024-09-07 23:43:08 +02:00
AliasAlreadyTaken commented 2024-09-08 11:43:54 +02:00
Owner
Copy Link

QA in progress

Way better:

  1. license and version attribute
  2. multiple placeable captions

Crash:
When using the rotating screen (yl_cinema:bigscreen_base) there's a crash: your-land/yl_cinema#5

QA in progress Way better: 1. license and version attribute 2. *multiple* placeable captions Crash: When using the rotating screen (yl_cinema:bigscreen_base) there's a crash: your-land/yl_cinema#5
GreenXenith added 1 commit 2024-09-09 02:05:54 +02:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u captions:GreenXenith-captions
git checkout GreenXenith-captions
Sign in to join this conversation.
Reviewers
No reviewers
AliasAlreadyTaken
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/yl_cinema#3
No description provided.
Delete Branch "GreenXenith/yl_cinema:captions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?