WollKhan reports: Please make backpacks of all s ... #852

New Issue

yourland-report · 2021-08-21T17:34:59Z

yourland-report commented

2021-08-21 17:34:59 +00:00

WollKhan reports a bug:

Please make backpacks of all sizes stackable. having to put them in the crafting grid individually, and waiting half a second for the server to confirm the recipe, is really annoying.

Player position:

{
	y = 2.5,
	x = 12945.5,
	z = 46.527000427246
}

Player look:

{
	y = -0.33380687236786,
	x = -0.18277069926262,
	z = -0.92475289106369
}

Player information:

{
	min_rtt = 0.016000000759959,
	max_rtt = 0.67699998617172,
	connection_uptime = 15762,
	max_jitter = 0.65399998426437,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.020999999716878,
	state = "Active",
	avg_jitter = 0.0010000001639128,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_steel 1 20400\", \"3d_armor:boots_crystal 1 1100\", \"\", \"\", \"\", \"\"}",
		played_time = "255748",
		jointime = "1628993533",
		yl_commons_player_joined = "1629551580",
		digged_nodes = "43191",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 2, [\"x\"] = 12956, [\"z\"] = 67}}",
		["stamina:level"] = "5",
		punch_count = "218",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "3656",
		crafted = "36881",
		xp = "56031",
		placed_nodes = "15935",
		died = "8",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1628993533"
	}
}

Log identifier


[MOD] yl_report log identifier = LUUKmFsGZPKrLTvdPkKsYcs8d4tR4vkh

Profiler save:

profile-20210821T193458.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=256280, max_lag=3.87683, clients={City_Builder, jakob, Imhotheb, flux, Runy, Jackcity, Burnhard, WollKhan, Morphelia, Machtrollo, Annalysa, phillip, Arabella, LeniOwO, Service, Boot, AliasAlreadyTaken, Bailiff}

Teleport command:

/teleport xyz 12946 3 47

Compass command:

/give_compass Construction LUUKmFsGZPKrLTvdPkKsYcs8d4tR4vkh D2691E 12946 3 47

WollKhan reports a bug: > Please make backpacks of all sizes stackable. having to put them in the crafting grid individually, and waiting half a second for the server to confirm the recipe, is really annoying. Player position: ``` { y = 2.5, x = 12945.5, z = 46.527000427246 } ``` Player look: ``` { y = -0.33380687236786, x = -0.18277069926262, z = -0.92475289106369 } ``` Player information: ``` { min_rtt = 0.016000000759959, max_rtt = 0.67699998617172, connection_uptime = 15762, max_jitter = 0.65399998426437, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.020999999716878, state = "Active", avg_jitter = 0.0010000001639128, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_steel 1 20400\", \"3d_armor:boots_crystal 1 1100\", \"\", \"\", \"\", \"\"}", played_time = "255748", jointime = "1628993533", yl_commons_player_joined = "1629551580", digged_nodes = "43191", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_church = "return {[\"last_death\"] = {[\"y\"] = 2, [\"x\"] = 12956, [\"z\"] = 67}}", ["stamina:level"] = "5", punch_count = "218", arenalib_infobox_arenaID = "0", inflicted_damage = "3656", crafted = "36881", xp = "56031", placed_nodes = "15935", died = "8", hud_state = "on", repellant = "0", yl_commons_player_created = "1628993533" } } ``` Log identifier ``` [MOD] yl_report log identifier = LUUKmFsGZPKrLTvdPkKsYcs8d4tR4vkh ``` Profiler save: ``` profile-20210821T193458.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=256280, max_lag=3.87683, clients={City_Builder, jakob, Imhotheb, flux, Runy, Jackcity, Burnhard, WollKhan, Morphelia, Machtrollo, Annalysa, phillip, Arabella, LeniOwO, Service, Boot, AliasAlreadyTaken, Bailiff} ``` Teleport command: ``` /teleport xyz 12946 3 47 ``` Compass command: ``` /give_compass Construction LUUKmFsGZPKrLTvdPkKsYcs8d4tR4vkh D2691E 12946 3 47 ```

👍 2

AliasAlreadyTaken was assigned by yourland-report

2021-08-21 17:34:59 +00:00

Styxcolor added the

1. kind/enhancement

label 2021-11-03 04:02:03 +00:00

AliasAlreadyTaken added the

3. source/mod upstream

label 2022-01-19 07:33:37 +00:00

flux added the

4. step/want approval

label 2022-04-07 15:50:08 +00:00

flux added this to the flux's TODO list project 2022-07-02 18:48:05 +00:00

flux referenced this issue

2022-12-13 17:19:58 +00:00

Laylem reports: petz:christmas_present can't s ... #3231

AliasAlreadyTaken added the

4. step/approved

label 2023-12-08 23:47:23 +00:00

AliasAlreadyTaken commented

2023-12-08 23:48:48 +00:00

If anyone chooses to implement this, please do it upstream.

DragonWrangler commented

2023-12-10 21:14:48 +00:00

Alias: I'll implement this (upstream).

DragonWrangler commented

2023-12-10 21:28:31 +00:00

ok pr made. now i'm just waiting for it to get merged.

AliasAlreadyTaken commented

2023-12-10 22:34:28 +00:00

Upstream PR https://github.com/minetest-mods/unified_inventory/pull/237

DragonWrangler commented

2023-12-11 17:42:56 +00:00

looks like this might not get implemented.

see https://github.com/minetest-mods/unified_inventory/pull/237#issuecomment-1850562513

looks like this might not get implemented. see https://github.com/minetest-mods/unified_inventory/pull/237#issuecomment-1850562513

Boot commented

2023-12-11 19:45:05 +00:00

Bags are some kind of life time investment. Just craft them once and have them until the end of the server. So not a big deal to have them like they are now.

flux commented

2023-12-12 19:49:39 +00:00

Bags are some kind of life time investment. Just craft them once and have them until the end of the server. So not a big deal to have them like they are now.

the main reason why i support stackable bags is so that i can store more of them in a smartshop. admittedly, i only have to refill my shop once every couple months as it is.

i also commented on the PR - the fix is not quite that trivial.

> Bags are some kind of life time investment. Just craft them once and have them until the end of the server. So not a big deal to have them like they are now. the main reason why i support stackable bags is so that i can store more of them in a smartshop. admittedly, i only have to refill my shop once every couple months as it is. i also commented on the PR - the fix is not quite that trivial.

👍 1

Boot commented

2023-12-12 19:58:43 +00:00

Right, for a shop stackable bags are much better. Same for croco bags I sell.

DragonWrangler commented

2023-12-13 01:57:26 +00:00

flux: I tested and the bag slots only allow for one bag in them.

DragonWrangler commented

2023-12-13 02:12:01 +00:00

If anyone wants to test it. Here is the link to my fork of unified_inventory. https://github.com/DragonWrangler1/minetest-unified_inventory

👍 1

DragonWrangler commented

2023-12-25 02:57:01 +00:00

pr rejected

😕 1

flux commented

2023-12-25 04:36:57 +00:00

i'm still slightly in favor of this, but i think alias should make the final decision about whether we should do this in integration or reject it.

AliasAlreadyTaken commented

2023-12-25 16:08:56 +00:00

I don't see why not. If we can stack up solid rock, then we can also stack up fluffy backpacks.

So: Yes.

I don't see why not. If we can stack up solid rock, then we can also stack up fluffy backpacks. So: Yes.

😆 1

flux referenced this issue from a commit

2023-12-25 18:50:21 +00:00

your-land/bugtracker#852 make unified inventory bags stackable

flux commented

2023-12-25 18:51:03 +00:00

implemented: 8cb1fcaacd

for future reference, weird things happen if you fail to clear the metatable on the old definition...

implemented: https://gitea.your-land.de/your-land/yl_commons/commit/8cb1fcaacd1aa5ec57280079075e215f93065b84 for future reference, weird things happen if you fail to clear the metatable on the old definition...

flux added

4. step/ready to QA test

and removed

4. step/want approval

labels 2023-12-25 18:52:28 +00:00

AliasAlreadyTaken added this to the 1.1.123 milestone 2023-12-25 20:44:56 +00:00

flux commented

2023-12-27 20:45:39 +00:00

new upstream PR: https://github.com/minetest-mods/unified_inventory/pull/241

our integration code will not break if/when that gets accepted.

new upstream PR: https://github.com/minetest-mods/unified_inventory/pull/241 our integration code will not break if/when that gets accepted.

AliasAlreadyTaken added the

ugh/QA OK

label 2024-01-28 14:31:35 +00:00

AliasAlreadyTaken added

ugh/QA NOK

and removed

ugh/QA OK

labels 2024-01-28 14:32:47 +00:00

AliasAlreadyTaken commented

2024-01-28 14:42:17 +00:00

QA

Although the bags now stack up to 99, you can also stack them in the bags tab of the inventory.

Repro:

If you already have a bag in the slot:

Remove items from old, unstackable bag
Remove the bag from the bags slot

If you don't have a bag in the slot or removed it:

drag a stack of stackable bag into the slot
= only ONE bag will be added to the slot
drag a stack of stackable bag into the slot again
= another ONE bag will be added to the bag already in the slot

QA Although the bags now stack up to 99, you can also stack them in the bags tab of the inventory. Repro: If you already have a bag in the slot: 1. Remove items from old, unstackable bag 2. Remove the bag from the bags slot If you don't have a bag in the slot or removed it: 1. drag a stack of stackable bag into the slot = only ONE bag will be added to the slot 2. drag a stack of stackable bag into the slot again = another ONE bag will be added to the bag already in the slot ![grafik](/attachments/733ed27d-263a-403d-9179-f8ba37c32de7)

grafik.png

105 KiB

👍 2

flux commented

2024-02-02 05:29:15 +00:00

i haven't fixed the stacking issue yet, but i'm also noting that if you get more than one bag into a bag slot, and then remove one of them, the bag inventory can be viewed, but you can't modify it.

😆 1

AliasAlreadyTaken commented

2024-02-23 13:34:10 +00:00

Let's hope they eventually pull flux' fix and my addition:

https://github.com/minetest-mods/unified_inventory/pull/241#issuecomment-1961335588

diff --git a/bags.lua b/bags.lua
index f6d4da6..8936ebc 100644
--- a/bags.lua
+++ b/bags.lua
@@ -195,7 +195,9 @@ minetest.register_on_joinplayer(function(player)
                        if not new_slots then
                                return 0 -- ItemStack is not a bag.
                        end
-
+                       if not inv:is_empty(listname) then
+                               return 0 -- Disallow put when bag present
+                       end
:...skipping...
diff --git a/bags.lua b/bags.lua
index f6d4da6..8936ebc 100644
--- a/bags.lua
+++ b/bags.lua

While the stacking issue can be solved in integration, this one cannot :/

Until they do, we'll fix in the yl_stable branch of unified_inventory

Let's hope they eventually pull flux' fix and my addition: https://github.com/minetest-mods/unified_inventory/pull/241#issuecomment-1961335588 ``` diff --git a/bags.lua b/bags.lua index f6d4da6..8936ebc 100644 --- a/bags.lua +++ b/bags.lua @@ -195,7 +195,9 @@ minetest.register_on_joinplayer(function(player) if not new_slots then return 0 -- ItemStack is not a bag. end - + if not inv:is_empty(listname) then + return 0 -- Disallow put when bag present + end :...skipping... diff --git a/bags.lua b/bags.lua index f6d4da6..8936ebc 100644 --- a/bags.lua +++ b/bags.lua ``` While the stacking issue can be solved in integration, this one cannot :/ Until they do, we'll fix in the yl_stable branch of unified_inventory

AliasAlreadyTaken referenced this issue from a commit

2024-02-23 13:57:20 +00:00

your-land/bugtracker#852 temporary until upstream pulls https://github.com/minetest-mods/unified_inventory/pull/241

AliasAlreadyTaken removed the

ugh/QA NOK

label 2024-02-23 14:12:54 +00:00

whosit commented

2024-02-23 18:57:34 +00:00

If you take a stack of bags and "spread" it by dragging over multiple slots, including the bag slot, you can still put more than one.

whosit added the

ugh/QA NOK

label 2024-02-23 18:57:47 +00:00

whosit commented

2024-02-23 19:00:03 +00:00

even worse, I managed to dupe them somehow O_O

(I started with one stack)

UPD: oh... it's a client-server desync, when I take them from the bag slot I get only one?!?
what?

even worse, I managed to dupe them somehow O_O ![bags](/attachments/8423b551-0b64-4f57-8603-f2c71427c4dd) (I started with one stack) UPD: oh... it's a client-server desync, when I take them from the bag slot I get only one?!? what?

изображение.png

33 KiB

whosit commented

2024-02-23 19:08:07 +00:00

So... since glitch is only visual, should it be considered "OK"?

Sokomine commented

2024-02-25 04:32:46 +00:00

Bags for selling...that is something where the NPC can help: They can craft items for trade if they ran out of stock. So you wouldn't even have to craft a ton but could just give the NPC one or two and let it craft new ones whenever the existing ones are bought. NPCs can craft only one item each time they display the trade list. And of course they need wool and string in their inventory.

AliasAlreadyTaken commented

2024-02-25 05:55:48 +00:00

So... since glitch is only visual, should it be considered "OK"?

I tried to reproduce it, but couldn't. If my "fix" is wrong, I need to know how it should have been done instead:

9c8da921b1

> So... since glitch is only visual, should it be considered "OK"? I tried to reproduce it, but couldn't. If my "fix" is wrong, I need to know how it should have been done instead: https://gitea.your-land.de/your-land/unified_inventory/commit/9c8da921b1a1fc15985a2d0f76e65ae906f739c6

whosit commented

2024-02-25 06:42:35 +00:00

Still same on current -dev version....

This dragging/distributing feature is pretty new, so...

But since it does not persist after reconnect and you can only take one bag from that slot - I think this issue can be considered OK and desync problem can go into it's own issue.

Still same on current -dev version.... This dragging/distributing feature is pretty new, so... But since it does not persist after reconnect and you can only take one bag from that slot - I think this issue can be considered OK and desync problem can go into it's own issue.

whosit added

ugh/QA OK

and removed

ugh/QA NOK

labels 2024-02-25 06:43:06 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-27 00:02:43 +00:00

flux commented

2024-03-27 00:02:49 +00:00