your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

"num_emerge_threads > 1" results in mapgen glitches at mablock borders due to lack of synchronization #850

New Issue
Open
opened 2021-08-20 04:46:52 +00:00 by AliasAlreadyTaken · 10 comments
AliasAlreadyTaken commented 2021-08-20 04:46:52 +00:00
Owner
Copy Link

This bug (and not biome_lib) is responsible for cut off trees and 1 block high planes underground and 1 block spaced air in the nether.

Related:

#254
#682
#741
#687
#728
#730

Most likely, MOST of the construction tasks originate from this issue.

https://gitea.your-land.de/your-land/bugtracker/issues?q=&type=all&sort=&state=open&labels=30&milestone=0&assignee=0

The problem had been reported over a year ago:

https://github.com/minetest/minetest/issues/9357

This bug (and not biome_lib) is responsible for cut off trees and 1 block high planes underground and 1 block spaced air in the nether. Related: #254 #682 #741 #687 #728 #730 Most likely, MOST of the construction tasks originate from this issue. https://gitea.your-land.de/your-land/bugtracker/issues?q=&type=all&sort=&state=open&labels=30&milestone=0&assignee=0 The problem had been reported over a year ago: https://github.com/minetest/minetest/issues/9357
AliasAlreadyTaken added the
1. kind/bug
3. source/mod upstream
 labels 2021-08-20 04:47:54 +00:00
flux commented 2022-01-05 00:34:02 +00:00
Member
Copy Link

An older upstream issue:

https://github.com/minetest/minetest/issues/5618

An older upstream issue: https://github.com/minetest/minetest/issues/5618
flux added
3. source/engine
 and removed
3. source/mod upstream
 labels 2022-05-29 02:52:27 +00:00
flux added the
2. prio/elevated
 label 2022-08-05 23:56:24 +00:00
flux changed title from num_emerge_threads > 1 create 1 block high flats to "num_emerge_threads > 1" results in mapgen glitches at mablock borders due to lack of synchronization 2022-08-06 00:17:13 +00:00
flux commented 2022-08-06 00:18:38 +00:00
Member
Copy Link

@AliasAlreadyTaken the new server is very fast - perhaps there wouldn't be a huge problem if we set num_emerge_threads = 1? mapgen would still happen in a separate thread.

@AliasAlreadyTaken the new server is very fast - perhaps there wouldn't be a huge problem if we set `num_emerge_threads = 1`? mapgen would still happen in a separate thread.
👍 1
sixer commented 2023-08-16 17:19:55 +00:00
Copy Link

This is happening even after num_emerge_threads = 1, or that was never set? Or there were lot of similar errors created in the past, when that value was higher?

This is happening even after `num_emerge_threads = 1`, or that was never set? Or there were lot of similar errors created in the past, when that value was higher?
flux commented 2023-08-16 17:26:12 +00:00
Member
Copy Link

This is happening even after num_emerge_threads = 1, or that was never set? Or there were lot of similar errors created in the past, when that value was higher?

correct, this happens even when num_emerge_threads = 1, though we've gone back to the default. it depends on the order in which chunks are generated.

> This is happening even after `num_emerge_threads = 1`, or that was never set? Or there were lot of similar errors created in the past, when that value was higher? correct, this happens even when `num_emerge_threads = 1`, though we've gone back to the default. it depends on the order in which chunks are generated.
AliasAlreadyTaken commented 2023-08-16 20:28:00 +00:00
Author
Owner
Copy Link

Means: There is no point in keeping that value at 1 ?

There are works underway to move the lua mapgen stuff to some async env

Means: There is no point in keeping that value at 1 ? There are works underway to move the lua mapgen stuff to some async env
flux commented 2023-08-16 20:32:02 +00:00
Member
Copy Link

Means: There is no point in keeping that value at 1 ?

There are works underway to move the lua mapgen stuff to some async env

i don't think the lua mapgen stuff will help with this problem. most of the affected trees are schematics registered as decorations.

> Means: There is no point in keeping that value at 1 ? > > There are works underway to move the lua mapgen stuff to some async env i don't think the lua mapgen stuff will help with this problem. most of the affected trees are schematics registered as decorations.
sixer commented 2023-08-16 21:59:21 +00:00
Copy Link

Question is, if setting the value to more than 1 would not make things worse than now (i.e. the underlying problem occurring more often)

Question is, if setting the value to more than 1 would not make things worse than now (i.e. the underlying problem occurring more often)
flux commented 2023-08-17 00:14:08 +00:00
Member
Copy Link

Question is, if setting the value to more than 1 would not make things worse than now (i.e. the underlying problem occurring more often)

my current understanding of the problem is that it's completely independent of the number of mapgen threads.

> Question is, if setting the value to more than 1 would not make things worse than now (i.e. the underlying problem occurring more often) my current understanding of the problem is that it's completely independent of the number of mapgen threads.
flux commented 2023-08-17 01:11:04 +00:00
Member
Copy Link

then again, i feel like it's been really common in the last couple weeks? so i dunno.

then again, i feel like it's been *really* common in the last couple weeks? so i dunno.
sixer commented 2023-08-17 07:35:34 +00:00
Copy Link

Well, how common it is is heavily influenced by how much people are exploring (and finding blocks that were generated for them or generated in past and more or less unnoticed). I personally am exploring quite a lot in last couple of weeks and people like Chache also likely have exploration-heavy playstyle. So this could be the cause why those errors are now encountered more often?

Well, how common it is is heavily influenced by how much people are exploring (and finding blocks that were generated for them or generated in past and more or less unnoticed). I personally am exploring quite a lot in last couple of weeks and people like Chache also likely have exploration-heavy playstyle. So this could be the cause why those errors are now encountered more often?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#850
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?