AliasAlreadyTaken reports: Adding skins with dash in them ... #7459

New Issue

yourland-report · 2024-09-28T03:54:13+02:00

yourland-report commented

2024-09-28 03:54:13 +02:00

AliasAlreadyTaken reports a bug:

Adding skins with dash in them results in "invalid skin name"

Player position:

{
	x = 2983.9741210938,
	y = 1.375,
	z = -2724.8881835938
}

Player look:

{
	x = 0.49956664443016,
	y = -0.20210361480713,
	z = 0.84237003326416
}

Player information:

{
	formspec_version = 7,
	min_rtt = 0.016000000759959,
	min_jitter = 0,
	max_jitter = 0.14000000059605,
	avg_jitter = 0,
	lang_code = "de",
	patch = 0,
	max_rtt = 0.15600000321865,
	major = 5,
	version_string = "5.10.0-yl-debug-4ac86db8e",
	protocol_version = 43,
	state = "Active",
	avg_rtt = 0.017000000923872,
	minor = 10,
	connection_uptime = 2287,
	serialization_version = 29,
	ip_version = 6
}

Player meta:

{
	fields = {
		szutil_watch = "return {}",
		["arena_lib_editor.spawner_ID"] = "0",
		partychat = "party",
		["petz:werewolf_vignette_id"] = "19",
		arenalib_watchID = "0",
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"3d_armor:boots_quickrun\"}",
		partypvp = "true",
		punch_count = "65406",
		hotbar_size = "16",
		inflicted_damage = "3037856",
		["signslib:pos"] = "(1977,15,1171)",
		yl_commons_thankyou = "1927",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		["petz:werewolf_clan_idx"] = "4",
		["hud_manager:spawnit:hud_enabled"] = "y",
		["ocean_build.last_warning"] = "1.67421e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["stamina:level"] = "0",
		lagometer = "1",
		hud_state = "on",
		["stamina:exhaustion"] = "0.5",
		["arena_lib_editor.players_number"] = "0",
		played_time = "120717176",
		digged_nodes = "145734",
		placed_nodes = "186409",
		arenalib_infobox_arenaID = "0",
		crafted = "4832",
		team = "STAFF",
		bitten = "0",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		xp_redo_hud_color = "0xFFFF00",
		yl_audio_state = "off",
		yl_commons_player_joined = "1727486170",
		["ethereal:fly_timer"] = "-99",
		repellant = "0",
		died = "1593",
		xp = "0",
		["arena_lib_editor.team_ID"] = "0",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 18, [\"z\"] = 1174, [\"x\"] = 1979}, [\"last_death_portal\"] = 1714631995, [\"last_heal\"] = 1707613077}"
	}
}

Log identifier


[MOD] yl_report log identifier = AgA8TXHbA9i6lEantoLgyo0VgO9weWEs

Profiler save:

profile-20240928T015413.json_prettyEE

Status:

# Server: version: 5.8.0-yl-debug | game: Minetest Game | uptime: 38min 54s | max lag: 0.257s | clients (8/52): AliasAlreadyTaken, Dark-Side, daydream, Jammy, Parrish, poppyasdan, RPiManiac, VK

Teleport command:

/teleport xyz 2984 1 -2725

Compass command:

/give_compass Construction AgA8TXHbA9i6lEantoLgyo0VgO9weWEs D2691E 2984 1 -2725

AliasAlreadyTaken reports a bug: > Adding skins with dash in them results in "invalid skin name" Player position: ``` { x = 2983.9741210938, y = 1.375, z = -2724.8881835938 } ``` Player look: ``` { x = 0.49956664443016, y = -0.20210361480713, z = 0.84237003326416 } ``` Player information: ``` { formspec_version = 7, min_rtt = 0.016000000759959, min_jitter = 0, max_jitter = 0.14000000059605, avg_jitter = 0, lang_code = "de", patch = 0, max_rtt = 0.15600000321865, major = 5, version_string = "5.10.0-yl-debug-4ac86db8e", protocol_version = 43, state = "Active", avg_rtt = 0.017000000923872, minor = 10, connection_uptime = 2287, serialization_version = 29, ip_version = 6 } ``` Player meta: ``` { fields = { szutil_watch = "return {}", ["arena_lib_editor.spawner_ID"] = "0", partychat = "party", ["petz:werewolf_vignette_id"] = "19", arenalib_watchID = "0", ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"3d_armor:boots_quickrun\"}", partypvp = "true", punch_count = "65406", hotbar_size = "16", inflicted_damage = "3037856", ["signslib:pos"] = "(1977,15,1171)", yl_commons_thankyou = "1927", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", ["petz:werewolf_clan_idx"] = "4", ["hud_manager:spawnit:hud_enabled"] = "y", ["ocean_build.last_warning"] = "1.67421e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["stamina:level"] = "0", lagometer = "1", hud_state = "on", ["stamina:exhaustion"] = "0.5", ["arena_lib_editor.players_number"] = "0", played_time = "120717176", digged_nodes = "145734", placed_nodes = "186409", arenalib_infobox_arenaID = "0", crafted = "4832", team = "STAFF", bitten = "0", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", xp_redo_hud_color = "0xFFFF00", yl_audio_state = "off", yl_commons_player_joined = "1727486170", ["ethereal:fly_timer"] = "-99", repellant = "0", died = "1593", xp = "0", ["arena_lib_editor.team_ID"] = "0", yl_church = "return {[\"last_death\"] = {[\"y\"] = 18, [\"z\"] = 1174, [\"x\"] = 1979}, [\"last_death_portal\"] = 1714631995, [\"last_heal\"] = 1707613077}" } } ``` Log identifier ``` [MOD] yl_report log identifier = AgA8TXHbA9i6lEantoLgyo0VgO9weWEs ``` Profiler save: ``` profile-20240928T015413.json_prettyEE ``` Status: ``` # Server: version: 5.8.0-yl-debug | game: Minetest Game | uptime: 38min 54s | max lag: 0.257s | clients (8/52): AliasAlreadyTaken, Dark-Side, daydream, Jammy, Parrish, poppyasdan, RPiManiac, VK ``` Teleport command: ``` /teleport xyz 2984 1 -2725 ``` Compass command: ``` /give_compass Construction AgA8TXHbA9i6lEantoLgyo0VgO9weWEs D2691E 2984 1 -2725 ```

AliasAlreadyTaken was assigned by yourland-report

2024-09-28 03:54:13 +02:00

AliasAlreadyTaken added the

1. kind/bug

3. source/mod upstream

labels 2024-09-28 03:54:30 +02:00

AliasAlreadyTaken commented

2024-09-28 03:55:02 +02:00

To reproduce, do in a running server:

//lua local myname = "singleplayer" local path = mymod.worldpath .. "my_skins/textures/" local filename= "player.has-dash.0.png" local a,b = skins.register_skin(path, filename)  core.chat_send_player(myname, dump(a)..","..dump(b))

or in some mod during loadtime. Server version is 5.8.0, all other skins work nicely, even those with underscores.

To reproduce, do in a running server: ``` //lua local myname = "singleplayer" local path = mymod.worldpath .. "my_skins/textures/" local filename= "player.has-dash.0.png" local a,b = skins.register_skin(path, filename) core.chat_send_player(myname, dump(a)..","..dump(b)) ``` or in some mod during loadtime. Server version is 5.8.0, all other skins work nicely, even those with underscores.

AliasAlreadyTaken commented

2024-09-28 04:02:10 +02:00

Upstream issue: https://github.com/minetest-mods/skinsdb/issues/110

Case with dash missing from their unittests

Upstream issue: https://github.com/minetest-mods/skinsdb/issues/110 Case with dash missing from their unittests

AliasAlreadyTaken commented

2024-09-28 04:26:52 +02:00

In skinlist.lua line 9 the pattern

	local prefix, sep, identifier, extension = filename:match("^(%a+)([_.])([%w_.]+)%.(%a+)$")

doesn't hit dashes. Maybe instead this?

	local prefix, sep, identifier, extension = filename:match("^(%a+)([_.])([%w_.-]+)%.(%a+)$")

Seems to work with the cases I tested, but not sure, whether really really suitable.

In skinlist.lua line 9 the pattern ``` local prefix, sep, identifier, extension = filename:match("^(%a+)([_.])([%w_.]+)%.(%a+)$") ``` doesn't hit dashes. Maybe instead this? ``` local prefix, sep, identifier, extension = filename:match("^(%a+)([_.])([%w_.-]+)%.(%a+)$") ``` Seems to work with the cases I tested, but not sure, whether really really suitable.

AliasAlreadyTaken commented

2024-09-28 14:55:16 +02:00

Wow, quickly fixed upstream. Thank you, SmallJoker :)

AliasAlreadyTaken added the

4. step/ready to QA test

label 2024-09-28 14:55:24 +02:00

AliasAlreadyTaken added this to the 1.1.126 milestone 2024-09-28 14:55:26 +02:00

AliasAlreadyTaken added the

4. step/QA OK

label 2024-11-22 18:13:02 +01:00

AliasAlreadyTaken closed this issue

2025-03-17 15:51:33 +01:00