debian44 reports: You can put an electrumese axe ... #710

New Issue

yourland-report · 2021-07-15T12:41:44Z

yourland-report commented

2021-07-15 12:41:44 +00:00

debian44 reports a bug:

You can put an electrumese axe into a nodebreaker by doing shift + leftclick on the axe

Player position:

{
	y = 2.5,
	x = -1513.5579833984,
	z = 1606.8000488281
}

Player look:

{
	y = -0.29720824956894,
	x = -0.40608683228493,
	z = -0.86415320634842
}

Player information:

{
	min_rtt = 0.027000000700355,
	max_rtt = 0.20100000500679,
	connection_uptime = 187,
	max_jitter = 0.16699999570847,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.037000000476837,
	state = "Active",
	avg_jitter = 0.0080000013113022,
	min_jitter = 0,
	address = "::ffff:80.141.108.33"
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 15680\", \"3d_armor:leggings_crystal 1 15680\", \"3d_armor:boots_crystal 1 15680\", \"3d_armor:helmet_crystal 1 15680\", \"shields:shield_crystal 1 15680\", \"\"}",
		["petz:werewolf_vignette_id"] = "15",
		played_time = "2093179",
		jointime = "1618588574",
		yl_commons_player_joined = "1626352743",
		["signslib:pos"] = "(2044,17,1187)",
		digged_nodes = "355311",
		["petz:werewolf"] = "1",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		punch_count = "17017",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -14263, [\"x\"] = 3011, [\"z\"] = 4027}, [\"last_heal\"] = 1622882700, [\"last_death_portal\"] = 1626112529}",
		yl_commons_thankyou = "19",
		["stamina:level"] = "17.65",
		xp = "245854",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "191704",
		crafted = "32786",
		["petz:werewolf_clan_idx"] = "3",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		placed_nodes = "138645",
		died = "190",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1618588574"
	}
}

Log identifier


[MOD] yl_report log identifier = mjtk6LXQGglKs04YkLp2mbxNRvinN0Fj

Profiler save:

profile-20210715T144144.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=54653.9, max_lag=2.37276, clients={Moji, Boris, LeniOwO, jakob, Hasbro, tour, Artruc, anime_girl, GrimPixel, isa, AliasAlreadyTaken, Service, Arabella, debian44, abhinav, Bailiff}

debian44 reports a bug: > You can put an electrumese axe into a nodebreaker by doing shift + leftclick on the axe Player position: ``` { y = 2.5, x = -1513.5579833984, z = 1606.8000488281 } ``` Player look: ``` { y = -0.29720824956894, x = -0.40608683228493, z = -0.86415320634842 } ``` Player information: ``` { min_rtt = 0.027000000700355, max_rtt = 0.20100000500679, connection_uptime = 187, max_jitter = 0.16699999570847, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.037000000476837, state = "Active", avg_jitter = 0.0080000013113022, min_jitter = 0, address = "::ffff:80.141.108.33" } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_crystal 1 15680\", \"3d_armor:leggings_crystal 1 15680\", \"3d_armor:boots_crystal 1 15680\", \"3d_armor:helmet_crystal 1 15680\", \"shields:shield_crystal 1 15680\", \"\"}", ["petz:werewolf_vignette_id"] = "15", played_time = "2093179", jointime = "1618588574", yl_commons_player_joined = "1626352743", ["signslib:pos"] = "(2044,17,1187)", digged_nodes = "355311", ["petz:werewolf"] = "1", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", punch_count = "17017", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = -14263, [\"x\"] = 3011, [\"z\"] = 4027}, [\"last_heal\"] = 1622882700, [\"last_death_portal\"] = 1626112529}", yl_commons_thankyou = "19", ["stamina:level"] = "17.65", xp = "245854", arenalib_infobox_arenaID = "0", inflicted_damage = "191704", crafted = "32786", ["petz:werewolf_clan_idx"] = "3", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", placed_nodes = "138645", died = "190", hud_state = "on", repellant = "0", yl_commons_player_created = "1618588574" } } ``` Log identifier ``` [MOD] yl_report log identifier = mjtk6LXQGglKs04YkLp2mbxNRvinN0Fj ``` Profiler save: ``` profile-20210715T144144.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=54653.9, max_lag=2.37276, clients={Moji, Boris, LeniOwO, jakob, Hasbro, tour, Artruc, anime_girl, GrimPixel, isa, AliasAlreadyTaken, Service, Arabella, debian44, abhinav, Bailiff} ```

AliasAlreadyTaken was assigned by yourland-report

2021-07-15 12:41:44 +00:00

AliasAlreadyTaken added the

1. kind/bug

4. step/question

labels 2021-07-15 15:04:52 +00:00

AliasAlreadyTaken commented

2021-07-15 15:04:59 +00:00

Cannot reproduce

flux commented

2022-01-05 01:37:38 +00:00

I cannot reproduce this either, but I can get one in there if i use an injector.

flux added the

4. step/want approval

label 2022-04-07 15:19:04 +00:00

AliasAlreadyTaken added the

4. step/approved

label 2022-04-28 05:49:42 +00:00

flux removed the

4. step/want approval

label 2022-05-04 22:53:33 +00:00

flux commented

2022-05-04 22:55:18 +00:00

cf. #1701

flux added the

3. source/integration

label 2022-05-04 22:55:44 +00:00

AliasAlreadyTaken commented

2022-05-05 14:16:30 +00:00

What do we do? There's no group "building blocks", for which this mechanic was intended. We could

add such a group and then limit the electrumese pick to this group. Whitelist.
disallow placement of tools and similar. Blacklist.
find which target blocks create problems and specialcase them.

What do we do? There's no group "building blocks", for which this mechanic was intended. We could - add such a group and then limit the electrumese pick to this group. Whitelist. - disallow placement of tools and similar. Blacklist. - find which target blocks create problems and specialcase them.

flux commented

2022-05-25 01:09:16 +00:00

The "fix" that I'm planning to do here, is to keep it from being put into the node breaker and similar machines via tubes. I hate working on pipeworks, and I haven't heard of anyone exploiting this recently, but I do want to get to it eventually.

flux self-assigned this 2022-05-30 23:16:31 +00:00

flux commented

2022-06-06 22:21:54 +00:00

fixed in a34317f3bd and ef4b09fc5b

i'm not sure this was signed off on anywhere, but i implemented a whitelist of tool/craftitems that can be put into the breaker/deployer, and added most of the "normal" tools. it was too time-consuming to try to test every item and blacklist it if there was a crash. if players feel that something is missing, they can of course request that it be added back, after we test it.

it's also possible that some "node" type has insane left/right click behavior defined that will still cause a crash, but i think this'll catch most of it.

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/a34317f3bdbf5c5101844e2e1864e402db194230 and https://gitea.your-land.de/your-land/yl_commons/commit/ef4b09fc5b6f6c168f0eccae3065305a802dc83a i'm not sure this was signed off on anywhere, but i implemented a whitelist of tool/craftitems that can be put into the breaker/deployer, and added most of the "normal" tools. it was too time-consuming to try to test every item and blacklist it if there was a crash. if players feel that something is missing, they can of course request that it be added back, after we test it. it's also possible that some "node" type has insane left/right click behavior defined that will still cause a crash, but i think this'll catch most of it.

flux added

4. step/ready to QA test

and removed

4. step/approved

labels 2022-06-06 22:22:03 +00:00

AliasAlreadyTaken added this to the 1.1.112 milestone 2022-06-07 10:11:14 +00:00

flux added

5. result/fixed

and removed

4. step/question

4. step/ready to QA test

labels 2022-06-07 16:05:07 +00:00