Xonon reports: while sitting in a chair, it i ... #685

New Issue

yourland-report · 2021-07-03T06:26:16Z

yourland-report commented

2021-07-03 06:26:16 +00:00

Xonon reports a bug:

while sitting in a chair, it is possible to clip through a block 2 spaces above you

Player position:

{
	y = 5.5,
	x = 3777.5270996094,
	z = 2315.4841308594
}

Player look:

{
	y = -0.15471038222313,
	x = -0.73477447032928,
	z = -0.66043257713318
}

Player information:

{
	min_rtt = 0.1870000064373,
	max_rtt = 12.081000328064,
	connection_uptime = 14567,
	max_jitter = 11.782000541687,
	minor = 3,
	major = 5,
	ip_version = 6,
	formspec_version = 3,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.3.0",
	avg_rtt = 0.266999989748,
	state = "Active",
	avg_jitter = 0.074999988079071,
	min_jitter = 0,
	address = "::ffff:50.34.122.230"
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 7880\", \"3d_armor:chestplate_crystal 1 7880\", \"3d_armor:leggings_crystal 1 7880\", \"3d_armor:boots_crystal 1 7880\", \"shields:shield_crystal 1 7880\", \"\"}",
		played_time = "420442",
		jointime = "1621665541",
		yl_commons_player_joined = "1625279060",
		["signslib:pos"] = "(2044,17,1187)",
		digged_nodes = "78760",
		bitten = "0",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"x\"] = 3978, [\"z\"] = 3300}, [\"last_death_portal\"] = 1625026636}",
		["stamina:level"] = "15",
		punch_count = "4570",
		arenalib_infobox_arenaID = "0",
		crafted = "5566",
		yl_commons_thankyou = "1",
		xp = "69228",
		placed_nodes = "19677",
		died = "9",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621665541"
	}
}

Log identifier


[MOD] yl_report log identifier = 6Cn0Xi984adVA46I9V1fOLaHUWi3UdY4

Profiler save:

profile-20210703T082616.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=213713, max_lag=2.14279, clients={AliasAlreadyTaken, Service, whostand, Bailiff, DeepDweller, Hasbro, whosit, Xonon, Bingo, Sandra, noodles}

Xonon reports a bug: > while sitting in a chair, it is possible to clip through a block 2 spaces above you Player position: ``` { y = 5.5, x = 3777.5270996094, z = 2315.4841308594 } ``` Player look: ``` { y = -0.15471038222313, x = -0.73477447032928, z = -0.66043257713318 } ``` Player information: ``` { min_rtt = 0.1870000064373, max_rtt = 12.081000328064, connection_uptime = 14567, max_jitter = 11.782000541687, minor = 3, major = 5, ip_version = 6, formspec_version = 3, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.3.0", avg_rtt = 0.266999989748, state = "Active", avg_jitter = 0.074999988079071, min_jitter = 0, address = "::ffff:50.34.122.230" } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 7880\", \"3d_armor:chestplate_crystal 1 7880\", \"3d_armor:leggings_crystal 1 7880\", \"3d_armor:boots_crystal 1 7880\", \"shields:shield_crystal 1 7880\", \"\"}", played_time = "420442", jointime = "1621665541", yl_commons_player_joined = "1625279060", ["signslib:pos"] = "(2044,17,1187)", digged_nodes = "78760", bitten = "0", yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"x\"] = 3978, [\"z\"] = 3300}, [\"last_death_portal\"] = 1625026636}", ["stamina:level"] = "15", punch_count = "4570", arenalib_infobox_arenaID = "0", crafted = "5566", yl_commons_thankyou = "1", xp = "69228", placed_nodes = "19677", died = "9", hud_state = "on", repellant = "0", yl_commons_player_created = "1621665541" } } ``` Log identifier ``` [MOD] yl_report log identifier = 6Cn0Xi984adVA46I9V1fOLaHUWi3UdY4 ``` Profiler save: ``` profile-20210703T082616.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=213713, max_lag=2.14279, clients={AliasAlreadyTaken, Service, whostand, Bailiff, DeepDweller, Hasbro, whosit, Xonon, Bingo, Sandra, noodles} ```

AliasAlreadyTaken was assigned by yourland-report

2021-07-03 06:26:16 +00:00

whosit commented

2021-07-03 06:55:43 +00:00

When you "sit", player:move_to(pos) is called, where pos is center of the node where the chair is.
At this position, top of player's hitbox is already clipping through the block above them, so when they stand up, normal MT physics kicks in and player is allowed to move out of the block they are clipped through already.

Good solution will be setting player position to be at the floor level (not in the middle of the block) and just changing the sitting animation to display model 0.5 blocks higher.

Another solution is using move_to() when standing up, cottages mod does clicker:set_pos({x=pos.x,y=pos.y-0.5,z=pos.z}) when standing up and that prevents the clipping.

When you "sit", player:move_to(pos) is called, where `pos` is center of the node where the chair is. At this position, top of player's hitbox is already clipping through the block above them, so when they stand up, normal MT physics kicks in and player is allowed to move out of the block they are clipped through already. Good solution will be setting player position to be at the floor level (not in the middle of the block) and just changing the sitting animation to display model 0.5 blocks higher. Another solution is using move_to() when standing up, `cottages` mod does `clicker:set_pos({x=pos.x,y=pos.y-0.5,z=pos.z})` when standing up and that prevents the clipping.

AliasAlreadyTaken added the

3. source/mod upstream

1. kind/bug

labels 2021-07-16 14:30:16 +00:00

flux added this to the flux's TODO list project 2022-07-14 02:51:42 +00:00

flux removed this from the flux's TODO list project 2022-07-14 02:52:22 +00:00

Sign in to join this conversation.