noodles reports: trying to "rhotate" insulated ... #545
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#545
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
noodles reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
For reference, this is an issue for the rhotator for things with
on_rotate = screwdriver.rotate_simple
. The insulated wires can be rotated with a normal screwdriver, which makes this annoying.closing this; it's a fundamental mismatch between the screwdriver API and the rhotator API. if we want to continue using both mods, this will always be an issue.
the screwdriver defines an
on_rotate
callback:"mode" is defined via the following 2 constants:
these wires, along w/ certain other nodes (e.g. nodes w/
legacy_facedir_simple = true
) only allow "face" rotation, meaning they'll spin around the y axis, but disallow changing the axis.it is assumed that new_param2 is a valid value according to these semantics.
rhotator takes this API and completely ignores the semantics of it. it re-defines mode:
these seem to correlate to "sneak-click" and "click" by default, but i think they can be overridden. in any event, they do not correlate to what the on_rotate callbacks expect them to mean. the param2 values passed are not valid. using sneak-click, you can even get the wire into an invalid orientation:
fortunately this doesn't seem to crash anything, but the wire does not transmit signal in a sane way.
related upstream issue, which if solved still won't fix the bug here: https://github.com/entuland/rhotator/issues/10