Dirac reports: petz camels with saddlebags at ... #4661
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#4661
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Dirac reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
It is worse than originally described.
Exploit details:
Possible remedies:
I think any of these could be implemented cleanly as config options upstream. Probably 1 and 2 are the simplest to implement.
Additionally, I think recursive camel storage is a flat-out bug. There's no way Runsy intended that. I created an issue upstream for that bit.
with deep enough recursion, the size of metadata will grow beyond limits (like max size of packet limit) and causing issues (lag for anybody seeing the camel) or just crashing the server.
this is not what i'd consider an "effective" infinite inventory glitch - it's a bit annoying to take out recursively stored camels or remember what's stored w/ each camel. but the metadata growth thing could actually cause problems, so it's probably worth fixing.
upstream issue that someone reported: https://github.com/runsy/petz/issues/186
i agree w/ alias that the best solution is probably to prevent picking up camels w/ saddlebags that have anything in them.
upstream is supposedly fixed; you shouldn't be able to pick up camels w/ bags attached. use shears to remove bags.
Making it impossible to pick them up sounds like a bit much. Just not allowing to store a camel in a camel bag would be best.
Seems like we need some marker for preventing recursive storage? Technic chests + wrench (if we'd have it) and now camels all need it.
i feel like some sort of general mechanism would come up against the halting problem, but more pragmatically, the means of restricting whether an item can go into an inventory is a hodge-podge between node entities, detached inventories, and player inventories, as well as various other mods which modify inventories directly. the mechanics for associating an inventory with a specific item are also not standardized.
this is live ("You cannot capture animals with a SADDLEBAG!")