Dirac reports: Add a way for players to view ... #4654

New Issue

yourland-report · 2023-06-01T08:52:58Z

yourland-report commented

2023-06-01 08:52:58 +00:00

Dirac reports a bug:

Add a way for players to view a longer log of items that were trashed (even items that can't be retrieved).

Player position:

{
	y = 14.5,
	z = 1154.9429931641,
	x = 2000.5260009766
}

Player look:

{
	y = -0.036643706262112,
	z = 0.46653532981873,
	x = 0.88374316692352
}

Player information:

{
	minor = 6,
	protocol_version = 41,
	max_rtt = 5.3829998970032,
	formspec_version = 6,
	lang_code = "",
	version_string = "5.6.1",
	min_jitter = 0,
	ip_version = 6,
	min_rtt = 0.10700000077486,
	avg_rtt = 0.11800000071526,
	major = 5,
	max_jitter = 5.2659997940063,
	avg_jitter = 0.0019999966025352,
	connection_uptime = 23694,
	serialization_version = 29,
	patch = 1,
	state = "Active"
}

Player meta:

{
	fields = {
		["ocean_build.last_warning"] = "1.68508e+09",
		digged_nodes = "180884",
		hud_state = "on",
		["stamina:poisoned"] = "no",
		repellant = "0",
		arenalib_infobox_arenaID = "0",
		punch_count = "24359",
		["stamina:level"] = "16",
		inflicted_damage = "513732",
		yl_church = "return {[\"last_heal\"] = 1685407971, [\"last_death\"] = {[\"y\"] = 18, [\"z\"] = 1089, [\"x\"] = 3054}, [\"last_death_portal\"] = 1685607006}",
		partychat = "party",
		yl_commons_player_joined = "1685585904",
		xp = "150024",
		yl_commons_player_created = "1644856923",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["3d_armor_inventory"] = "return {\"3d_armor:leggings_crystal 1 3474\", \"shields:shield_rainbow 1 15334\", \"3d_armor:helmet_nether 1 2300\", \"3d_armor:chestplate_crystal 1 25460\", \"3d_armor:boots_crystal 1 25460\", \"\"}",
		["ocean_build.ocean_built"] = "1",
		jointime = "1644856923",
		bitten = "0",
		yl_commons_thankyou = "20",
		played_time = "1952339",
		["signslib:pos"] = "(2146,18,1124)",
		placed_nodes = "60293",
		died = "121",
		crafted = "62852",
		["stamina:exhaustion"] = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = qbQxlmIlP2UOUACmBrDY1gfdKEaSCuiC

Profiler save:

profile-20230601T085258.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 10h 23min 32s | max lag: 0.55s | clients (24/52): 9T9, AliasAlreadyTaken, Bailiff, BibaBoba, Bobcat, Chache, daydream, Dirac, Ecklair, evil123, flux, Ganyu, goatastronaut, HorusDamocles, melone, mr_block, Murmel, pisokc, Qualia, Service, Shadow, Talos, Taylor58, ZwerOxotnik

Teleport command:

/teleport xyz 2001 15 1155

Compass command:

/give_compass Construction qbQxlmIlP2UOUACmBrDY1gfdKEaSCuiC D2691E 2001 15 1155

Dirac reports a bug: > Add a way for players to view a longer log of items that were trashed (even items that can't be retrieved). Player position: ``` { y = 14.5, z = 1154.9429931641, x = 2000.5260009766 } ``` Player look: ``` { y = -0.036643706262112, z = 0.46653532981873, x = 0.88374316692352 } ``` Player information: ``` { minor = 6, protocol_version = 41, max_rtt = 5.3829998970032, formspec_version = 6, lang_code = "", version_string = "5.6.1", min_jitter = 0, ip_version = 6, min_rtt = 0.10700000077486, avg_rtt = 0.11800000071526, major = 5, max_jitter = 5.2659997940063, avg_jitter = 0.0019999966025352, connection_uptime = 23694, serialization_version = 29, patch = 1, state = "Active" } ``` Player meta: ``` { fields = { ["ocean_build.last_warning"] = "1.68508e+09", digged_nodes = "180884", hud_state = "on", ["stamina:poisoned"] = "no", repellant = "0", arenalib_infobox_arenaID = "0", punch_count = "24359", ["stamina:level"] = "16", inflicted_damage = "513732", yl_church = "return {[\"last_heal\"] = 1685407971, [\"last_death\"] = {[\"y\"] = 18, [\"z\"] = 1089, [\"x\"] = 3054}, [\"last_death_portal\"] = 1685607006}", partychat = "party", yl_commons_player_joined = "1685585904", xp = "150024", yl_commons_player_created = "1644856923", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["3d_armor_inventory"] = "return {\"3d_armor:leggings_crystal 1 3474\", \"shields:shield_rainbow 1 15334\", \"3d_armor:helmet_nether 1 2300\", \"3d_armor:chestplate_crystal 1 25460\", \"3d_armor:boots_crystal 1 25460\", \"\"}", ["ocean_build.ocean_built"] = "1", jointime = "1644856923", bitten = "0", yl_commons_thankyou = "20", played_time = "1952339", ["signslib:pos"] = "(2146,18,1124)", placed_nodes = "60293", died = "121", crafted = "62852", ["stamina:exhaustion"] = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = qbQxlmIlP2UOUACmBrDY1gfdKEaSCuiC ``` Profiler save: ``` profile-20230601T085258.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 10h 23min 32s | max lag: 0.55s | clients (24/52): 9T9, AliasAlreadyTaken, Bailiff, BibaBoba, Bobcat, Chache, daydream, Dirac, Ecklair, evil123, flux, Ganyu, goatastronaut, HorusDamocles, melone, mr_block, Murmel, pisokc, Qualia, Service, Shadow, Talos, Taylor58, ZwerOxotnik ``` Teleport command: ``` /teleport xyz 2001 15 1155 ``` Compass command: ``` /give_compass Construction qbQxlmIlP2UOUACmBrDY1gfdKEaSCuiC D2691E 2001 15 1155 ```

AliasAlreadyTaken was assigned by yourland-report

2023-06-01 08:52:58 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-06-01 12:12:32 +00:00

AliasAlreadyTaken commented

2023-06-01 12:12:57 +00:00

What's the usecase? And how long should that history go back?

Boot commented

2023-06-01 16:46:45 +00:00

Gone is gone. Anything else will only result in more work for the admin.

Dirac commented

2023-06-02 01:03:33 +00:00

Personally, I just want to know if I accidentally deleted something while busy (e.g. fighting Voice). Could go back 25-50 entries for the current session, and be only viewable via command (i.e. a power user's tool).

Ultimately, this probably becomes less useful once the click/drag fixes are merged. I wrote this issue while annoyed that I apparently accidentally deleted a bunch of rainbow that as wdropped while fighting voice (presumably happened due to inventory shuffling to make space for other drops).

Personally, I just want to know if I accidentally deleted something while busy (e.g. fighting Voice). Could go back 25-50 entries for the current session, and be only viewable via command (i.e. a power user's tool). Ultimately, this probably becomes less useful once the click/drag fixes are merged. I wrote this issue while annoyed that I apparently accidentally deleted a bunch of rainbow that as wdropped while fighting voice (presumably happened due to inventory shuffling to make space for other drops).

AliasAlreadyTaken commented

2023-06-02 01:46:18 +00:00

The new trashcan mechanic which allows recovery of up to four items should defend against missclicks of that sort, unless you trash half an inventory first and then notice something is missing. If you really wish to clean up, open the trashcan tab and shift click the items you want to get rid of into the trashcan, review, then flush.

Unfortunately we can't defend against everything. If there is really something you desperately need to know, we can look up in the log what got trashed and try to recover unique things like your diary. This is not a game mechanic though, rather an emergency measure. We cannot restore items that got lost this way.

To not give this impression, I'd rather not implement the suggested command.

Vote wontfix

The new trashcan mechanic which allows recovery of up to four items should defend against missclicks of that sort, unless you trash half an inventory first and then notice something is missing. If you really wish to clean up, open the trashcan tab and shift click the items you want to get rid of into the trashcan, review, then flush. Unfortunately we can't defend against everything. If there is really something you desperately need to know, we can look up in the log what got trashed and try to recover unique things like your diary. This is not a game mechanic though, rather an emergency measure. We cannot restore items that got lost this way. To not give this impression, I'd rather not implement the suggested command. Vote wontfix

👍 3

Sign in to join this conversation.