Azelf reports: Tapestries are impossible to c ... #4651

New Issue

yourland-report · 2023-06-01T00:30:15Z

yourland-report commented

2023-06-01 00:30:15 +00:00

Azelf reports a bug:

Tapestries are impossible to craft due to recipe collision with a string recipe

Player position:

{
	y = -4158.4990234375,
	z = -3044.1528320313,
	x = 152.80000305176
}

Player look:

{
	y = -0.36308860778809,
	z = -0.51819586753845,
	x = -0.77436399459839
}

Player information:

{
	minor = 7,
	protocol_version = 42,
	max_rtt = 3.2990000247955,
	ip_version = 6,
	min_rtt = 0.16500000655651,
	avg_rtt = 0.1710000038147,
	min_jitter = 0,
	max_jitter = 3.0520000457764,
	avg_jitter = 0.0050000101327896,
	connection_uptime = 4098,
	serialization_version = 29,
	patch = 0,
	major = 5,
	version_string = "5.7.0",
	lang_code = "",
	formspec_version = 6,
	state = "Active"
}

Player meta:

{
	fields = {
		["ocean_build.last_warning"] = "1.67602e+09",
		["ocean_build.ocean_built"] = "11",
		digged_nodes = "593181",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		repellant = "0",
		partychat = "party",
		punch_count = "178299",
		yl_church = "return {[\"last_heal\"] = 1678197363, [\"last_death\"] = {[\"y\"] = 143, [\"z\"] = 4625, [\"x\"] = -912}, [\"last_death_portal\"] = 1685577086}",
		inflicted_damage = "3820418",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:level"] = "12",
		["stamina:poisoned"] = "no",
		yl_commons_player_created = "1659363683",
		yl_commons_player_joined = "1685575329",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 1912\", \"3d_armor:chestplate_rainbow 1 1912\", \"shields:shield_rainbow 1 1912\", \"\", \"3d_armor:leggings_rainbow 1 1912\", \"3d_armor:boots_crystal 1 4780\"}",
		xp = "728222",
		jointime = "1659363683",
		bitten = "0",
		yl_commons_thankyou = "57",
		played_time = "3345010",
		["signslib:pos"] = "(145,-4161,-3061)",
		placed_nodes = "170165",
		died = "97",
		crafted = "277567",
		["stamina:exhaustion"] = "129"
	}
}

Log identifier


[MOD] yl_report log identifier = 5IF58bQyq1VUeyjtKUEfxsHWgbwKn8jn

Profiler save:

profile-20230601T003014.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 50min 52s | max lag: 0.454s | clients (14/52): AliasAlreadyTaken, Aliza, Azelf, Bailiff, daydream, evil123, flux, mahou, Nodes, Nomtom, ScoutTrooper, Service, shanish2, Talos

Teleport command:

/teleport xyz 153 -4158 -3044

Compass command:

/give_compass Construction 5IF58bQyq1VUeyjtKUEfxsHWgbwKn8jn D2691E 153 -4158 -3044

Azelf reports a bug: > Tapestries are impossible to craft due to recipe collision with a string recipe Player position: ``` { y = -4158.4990234375, z = -3044.1528320313, x = 152.80000305176 } ``` Player look: ``` { y = -0.36308860778809, z = -0.51819586753845, x = -0.77436399459839 } ``` Player information: ``` { minor = 7, protocol_version = 42, max_rtt = 3.2990000247955, ip_version = 6, min_rtt = 0.16500000655651, avg_rtt = 0.1710000038147, min_jitter = 0, max_jitter = 3.0520000457764, avg_jitter = 0.0050000101327896, connection_uptime = 4098, serialization_version = 29, patch = 0, major = 5, version_string = "5.7.0", lang_code = "", formspec_version = 6, state = "Active" } ``` Player meta: ``` { fields = { ["ocean_build.last_warning"] = "1.67602e+09", ["ocean_build.ocean_built"] = "11", digged_nodes = "593181", hud_state = "on", arenalib_infobox_arenaID = "0", repellant = "0", partychat = "party", punch_count = "178299", yl_church = "return {[\"last_heal\"] = 1678197363, [\"last_death\"] = {[\"y\"] = 143, [\"z\"] = 4625, [\"x\"] = -912}, [\"last_death_portal\"] = 1685577086}", inflicted_damage = "3820418", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:level"] = "12", ["stamina:poisoned"] = "no", yl_commons_player_created = "1659363683", yl_commons_player_joined = "1685575329", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 1912\", \"3d_armor:chestplate_rainbow 1 1912\", \"shields:shield_rainbow 1 1912\", \"\", \"3d_armor:leggings_rainbow 1 1912\", \"3d_armor:boots_crystal 1 4780\"}", xp = "728222", jointime = "1659363683", bitten = "0", yl_commons_thankyou = "57", played_time = "3345010", ["signslib:pos"] = "(145,-4161,-3061)", placed_nodes = "170165", died = "97", crafted = "277567", ["stamina:exhaustion"] = "129" } } ``` Log identifier ``` [MOD] yl_report log identifier = 5IF58bQyq1VUeyjtKUEfxsHWgbwKn8jn ``` Profiler save: ``` profile-20230601T003014.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 50min 52s | max lag: 0.454s | clients (14/52): AliasAlreadyTaken, Aliza, Azelf, Bailiff, daydream, evil123, flux, mahou, Nodes, Nomtom, ScoutTrooper, Service, shanish2, Talos ``` Teleport command: ``` /teleport xyz 153 -4158 -3044 ``` Compass command: ``` /give_compass Construction 5IF58bQyq1VUeyjtKUEfxsHWgbwKn8jn D2691E 153 -4158 -3044 ```

AliasAlreadyTaken was assigned by yourland-report

2023-06-01 00:30:15 +00:00

AzelfYL commented

2023-06-01 00:34:52 +00:00

Disregard the impossible part - the recipe is formless so alternative crafting arrangements can produce it, but I think the recipe in the crafting guide should be altered to make sure no one accidentally crafts a huge quantity of string instead of tapestries - rip my stack of wool

AliasAlreadyTaken commented

2023-06-01 01:26:37 +00:00

It#s still a collison and we'll fix it

AliasAlreadyTaken added the

3. source/integration

label 2023-06-01 01:26:46 +00:00

flux added the

1. kind/bug

4. step/ready to QA test

labels 2023-06-01 16:05:51 +00:00

flux commented

2023-06-01 16:05:58 +00:00

fixed in 2fdbf22d0d

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/2fdbf22d0d9fd53784c15d271f3352e5337a2744

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-06-02 02:54:27 +00:00

AliasAlreadyTaken commented

2023-06-02 02:56:59 +00:00

Since the "wool to string" recipe was added lately, we should rather change the YL specific "wool to string" recipe than the upstream tapestry recipe.

Wool to string:

55911dd830

Since the "wool to string" recipe was added lately, we should rather change the YL specific "wool to string" recipe than the upstream tapestry recipe. Wool to string: https://gitea.your-land.de/your-land/yl_commons/commit/55911dd8303e31eec7b190956595b764d20d8a8b

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-06-02 02:57:21 +00:00

flux commented

2023-06-02 16:07:30 +00:00

Since the "wool to string" recipe was added lately, we should rather change the YL specific "wool to string" recipe than the upstream tapestry recipe.

Wool to string:

55911dd830

the reason why i changed the tapestry recipe is that it's shapeless - unless we changed the ingredients of the wool-to-string recipe, any orientation would conflict.

> Since the "wool to string" recipe was added lately, we should rather change the YL specific "wool to string" recipe than the upstream tapestry recipe. > > Wool to string: > > https://gitea.your-land.de/your-land/yl_commons/commit/55911dd8303e31eec7b190956595b764d20d8a8b the reason why i changed the tapestry recipe is that it's shapeless - unless we changed the ingredients of the wool-to-string recipe, any orientation would conflict.

👍 1

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-08-29 21:32:50 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-11-16 22:46:41 +00:00

AliasAlreadyTaken was unassigned by flux