chesttools crash #4641

Open
opened 2023-05-30 18:32:00 +00:00 by flux · 9 comments
Member
2023-05-29 13:36:06: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'chesttools' in callback on_playerReceiveFields(): Invalid vector (expected table got nil).
2023-05-29 13:36:06: ERROR[Main]: stack traceback:
2023-05-29 13:36:06: ERROR[Main]: 	[C]: in function 'get_meta'
2023-05-29 13:36:06: ERROR[Main]: 	...e/mt/5.6.1/Minetest_live/bin/../mods/chesttools/init.lua:98: in function 'may_use'
2023-05-29 13:36:06: ERROR[Main]: 	...e/mt/5.6.1/Minetest_live/bin/../mods/chesttools/init.lua:425: in function 'func'
2023-05-29 13:36:06: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
2023-05-29 13:36:06: ERROR[Main]: 	.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417>
``` 2023-05-29 13:36:06: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'chesttools' in callback on_playerReceiveFields(): Invalid vector (expected table got nil). 2023-05-29 13:36:06: ERROR[Main]: stack traceback: 2023-05-29 13:36:06: ERROR[Main]: [C]: in function 'get_meta' 2023-05-29 13:36:06: ERROR[Main]: ...e/mt/5.6.1/Minetest_live/bin/../mods/chesttools/init.lua:98: in function 'may_use' 2023-05-29 13:36:06: ERROR[Main]: ...e/mt/5.6.1/Minetest_live/bin/../mods/chesttools/init.lua:425: in function 'func' 2023-05-29 13:36:06: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> 2023-05-29 13:36:06: ERROR[Main]: .../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417> ```
flux added the
1. kind/bug
3. source/mod upstream
2. prio/critical
labels 2023-05-30 18:32:00 +00:00
Author
Member

whosit wrote on the other page:

2023-05-29 13:35:50: ACTION[Server]: [yl_commons] formspec "chesttools:update": Buzz submitted {"pos2str":"(2012,-2769,1523)a","quit":"true","shared":"shared"}
What the hell is that "a" after the coords?
So, that "a" comes from a hidden "field" in a formspec that you can type into by accident if you press "tab" a couple of times.

To reproduce: get normal chest, punch it with shared chest, then when form opens press "Tab,a,Tab,a ..." (idk how many times). Close the form and server crashes.

Thanks Test_User for figuring that out.
Sokomine is informed.
whosit wrote on the other page: ``` 2023-05-29 13:35:50: ACTION[Server]: [yl_commons] formspec "chesttools:update": Buzz submitted {"pos2str":"(2012,-2769,1523)a","quit":"true","shared":"shared"} What the hell is that "a" after the coords? ``` ``` So, that "a" comes from a hidden "field" in a formspec that you can type into by accident if you press "tab" a couple of times. To reproduce: get normal chest, punch it with shared chest, then when form opens press "Tab,a,Tab,a ..." (idk how many times). Close the form and server crashes. Thanks Test_User for figuring that out. ``` ``` Sokomine is informed. ```
Author
Member

for reference, passing the position of a node like that in a formspec is considered an antipattern, see https://forum.minetest.net/viewtopic.php?t=19129

for reference, passing the position of a node like that in a formspec is considered an antipattern, see https://forum.minetest.net/viewtopic.php?t=19129
Member

Heh, found this much older closed issue that seems to be the same too:
#506 (comment)

Heh, found this much older closed issue that seems to be the same too: https://gitea.your-land.de/your-land/bugtracker/issues/506#issuecomment-9454
Author
Member

this is fixed upstream, but not in yl_stable.

this is fixed upstream, but not in yl_stable.
Member

this is fixed upstream, but not in yl_stable.

This fix: c851ab7e16

It will prevent crash, but players will still be able to fiddle with pos field...

> this is fixed upstream, but not in yl_stable. This fix: https://github.com/Sokomine/chesttools/pull/3/commits/c851ab7e16dad2765b126511ef009b752b0da2bf It will prevent crash, but players will still be able to fiddle with `pos` field...

For the time being I added the fix of c851ab7e16

For the time being I added the fix of https://github.com/Sokomine/chesttools/pull/3/commits/c851ab7e16dad2765b126511ef009b752b0da2bf

Apparently my dumbfix disabled pipeworks functionality. Now the bugfix was added temporarily to yl_commons until it is fixed upstream

Apparently my dumbfix disabled pipeworks functionality. Now the bugfix was added temporarily to yl_commons until it is fixed upstream

What exactly is the repro here? I tried to tab out of the "name" field, but cannot reproduce the issue atm?

What exactly is the repro here? I tried to tab out of the "name" field, but cannot reproduce the issue atm?
AliasAlreadyTaken added the
4. step/help wanted
label 2023-12-05 14:06:41 +00:00
Author
Member

What exactly is the repro here? I tried to tab out of the "name" field, but cannot reproduce the issue atm?

from above,

To reproduce: get normal chest, punch it with shared chest, then when form opens press "Tab,a,Tab,a ..." (idk how many times). Close the form and server crashes.

if that's not crashing the server now, we should consider the upstream fix to be live.

> What exactly is the repro here? I tried to tab out of the "name" field, but cannot reproduce the issue atm? from above, ``` To reproduce: get normal chest, punch it with shared chest, then when form opens press "Tab,a,Tab,a ..." (idk how many times). Close the form and server crashes. ``` if that's not crashing the server now, we should consider the upstream fix to be live.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4641
No description provided.