testserver venik tried to grab wielded light? #4574
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#4574
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I'm not sure how
wielded_light
ended up there.The crash happened in yl_commons, caused by the way I'm calling
on_punch(player)
without additional parameters. It works fine in vanilla, but yl_commons wrapson_punch()
functions and assumes that other parameters are not nil.I can prevent this crash from venik, by passing more args, or figuring other way to pick up stuff. (I'm not sure what is the right API to use here).
3c1e01fe2d/init.lua (L116)
Or
yl_commons
can be more defensive and don't assume that you punch stuff with something...530e79496f/features/tool_alert.lua (L337)
apparently the
groups
argument tominetest.get_hit_params
can benil
, but thetool_capabilities
cannot. i modified the tool alert code to avert a crash, but i've got no idea what dvornik/venik is.411088d876
2023-05-22 19:02:38: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'wielded_light' in callback environment_Step(): attempt to index a nil value
2023-05-22 19:02:38: ERROR[Main]: stack traceback:
2023-05-22 19:02:38: ERROR[Main]: [C]: in function 'get_hit_params'
2023-05-22 19:02:38: ERROR[Main]: ...test_test/bin/../mods/yl_commons/features/tool_alert.lua:358: in function 'on_punch'
2023-05-22 19:02:38: ERROR[Main]: ...t/bin/../worlds/Minetest_test/worldmods/dvornik/init.lua:116: in function 'try_to_pickup'
2023-05-22 19:02:38: ERROR[Main]: ...t/bin/../worlds/Minetest_test/worldmods/dvornik/init.lua:180: in function 'trace_and_pickup'
2023-05-22 19:02:38: ERROR[Main]: ...t/bin/../worlds/Minetest_test/worldmods/dvornik/init.lua:193: in function 'func'
2023-05-22 19:02:38: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101>
2023-05-22 19:02:38: ERROR[Main]: .../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:432>
I guess I should just stop pushing unfinished garbage for testing on the test server.