bailiff Invalid vector (expected table got nil). #4567

Closed
opened 2023-05-20 19:53:04 +00:00 by AliasAlreadyTaken · 8 comments
2023-05-20 19:51:00: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): Invalid vector (expected table got nil).
2023-05-20 19:51:00: ERROR[Main]: stack traceback:
2023-05-20 19:51:00: ERROR[Main]: 	[C]: in function 'move_to'
2023-05-20 19:51:00: ERROR[Main]: 	...t/5.6.1/Minetest_live/bin/../mods/yl_bailiff/bailiff.lua:535: in function 'execute'
2023-05-20 19:51:00: ERROR[Main]: 	...t/5.6.1/Minetest_live/bin/../mods/yl_bailiff/bailiff.lua:963: in function 'func'
2023-05-20 19:51:00: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function 'func'
2023-05-20 19:51:00: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.6.1/Minetest_live/bin/../builtin/game/chat.lua:52>
2023-05-20 19:51:00: ERROR[Main]: 	.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417>
``` 2023-05-20 19:51:00: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): Invalid vector (expected table got nil). 2023-05-20 19:51:00: ERROR[Main]: stack traceback: 2023-05-20 19:51:00: ERROR[Main]: [C]: in function 'move_to' 2023-05-20 19:51:00: ERROR[Main]: ...t/5.6.1/Minetest_live/bin/../mods/yl_bailiff/bailiff.lua:535: in function 'execute' 2023-05-20 19:51:00: ERROR[Main]: ...t/5.6.1/Minetest_live/bin/../mods/yl_bailiff/bailiff.lua:963: in function 'func' 2023-05-20 19:51:00: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function 'func' 2023-05-20 19:51:00: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.6.1/Minetest_live/bin/../builtin/game/chat.lua:52> 2023-05-20 19:51:00: ERROR[Main]: .../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417> ```
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
labels 2023-05-20 19:57:43 +00:00
Author
Owner

Since the bailiff had odd issues when looking at someone I rolled back the bailiff to the old commands for the time being.

Since the bailiff had odd issues when looking at someone I rolled back the bailiff to the old commands for the time being.
Member

5d007fbdf0/bailiff.lua (L532)

  if not to_vector(param[1], param[2], param[3]) then return "Invalid position" end

  reset_pos_states()
  bailiff:move_to(to_vector(param[2], param[3], param[4]))
  return yl_bailiff.name.." teleported to position ("..param[2]..", "..param[3]..", "..param[4]..")"

Possible typo? Notice it checks for 1-3 then uses 2-4.

https://gitea.your-land.de/your-land/yl_bailiff/src/commit/5d007fbdf04f9ba99d53244e096d0fb19444f2df/bailiff.lua#L532 ```lua if not to_vector(param[1], param[2], param[3]) then return "Invalid position" end reset_pos_states() bailiff:move_to(to_vector(param[2], param[3], param[4])) return yl_bailiff.name.." teleported to position ("..param[2]..", "..param[3]..", "..param[4]..")" ``` Possible typo? Notice it checks for 1-3 then uses 2-4.
Author
Owner

Repro:

/stream come to pos 2020 20 1175

Leads to the same error:

2023-05-20 20:31:02: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): .../mt/5.7.0/Minetest_test/bin/../builtin/common/vector.lua:374: attempt to index local 'v' (a nil value)
2023-05-20 20:31:02: ERROR[Main]: stack traceback:
2023-05-20 20:31:02: ERROR[Main]: 	.../mt/5.7.0/Minetest_test/bin/../builtin/common/vector.lua:374: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/common/vector.lua:373>
2023-05-20 20:31:02: ERROR[Main]: 	[C]: in function 'move_to'
2023-05-20 20:31:02: ERROR[Main]: 	...t/5.7.0/Minetest_test/bin/../mods/yl_bailiff/bailiff.lua:535: in function 'execute'
2023-05-20 20:31:02: ERROR[Main]: 	...t/5.7.0/Minetest_test/bin/../mods/yl_bailiff/bailiff.lua:963: in function 'func'
2023-05-20 20:31:02: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function 'func'
2023-05-20 20:31:02: ERROR[Main]: 	/home/mt/5.7.0/Minetest_test/bin/../builtin/game/chat.lua:79: in function </home/mt/5.7.0/Minetest_test/bin/../builtin/game/chat.lua:52>
2023-05-20 20:31:02: ERROR[Main]: 	.../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:432>
Repro: ``` /stream come to pos 2020 20 1175 ``` Leads to the same error: ``` 2023-05-20 20:31:02: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): .../mt/5.7.0/Minetest_test/bin/../builtin/common/vector.lua:374: attempt to index local 'v' (a nil value) 2023-05-20 20:31:02: ERROR[Main]: stack traceback: 2023-05-20 20:31:02: ERROR[Main]: .../mt/5.7.0/Minetest_test/bin/../builtin/common/vector.lua:374: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/common/vector.lua:373> 2023-05-20 20:31:02: ERROR[Main]: [C]: in function 'move_to' 2023-05-20 20:31:02: ERROR[Main]: ...t/5.7.0/Minetest_test/bin/../mods/yl_bailiff/bailiff.lua:535: in function 'execute' 2023-05-20 20:31:02: ERROR[Main]: ...t/5.7.0/Minetest_test/bin/../mods/yl_bailiff/bailiff.lua:963: in function 'func' 2023-05-20 20:31:02: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function 'func' 2023-05-20 20:31:02: ERROR[Main]: /home/mt/5.7.0/Minetest_test/bin/../builtin/game/chat.lua:79: in function </home/mt/5.7.0/Minetest_test/bin/../builtin/game/chat.lua:52> 2023-05-20 20:31:02: ERROR[Main]: .../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:446: in function <.../mt/5.7.0/Minetest_test/bin/../builtin/game/register.lua:432> ```
AliasAlreadyTaken added the
4. step/ready to QA test
label 2023-05-20 23:26:40 +00:00
AliasAlreadyTaken added this to the 1.1.120 milestone 2023-05-20 23:26:42 +00:00
Author
Owner

Fixed in afcf375938

Fixed in https://gitea.your-land.de/your-land/yl_bailiff/commit/afcf37593875a486efdbecb4d8382bc7a98ab8f0

Ah yeah sorry, I changed the command structure, but forgot to change the check... Thanks whosit :D

Ah yeah sorry, I changed the command structure, but forgot to change the check... Thanks whosit :D
Author
Owner

Is my dumbfix the way it should be or did I fix it "the wrong way" ?

Is my dumbfix the way it should be or did I fix it "the wrong way" ?

It's the right way :)

It's the right way :)
AliasAlreadyTaken added the
ugh/QA OK
label 2023-08-26 08:54:20 +00:00
Member

this is live, i assume, though the bailiff is offline.

this is live, i assume, though the bailiff is offline.
flux closed this issue 2023-11-16 22:32:16 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4567
No description provided.