smart_chat: when people talk to public from a channel, their name is duped in IRC #4496

Open
opened 2023-05-15 13:13:37 +00:00 by whosit · 2 comments
Member

Messages in IRC look like:

<YL> <whosit> [whosit]Text of the message

Problem may be here: (notice how the line is created using playername, and then sent to chat with playername again):
fd46605df8/cmd_all.lua (L73)

Should probably be the name of the channel they are talking from?

Messages in IRC look like: ```<YL> <whosit> [whosit]Text of the message``` Problem may be here: (notice how the line is created using playername, and then sent to chat with playername again): https://gitea.your-land.de/your-land/smart_chat/src/commit/fd46605df813b057d28b3bb6191f20c6a7ae8b41/cmd_all.lua#L73 Should probably be the name of the channel they are talking from?
whosit added the
3. source/mod upstream
2. prio/low
labels 2023-05-15 13:22:13 +00:00
whosit changed title from smart-chat: when people talk to public from the channel their name is duped in IRC to smart_chat: when people talk to public from the channel their name is duped in IRC 2023-05-15 13:36:23 +00:00
whosit changed title from smart_chat: when people talk to public from the channel their name is duped in IRC to smart_chat: when people talk to public from a channel, their name is duped in IRC 2023-05-15 13:36:46 +00:00
Member

i'm not sure why the channel you're in even gets published if you /c all.

i'm not sure why the channel you're in even gets published if you `/c all`.
whosit added the
1. kind/bug
label 2023-07-15 14:37:55 +00:00

I suppose this should be the external and internal name, instead of twice the internal name. However...

The ideal resolution is the bridge uses puppet method where the external service supports puppeting (Discord, Matrix/IRC). As-is with digest relay bot, need to decide what external and internal account names you want to expose on the bridge; Someone may have a name outside of Your Land that is acceptable for that service but when used with Your Land is not acceptable for Your Land chat, and review if there are any privacy / data law issues?

So maybe the quick fix is to reduce how much is displayed?

I suppose this should be the external and internal name, instead of twice the internal name. However... The ideal resolution is the bridge uses puppet method where the external service supports puppeting (Discord, Matrix/IRC). As-is with digest relay bot, need to decide what external and internal account names you want to expose on the bridge; Someone may have a name outside of Your Land that is acceptable for that service but when used with Your Land is not acceptable for Your Land chat, and review if there are any privacy / data law issues? So maybe the quick fix _is_ to reduce how much is displayed?
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4496
No description provided.