your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

minetest-craftsystem/do_registration.lua:52: craft output "farming:dandelion_tea" doesn't exist #4329

New Issue
Closed
opened 2023-04-28 16:03:40 +00:00 by AliasAlreadyTaken · 12 comments
AliasAlreadyTaken commented 2023-04-28 16:03:40 +00:00
Owner
Copy Link

Main server, when I disable arnea_lib and wormball, I get this error message:

2023-04-28 15:59:26: ACTION[Main]: Server: Shutting down
2023-04-28 15:59:27: ERROR[Main]: ModError: Runtime error from mod '??' in callback on_mods_loaded(): ..._live/worldmods/minetest-craftsystem/do_registration.lua:52: craft output "farming:dandelion_tea" doesn't exist
2023-04-28 15:59:27: ERROR[Main]: stack traceback:
2023-04-28 15:59:27: ERROR[Main]: 	[C]: in function 'error'
2023-04-28 15:59:27: ERROR[Main]: 	..._live/worldmods/minetest-craftsystem/do_registration.lua:52: in function 'analyze_and_register_shaped'
2023-04-28 15:59:27: ERROR[Main]: 	..._live/worldmods/minetest-craftsystem/do_registration.lua:145: in function <..._live/worldmods/minetest-craftsystem/do_registration.lua:140>
2023-04-28 15:59:27: ERROR[Main]: 	.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417>
Main server, when I disable arnea_lib and wormball, I get this error message: ``` 2023-04-28 15:59:26: ACTION[Main]: Server: Shutting down 2023-04-28 15:59:27: ERROR[Main]: ModError: Runtime error from mod '??' in callback on_mods_loaded(): ..._live/worldmods/minetest-craftsystem/do_registration.lua:52: craft output "farming:dandelion_tea" doesn't exist 2023-04-28 15:59:27: ERROR[Main]: stack traceback: 2023-04-28 15:59:27: ERROR[Main]: [C]: in function 'error' 2023-04-28 15:59:27: ERROR[Main]: ..._live/worldmods/minetest-craftsystem/do_registration.lua:52: in function 'analyze_and_register_shaped' 2023-04-28 15:59:27: ERROR[Main]: ..._live/worldmods/minetest-craftsystem/do_registration.lua:145: in function <..._live/worldmods/minetest-craftsystem/do_registration.lua:140> 2023-04-28 15:59:27: ERROR[Main]: .../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_live/bin/../builtin/game/register.lua:417> ```
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2023-04-28 16:04:35 +00:00
flux commented 2023-04-30 01:28:14 +00:00
Member
Copy Link

craftsystem needs to remember where recipes were registered in order to produce a useful error message. "farming:dandelion_tea" is from yl_seasons is it not? did that somehow get renamed or removed?

craftsystem needs to remember *where* recipes were registered in order to produce a useful error message. "farming:dandelion_tea" is from yl_seasons is it not? did that somehow get renamed or removed?
flux added this to the flux's TODO list project 2023-04-30 01:28:19 +00:00
flux commented 2023-04-30 01:28:58 +00:00
Member
Copy Link

i guess it's from yl_commons, huh.

i guess it's from yl_commons, huh.
flux commented 2023-04-30 01:29:39 +00:00
Member
Copy Link

no, it's defined in both places? blech.

no, it's defined in both places? blech.
AliasAlreadyTaken commented 2023-04-30 01:39:08 +00:00
Author
Owner
Copy Link

The question is why would this error appear suddenly, when a totally unrelated mod is disabled?

Do we depend on arena_lib somewhere where this tea is defined?

The question is why would this error appear suddenly, when a totally unrelated mod is disabled? Do we depend on arena_lib somewhere where this tea is defined?
flux commented 2023-04-30 19:34:53 +00:00
Member
Copy Link

The question is why would this error appear suddenly, when a totally unrelated mod is disabled?

Do we depend on arena_lib somewhere where this tea is defined?

you should look at the errors at the beginning of the server log, about which mods can't load. my guess is this dependency chain:

  • yl_commons -> quikbild -> arena_lib

from my local logs at some point in time:

2022-10-17 11:57:25: ERROR[Main]: mod "quikbild" has unsatisfied dependencies:  "arena_lib"
2022-10-17 11:57:25: ERROR[Main]: mod "wormball" has unsatisfied dependencies:  "arena_lib"
2022-10-17 11:57:25: ERROR[Main]: mod "yl_church" has unsatisfied dependencies:  "yl_commons"
2022-10-17 11:57:25: ERROR[Main]: mod "yl_commons" has unsatisfied dependencies:  "quikbild"
2022-10-17 11:57:25: ERROR[Main]: mod "yl_faq" has unsatisfied dependencies:  "yl_commons"
2022-10-17 11:57:25: ERROR[Main]: mod "yl_joinmessage" has unsatisfied dependencies:  "yl_commons"
> The question is why would this error appear suddenly, when a totally unrelated mod is disabled? > > Do we depend on arena_lib somewhere where this tea is defined? you should look at the errors at the beginning of the server log, about which mods can't load. my guess is this dependency chain: * yl_commons -> quikbild -> arena_lib from my local logs at some point in time: ``` 2022-10-17 11:57:25: ERROR[Main]: mod "quikbild" has unsatisfied dependencies: "arena_lib" 2022-10-17 11:57:25: ERROR[Main]: mod "wormball" has unsatisfied dependencies: "arena_lib" 2022-10-17 11:57:25: ERROR[Main]: mod "yl_church" has unsatisfied dependencies: "yl_commons" 2022-10-17 11:57:25: ERROR[Main]: mod "yl_commons" has unsatisfied dependencies: "quikbild" 2022-10-17 11:57:25: ERROR[Main]: mod "yl_faq" has unsatisfied dependencies: "yl_commons" 2022-10-17 11:57:25: ERROR[Main]: mod "yl_joinmessage" has unsatisfied dependencies: "yl_commons" ```
AliasAlreadyTaken commented 2023-04-30 19:35:34 +00:00
Author
Owner
Copy Link

Why would yl_commons depend on quikbuild? Was I drunk?

Why would yl_commons depend on quikbuild? Was I drunk?
flux commented 2023-04-30 19:35:49 +00:00
Member
Copy Link

probably the solution is to explicitly disable/remove quikbild and wormball when disabling arena_lib

probably the solution is to explicitly disable/remove quikbild and wormball when disabling arena_lib
flux commented 2023-04-30 19:37:15 +00:00
Member
Copy Link

Why would yl_commons depend on quikbuild? Was I drunk?

i think i added it when i was hiding quikbild items in unified_inventory

> Why would yl_commons depend on quikbuild? Was I drunk? i think i added it when i was hiding quikbild items in unified_inventory
flux commented 2023-04-30 19:37:43 +00:00
Member
Copy Link

see #1542

see #1542
AliasAlreadyTaken commented 2023-04-30 22:15:37 +00:00
Author
Owner
Copy Link

Ah :D

If I disable quickbuild, but yl_commons depends on it, will our whole dependency tree collapse?

Ah :D If I disable quickbuild, but yl_commons depends on it, will our whole dependency tree collapse?
flux commented 2023-05-02 00:42:45 +00:00
Member
Copy Link

Ah :D

If I disable quickbuild, but yl_commons depends on it, will our whole dependency tree collapse?

no, if it's disabled, it's not a problem. it's just a problem if it tries to load and fails.

> Ah :D > > If I disable quickbuild, but yl_commons depends on it, will our whole dependency tree collapse? no, if it's disabled, it's not a problem. it's just a problem if it tries to load and fails.
AliasAlreadyTaken commented 2023-12-05 13:53:36 +00:00
Author
Owner
Copy Link

Since we removed arena_lib, this is not an issue anymore.

At some point we may want to reenable, but that's going to be tested in another issue.

Until then, due to mod absence, we cannot reproduce.

Since we removed arena_lib, this is not an issue anymore. At some point we may want to reenable, but that's going to be tested in another issue. Until then, due to mod absence, we cannot reproduce.
AliasAlreadyTaken added the
5. result/cannot reproduce
 label 2023-12-05 13:53:41 +00:00
flux removed this from the flux's TODO list project 2023-12-22 20:46:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#4329
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?