yl_commons/util/treesize.lua:99: attempt to index local 'def' (a nil value) #4281

New Issue

AliasAlreadyTaken · 2023-04-25T23:14:11Z

AliasAlreadyTaken commented

2023-04-25 23:14:11 +00:00

2023-04-25 23:13:29: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_monster' in callback luaentity_Step(): ...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: attempt to index local 'def' (a nil value)
2023-04-25 23:13:29: ERROR[Main]: stack traceback:
2023-04-25 23:13:29: ERROR[Main]: 	...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: in function 'can_grow'
2023-04-25 23:13:29: ERROR[Main]: 	..../mods/yl_commons/features/land_guard_plant_saplings.lua:166: in function 'on_replace'
2023-04-25 23:13:29: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:1617: in function 'replace'
2023-04-25 23:13:29: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:3453: in function 'func'
2023-04-25 23:13:29: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>

``` 2023-04-25 23:13:29: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_monster' in callback luaentity_Step(): ...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: attempt to index local 'def' (a nil value) 2023-04-25 23:13:29: ERROR[Main]: stack traceback: 2023-04-25 23:13:29: ERROR[Main]: ...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: in function 'can_grow' 2023-04-25 23:13:29: ERROR[Main]: ..../mods/yl_commons/features/land_guard_plant_saplings.lua:166: in function 'on_replace' 2023-04-25 23:13:29: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:1617: in function 'replace' 2023-04-25 23:13:29: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:3453: in function 'func' 2023-04-25 23:13:29: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> ```

AliasAlreadyTaken added the

1. kind/bug

2. prio/critical

labels 2023-04-25 23:14:20 +00:00

AliasAlreadyTaken commented

2023-04-25 23:16:45 +00:00

Dumbfix:

local height = def.height or 0
local radius = def.radius or 0

if height == 0 or radius == 0 then
    return nil, "Sapling shows 0 for height or radius"
end

=>


local height = def.height or 0
local radius = def.radius or 0

if height == 0 or radius == 0 then
    return nil, "Sapling shows 0 for height or radius"
end

Dumbfix: ``` local height = def.height or 0 local radius = def.radius or 0 if height == 0 or radius == 0 then return nil, "Sapling shows 0 for height or radius" end ``` => ``` local height = def.height or 0 local radius = def.radius or 0 if height == 0 or radius == 0 then return nil, "Sapling shows 0 for height or radius" end ```

👍 1

flux commented

2023-04-25 23:20:19 +00:00

ah, this was due to me testing the land guards. hmmm.

flux commented

2023-04-25 23:25:47 +00:00

dumbfix was pretty good, i added a little more logic to report which tree isn't registered. dd3de629c0

dumbfix was pretty good, i added a little more logic to report *which* tree isn't registered. https://gitea.your-land.de/your-land/yl_commons/commit/dd3de629c02961f8af643bbe520759bf08c7564a

flux added the

4. step/ready to QA test

label 2023-04-25 23:26:01 +00:00

flux referenced this issue

2023-04-25 23:28:14 +00:00

flux reports: landguards should only plant * ... #3935

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-04-25 23:42:10 +00:00

AliasAlreadyTaken commented

2023-04-26 20:01:34 +00:00

2023-04-26 20:00:29: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_monster' in callback luaentity_Step(): ...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: attempt to index local 'def' (a nil value)
2023-04-26 20:00:29: ERROR[Main]: stack traceback:
2023-04-26 20:00:29: ERROR[Main]: 	...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: in function 'can_grow'
2023-04-26 20:00:29: ERROR[Main]: 	..../mods/yl_commons/features/land_guard_plant_saplings.lua:166: in function 'on_replace'
2023-04-26 20:00:29: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:1617: in function 'replace'
2023-04-26 20:00:29: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:3453: in function 'func'
2023-04-26 20:00:29: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>

``` 2023-04-26 20:00:29: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_monster' in callback luaentity_Step(): ...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: attempt to index local 'def' (a nil value) 2023-04-26 20:00:29: ERROR[Main]: stack traceback: 2023-04-26 20:00:29: ERROR[Main]: ...1/Minetest_live/bin/../mods/yl_commons/util/treesize.lua:99: in function 'can_grow' 2023-04-26 20:00:29: ERROR[Main]: ..../mods/yl_commons/features/land_guard_plant_saplings.lua:166: in function 'on_replace' 2023-04-26 20:00:29: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:1617: in function 'replace' 2023-04-26 20:00:29: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/mobs_redo/api.lua:3453: in function 'func' 2023-04-26 20:00:29: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> ```

AliasAlreadyTaken added the

ugh/QA main

label 2023-05-09 07:36:08 +00:00

AliasAlreadyTaken commented

2023-08-23 14:04:39 +00:00

No issue with this on main.

AliasAlreadyTaken closed this issue

2023-08-23 14:04:39 +00:00

AliasAlreadyTaken added

5. result/fixed

and removed

4. step/ready to QA test